Report warning on unused entities that can be renamed to _

Currently it's all about lambda parameters/destructuring entries

 #KT-14347 In Progress
This commit is contained in:
Denis Zharkov
2016-10-13 16:44:27 +03:00
parent a9fcee098d
commit 4c69416f2b
56 changed files with 123 additions and 121 deletions
+7 -7
View File
@@ -5,15 +5,15 @@ class A {
fun arrayA(): Array<A> = null!!
fun foo(a: A, <warning>c</warning>: Int) {
val (<warning descr="[NAME_SHADOWING] Name shadowed: a">a</warning>, <warning>b</warning>) = a
fun foo(a: A, <warning descr="[UNUSED_PARAMETER] Parameter 'c' is never used">c</warning>: Int) {
val (<warning descr="[NAME_SHADOWING] Name shadowed: a"><warning descr="[UNUSED_VARIABLE] Variable 'a' is never used">a</warning></warning>, <warning descr="[UNUSED_VARIABLE] Variable 'b' is never used">b</warning>) = a
val arr = arrayA()
for ((<warning descr="[NAME_SHADOWING] Name shadowed: c">c</warning>, <warning>d</warning>) in arr) {
for ((<warning descr="[NAME_SHADOWING] Name shadowed: c"><warning descr="[UNUSED_VARIABLE] Variable 'c' is never used">c</warning></warning>, <warning descr="[UNUSED_VARIABLE] Variable 'd' is never used">d</warning>) in arr) {
}
}
fun f(<warning>p</warning>: Int): Int {
val <error>p</error> = 2
val <error>p</error> = 3
fun f(<warning descr="[UNUSED_PARAMETER] Parameter 'p' is never used">p</warning>: Int): Int {
val <error descr="">p</error> = 2
val <error descr="">p</error> = 3
return p
}
}
@@ -1,3 +1,3 @@
fun main() {
for ((i, <warning>j</warning>)<error>)</error> {}
}
for ((<warning>i</warning>, <warning>j</warning>)<error>)</error> {}
}
+2 -2
View File
@@ -3,6 +3,6 @@ fun foo1() : (Int) -> Int = { x: Int -> x }
fun foo() {
val h : (Int) -> Int = foo1();
h(1)
val m : (Int) -> Int = {a : Int -> 1}//foo1()
val m : (Int) -> Int = {<warning descr="[UNUSED_PARAMETER] Parameter 'a' is never used">a</warning> : Int -> 1}//foo1()
m(1)
}
}