Introduct "Redundant 'with' call" inspection #KT-6633 Fixed

idea/testData/inspectionsLocal/redundantWith/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.RedundantWithInspection

idea/testData/inspectionsLocal/redundantWith/emptyExpressionInReturn.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+fun test() {
+    return <caret>with (1) {
+    }
+}

idea/testData/inspectionsLocal/redundantWith/emptyExpressionInReturn.kt.after

@@ -0,0 +1,4 @@
+// WITH_RUNTIME
+fun test() {
+    return
+}

idea/testData/inspectionsLocal/redundantWith/nested.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+fun test() {
+    <caret>with ("") {
+        with ("a") {
+            this
+        }
+    }
+}

idea/testData/inspectionsLocal/redundantWith/nested.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+fun test() {
+    <caret>with ("a") {
+        this
+    }
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_explicitThis.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test() {
+    <caret>with ("") {
+        this
+    }
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_explicitThis2.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test() {
+    <caret>with ("") {
+        this.length
+    }
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_functionCall.kt

@@ -0,0 +1,12 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test() {
+    val c = MyClass()
+    <caret>with(c) {
+        println(f())
+    }
+}
+
+class MyClass {
+    fun f(): String = ""
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_implicitThis.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test() {
+    <caret>with ("") {
+        length
+    }
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_inBinaryExpression.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test() {
+    val b = 1 == <caret>with ("") {
+        println()
+        1
+    }
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_inFunctionBody.kt

@@ -0,0 +1,6 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test() = <caret>with("") {
+    println()
+    1
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_inProperty.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test() {
+    val i = <caret>with ("") {
+        println()
+        1
+    }
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_inPropertyGetter.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+val a: Int
+    get() = <caret>with("") {
+        println()
+        1
+    }

idea/testData/inspectionsLocal/redundantWith/notApplicable_inReturn.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test(): Int {
+    return <caret>with ("") {
+        println()
+        1
+    }
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_inValueArgument.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun foo(i: Int) {}
+
+fun test() {
+    foo(<caret>with("") {
+        println()
+        1
+    })
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_labeledReturn.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test() {
+    <caret>with ("") {
+        return@with
+    }
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_labeledReturn2.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test(): String {
+    <caret>with("") {
+        return this@with
+    }
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_labeledThis.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test() {
+    <caret>with ("") {
+        this@with
+    }
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_labeledThis2.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test() {
+    <caret>with ("") {
+        this@with.length
+    }
+}

idea/testData/inspectionsLocal/redundantWith/notApplicable_variableFunctionCall.kt

@@ -0,0 +1,12 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test() {
+    val c = MyClass()
+    <caret>with(c) {
+        println(f())
+    }
+}
+
+class MyClass {
+    val f: () -> String = { "" }
+}

idea/testData/inspectionsLocal/redundantWith/simple.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+fun test() {
+    <caret>with ("") {
+        println("1")
+        println("2")
+    }
+}

idea/testData/inspectionsLocal/redundantWith/simple.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+fun test() {
+    <caret>println("1")
+    println("2")
+}

idea/testData/inspectionsLocal/redundantWith/simple2.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+fun test(s: String) {
+    with<caret> (s, {
+        println("1")
+        println("2")
+    })
+}

idea/testData/inspectionsLocal/redundantWith/simple2.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+fun test(s: String) {
+    <caret>println("1")
+    println("2")
+}

idea/testData/inspectionsLocal/redundantWith/singleExpressionInReturn.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+fun test(): Int {
+    return <caret>with (1) {
+        2
+    }
+}

idea/testData/inspectionsLocal/redundantWith/singleExpressionInReturn.kt.after

@@ -0,0 +1,4 @@
+// WITH_RUNTIME
+fun test(): Int {
+    return 2
+}