From 4c241b12340ebf22e8b47fa29930dbe00aec6507 Mon Sep 17 00:00:00 2001
From: Svetlana Isakova <svetlana.isakova@jetbrains.com>
Date: Mon, 24 Dec 2012 14:19:39 +0400
Subject: [PATCH] refactoring: extracted method renderTypeWithoutEscape

---
 .../jet/renderer/DescriptorRendererImpl.java  | 49 ++++++++++---------
 1 file changed, 26 insertions(+), 23 deletions(-)

diff --git a/compiler/frontend/src/org/jetbrains/jet/renderer/DescriptorRendererImpl.java b/compiler/frontend/src/org/jetbrains/jet/renderer/DescriptorRendererImpl.java
index f93ed7b8027..d829dab0178 100644
--- a/compiler/frontend/src/org/jetbrains/jet/renderer/DescriptorRendererImpl.java
+++ b/compiler/frontend/src/org/jetbrains/jet/renderer/DescriptorRendererImpl.java
@@ -20,6 +20,7 @@ import com.google.common.collect.Lists;
 import com.google.common.collect.Sets;
 import com.intellij.psi.tree.IElementType;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 import org.jetbrains.jet.lang.descriptors.*;
 import org.jetbrains.jet.lang.resolve.DescriptorUtils;
 import org.jetbrains.jet.lang.resolve.calls.CallResolverUtil;
@@ -145,31 +146,33 @@ public class DescriptorRendererImpl implements DescriptorRenderer {
 
     /* TYPES RENDERING */
     @Override
-    public String renderType(JetType type) {
-        if (type == null) {
-            return escape("[NULL]");
-        }
-        else if (type == CallResolverUtil.DONT_CARE || type == CallResolverUtil.CANT_INFER) {
-            return escape("???");
-        }
-        else if (type == CallResolverUtil.PLACEHOLDER_FUNCTION_TYPE) {
-            return escape("??? -> ???");
-        }
-        else if (ErrorUtils.isErrorType(type)) {
-            return escape(type.toString());
-        }
-        else if (KotlinBuiltIns.getInstance().isUnit(type)) {
-            return escape(KotlinBuiltIns.UNIT_ALIAS + (type.isNullable() ? "?" : ""));
-        }
-        else if (KotlinBuiltIns.getInstance().isFunctionType(type)) {
-            return escape(renderFunctionType(type));
-        }
-        else {
-            return escape(renderDefaultType(type));
-        }
+    public String renderType(@Nullable JetType type) {
+        return escape(renderTypeWithoutEscape(type));
     }
 
-    private String renderDefaultType(JetType type) {
+    private String renderTypeWithoutEscape(@Nullable JetType type) {
+        if (type == null) {
+            return "[NULL]";
+        }
+        else if (type == CallResolverUtil.DONT_CARE || type == CallResolverUtil.CANT_INFER) {
+            return "???";
+        }
+        else if (type == CallResolverUtil.PLACEHOLDER_FUNCTION_TYPE) {
+            return "??? -> ???";
+        }
+        else if (ErrorUtils.isErrorType(type)) {
+            return type.toString();
+        }
+        else if (KotlinBuiltIns.getInstance().isUnit(type)) {
+            return KotlinBuiltIns.UNIT_ALIAS + (type.isNullable() ? "?" : "");
+        }
+        else if (KotlinBuiltIns.getInstance().isFunctionType(type)) {
+            return renderFunctionType(type);
+        }
+        return renderDefaultType(type);
+    }
+
+    private String renderDefaultType(@NotNull JetType type) {
         StringBuilder sb = new StringBuilder();
 
         sb.append(renderTypeName(type.getConstructor()));