Scripts: display errors from external resolver in panel if text range is empty

idea/idea-analysis/src/org/jetbrains/kotlin/idea/highlighter/ScriptExternalHighlightingPass.kt

@@ -32,6 +32,7 @@ import com.intellij.openapi.progress.ProgressIndicator
 import com.intellij.openapi.project.DumbAware
 import com.intellij.openapi.project.Project
 import com.intellij.psi.PsiFile
+import org.jetbrains.kotlin.idea.actions.internal.KotlinInternalMode
 import org.jetbrains.kotlin.idea.core.script.IdeScriptReportSink
 import org.jetbrains.kotlin.psi.KtFile
 import kotlin.script.experimental.dependencies.ScriptReport
@@ -48,27 +49,26 @@ class ScriptExternalHighlightingPass(
         val reports = file.virtualFile.getUserData(IdeScriptReportSink.Reports) ?: return
 
         val annotations = reports.mapNotNull { (message, severity, position) ->
-            val (startOffset, endOffset) = computeOffsets(document, position) ?: return@mapNotNull null
-            Annotation(
+            val (startOffset, endOffset) = position?.let { computeOffsets(document, position) } ?: 0 to 0
+            val annotation = Annotation(
                 startOffset,
                 endOffset,
                 severity.convertSeverity() ?: return@mapNotNull null,
                 message,
                 message
             )
+
+            // if range is empty, show notification panel in editor
+            annotation.isFileLevelAnnotation = startOffset == endOffset
+
+            annotation
         }
 
         val infos = annotations.map { HighlightInfo.fromAnnotation(it) }
         UpdateHighlightersUtil.setHighlightersToEditor(myProject, myDocument!!, 0, file.textLength, infos, colorsScheme, id)
     }
 
-    private fun computeOffsets(document: Document, position: ScriptReport.Position?): Pair<Int, Int>? {
-        if (position == null) {
-            // TODO: better presentation of those errors
-            // if no position was specified, mark first two lines as an error
-            return computeOffsets(document, ScriptReport.Position(0, 0, 1))
-        }
-
+    private fun computeOffsets(document: Document, position: ScriptReport.Position): Pair<Int, Int> {
         val startLine = position.startLine.coerceLineIn(document)
         val startOffset = document.offsetBy(startLine, position.startColumn)
 
@@ -78,7 +78,6 @@ class ScriptExternalHighlightingPass(
             position.endColumn ?: document.getLineEndOffset(endLine)
         ).coerceAtLeast(startOffset)
 
-        // TODO: presentation when range is empty?
         return startOffset to endOffset
     }
 
@@ -93,7 +92,7 @@ class ScriptExternalHighlightingPass(
             ScriptReport.Severity.ERROR -> ERROR
             ScriptReport.Severity.WARNING -> WARNING
             ScriptReport.Severity.INFO -> INFORMATION
-            else -> null
+            ScriptReport.Severity.DEBUG -> if (KotlinInternalMode.enabled) INFORMATION else null
         }
     }