From 49c659b3792fec6a63ac093b2b39e3f7036951cd Mon Sep 17 00:00:00 2001 From: Alexander Udalov Date: Sun, 17 Sep 2023 00:21:14 +0200 Subject: [PATCH] CLI: remove obsolete -Xdump-declarations-to It was only used in the very old version of binary compatibility validator. It was never supported in the JVM IR backend. --- .space/CODEOWNERS | 1 - .../kotlin/codegen/state/GenerationState.kt | 4 - .../K2JVMCompilerArgumentsCopyGenerated.kt | 1 - .../arguments/K2JVMCompilerArguments.kt | 11 - .../jetbrains/kotlin/cli/jvm/jvmArguments.kt | 2 - .../kotlin/config/JVMConfigurationKeys.java | 3 - compiler/testData/cli/jvm/extraHelp.out | 1 - .../codegen/dumpDeclarations/annotation.json | 18 - .../codegen/dumpDeclarations/annotation.kt | 12 - .../dumpDeclarations/classMembers.json | 156 -------- .../dumpDeclarations/classMembers.jvm_abi.txt | 21 -- .../codegen/dumpDeclarations/classMembers.kt | 94 ----- .../codegen/dumpDeclarations/classes.json | 351 ------------------ .../codegen/dumpDeclarations/classes.kt | 58 --- .../codegen/dumpDeclarations/interfaces.json | 209 ----------- .../codegen/dumpDeclarations/interfaces.kt | 32 -- .../intermediateAbstractSuspendFunction.json | 44 --- .../intermediateAbstractSuspendFunction.kt | 10 - .../dumpDeclarations/localClasses.json | 89 ----- .../codegen/dumpDeclarations/localClasses.kt | 39 -- .../multifileFacadeMembers.json | 60 --- .../multifileFacadeMembers.kt | 43 --- .../dumpDeclarations/suspendLambda.json | 23 -- .../codegen/dumpDeclarations/suspendLambda.kt | 10 - .../dumpDeclarations/suspendOverride.json | 44 --- .../dumpDeclarations/suspendOverride.kt | 14 - .../dumpDeclarations/topLevelMembers.json | 48 --- .../dumpDeclarations/topLevelMembers.kt | 40 -- .../JvmAbiConsistencyTestRestGenerated.java | 70 ---- .../codegen/AbstractDumpDeclarationsTest.kt | 29 -- .../generators/GenerateJUnit3CompilerTests.kt | 4 - .../generators/GenerateJUnit5CompilerTests.kt | 1 - .../DumpDeclarationsTestGenerated.java | 81 ---- .../kotlin/config/facetSerialization.kt | 1 - .../CompilerArgumentsContentProspectorTest.kt | 1 - 35 files changed, 1625 deletions(-) delete mode 100644 compiler/testData/codegen/dumpDeclarations/annotation.json delete mode 100644 compiler/testData/codegen/dumpDeclarations/annotation.kt delete mode 100644 compiler/testData/codegen/dumpDeclarations/classMembers.json delete mode 100644 compiler/testData/codegen/dumpDeclarations/classMembers.jvm_abi.txt delete mode 100644 compiler/testData/codegen/dumpDeclarations/classMembers.kt delete mode 100644 compiler/testData/codegen/dumpDeclarations/classes.json delete mode 100644 compiler/testData/codegen/dumpDeclarations/classes.kt delete mode 100644 compiler/testData/codegen/dumpDeclarations/interfaces.json delete mode 100644 compiler/testData/codegen/dumpDeclarations/interfaces.kt delete mode 100644 compiler/testData/codegen/dumpDeclarations/intermediateAbstractSuspendFunction.json delete mode 100644 compiler/testData/codegen/dumpDeclarations/intermediateAbstractSuspendFunction.kt delete mode 100644 compiler/testData/codegen/dumpDeclarations/localClasses.json delete mode 100644 compiler/testData/codegen/dumpDeclarations/localClasses.kt delete mode 100644 compiler/testData/codegen/dumpDeclarations/multifileFacadeMembers.json delete mode 100644 compiler/testData/codegen/dumpDeclarations/multifileFacadeMembers.kt delete mode 100644 compiler/testData/codegen/dumpDeclarations/suspendLambda.json delete mode 100644 compiler/testData/codegen/dumpDeclarations/suspendLambda.kt delete mode 100644 compiler/testData/codegen/dumpDeclarations/suspendOverride.json delete mode 100644 compiler/testData/codegen/dumpDeclarations/suspendOverride.kt delete mode 100644 compiler/testData/codegen/dumpDeclarations/topLevelMembers.json delete mode 100644 compiler/testData/codegen/dumpDeclarations/topLevelMembers.kt delete mode 100644 compiler/tests-common/tests/org/jetbrains/kotlin/codegen/AbstractDumpDeclarationsTest.kt delete mode 100644 compiler/tests-gen/org/jetbrains/kotlin/codegen/DumpDeclarationsTestGenerated.java diff --git a/.space/CODEOWNERS b/.space/CODEOWNERS index 84717a173e8..c3831d91e8c 100644 --- a/.space/CODEOWNERS +++ b/.space/CODEOWNERS @@ -129,7 +129,6 @@ /compiler/testData/codegen/composeLikeBytecodeText/ "Kotlin JVM" /compiler/testData/codegen/customScript/ "Kotlin Compiler Core" /compiler/testData/codegen/defaultArguments/reflection/ "Kotlin JVM" -/compiler/testData/codegen/dumpDeclarations/ "Kotlin JVM" /compiler/testData/codegen/helpers/ "Kotlin JVM" /compiler/testData/codegen/innerClassInfo/ "Kotlin JVM" /compiler/testData/codegen/java6/ "Kotlin JVM" diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/state/GenerationState.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/state/GenerationState.kt index 0a371f24766..5209e090ecc 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/state/GenerationState.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/state/GenerationState.kt @@ -326,10 +326,6 @@ class GenerationState private constructor( ).apply { duplicateSignatureFactory = this } }, { BuilderFactoryForDuplicateClassNameDiagnostics(it, this) }, - { - configuration.get(JVMConfigurationKeys.DECLARATIONS_JSON_PATH) - ?.let { destination -> SignatureDumpingBuilderFactory(it, File(destination)) } ?: it - } ) .wrapWith(loadClassBuilderInterceptors()) { classBuilderFactory, extension -> extension.interceptClassBuilderFactory(classBuilderFactory, originalFrontendBindingContext, diagnostics) diff --git a/compiler/cli/cli-common/gen/org/jetbrains/kotlin/cli/common/arguments/K2JVMCompilerArgumentsCopyGenerated.kt b/compiler/cli/cli-common/gen/org/jetbrains/kotlin/cli/common/arguments/K2JVMCompilerArgumentsCopyGenerated.kt index f125da99d21..78005d287ed 100644 --- a/compiler/cli/cli-common/gen/org/jetbrains/kotlin/cli/common/arguments/K2JVMCompilerArgumentsCopyGenerated.kt +++ b/compiler/cli/cli-common/gen/org/jetbrains/kotlin/cli/common/arguments/K2JVMCompilerArgumentsCopyGenerated.kt @@ -19,7 +19,6 @@ fun copyK2JVMCompilerArguments(from: K2JVMCompilerArguments, to: K2JVMCompilerAr to.buildFile = from.buildFile to.classpath = from.classpath to.compileJava = from.compileJava - to.declarationsOutputPath = from.declarationsOutputPath to.defaultScriptExtension = from.defaultScriptExtension to.destination = from.destination to.disableStandardScript = from.disableStandardScript diff --git a/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/arguments/K2JVMCompilerArguments.kt b/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/arguments/K2JVMCompilerArguments.kt index 4c695caa2ed..e48186be0b3 100644 --- a/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/arguments/K2JVMCompilerArguments.kt +++ b/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/arguments/K2JVMCompilerArguments.kt @@ -313,17 +313,6 @@ This can be used in the event of problems with the new implementation.""" field = value } - @Argument( - value = "-Xdump-declarations-to", - valueDescription = "", - description = "Path to the JSON file where Java-to-Kotlin declaration mappings should be dumped." - ) - var declarationsOutputPath: String? = null - set(value) { - checkFrozen() - field = if (value.isNullOrEmpty()) null else value - } - @Argument( value = "-Xsuppress-missing-builtins-error", description = """Suppress the "cannot access built-in declaration" error (useful with '-no-stdlib').""" diff --git a/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/jvmArguments.kt b/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/jvmArguments.kt index 0f2d5957eef..d4f5e5853be 100644 --- a/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/jvmArguments.kt +++ b/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/jvmArguments.kt @@ -322,8 +322,6 @@ fun CompilerConfiguration.configureAdvancedJvmOptions(arguments: K2JVMCompilerAr messageCollector.report(INFO, "Using preview Java language features") } - arguments.declarationsOutputPath?.let { put(JVMConfigurationKeys.DECLARATIONS_JSON_PATH, it) } - val nThreadsRaw = parseBackendThreads(arguments.backendThreads, messageCollector) val nThreads = if (nThreadsRaw == 0) Runtime.getRuntime().availableProcessors() else nThreadsRaw if (nThreads > 1) { diff --git a/compiler/config.jvm/src/org/jetbrains/kotlin/config/JVMConfigurationKeys.java b/compiler/config.jvm/src/org/jetbrains/kotlin/config/JVMConfigurationKeys.java index 55296bed061..d8749e11d02 100644 --- a/compiler/config.jvm/src/org/jetbrains/kotlin/config/JVMConfigurationKeys.java +++ b/compiler/config.jvm/src/org/jetbrains/kotlin/config/JVMConfigurationKeys.java @@ -70,9 +70,6 @@ public class JVMConfigurationKeys { public static final CompilerConfigurationKey MODULE_XML_FILE = CompilerConfigurationKey.create("path to module.xml"); - public static final CompilerConfigurationKey DECLARATIONS_JSON_PATH = - CompilerConfigurationKey.create("path to declarations output"); - public static final CompilerConfigurationKey> MODULES = CompilerConfigurationKey.create("module data"); diff --git a/compiler/testData/cli/jvm/extraHelp.out b/compiler/testData/cli/jvm/extraHelp.out index 837f719c621..9cf9b4e826b 100644 --- a/compiler/testData/cli/jvm/extraHelp.out +++ b/compiler/testData/cli/jvm/extraHelp.out @@ -20,7 +20,6 @@ where advanced options include: The default value is 1. -Xbuild-file= Path to the .xml build file to compile. -Xcompile-java Reuse 'javac' analysis and compile Java source files. - -Xdump-declarations-to= Path to the JSON file where Java-to-Kotlin declaration mappings should be dumped. -Xdefault-script-extension=