Mark as UNSUPPORTED suspension points in default parameters

#KT-16124 Fixed
 #KT-16218 Open

compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/checkers/coroutineCallChecker.kt

@@ -30,6 +30,7 @@ import org.jetbrains.kotlin.resolve.BindingContext
 import org.jetbrains.kotlin.resolve.calls.model.ResolvedCall
 import org.jetbrains.kotlin.resolve.descriptorUtil.hasRestrictsSuspensionAnnotation
 import org.jetbrains.kotlin.resolve.inline.InlineUtil
+import org.jetbrains.kotlin.resolve.scopes.HierarchicalScope
 import org.jetbrains.kotlin.resolve.scopes.LexicalScope
 import org.jetbrains.kotlin.resolve.scopes.LexicalScopeKind
 import org.jetbrains.kotlin.resolve.scopes.receivers.ExpressionReceiver
@@ -60,6 +61,9 @@ object CoroutineSuspendCallChecker : CallChecker {
                 if (!InlineUtil.checkNonLocalReturnUsage(enclosingSuspendFunction, callElement, context.resolutionContext)) {
                     context.trace.report(Errors.NON_LOCAL_SUSPENSION_POINT.on(reportOn))
                 }
+                else if (context.scope.parentsWithSelf.any { it.isScopeForDefaultParameterValuesOf(enclosingSuspendFunction) }) {
+                    context.trace.report(Errors.UNSUPPORTED.on(reportOn, "suspend function calls in a context of default parameter value"))
+                }
 
                 context.trace.record(BindingContext.ENCLOSING_SUSPEND_FUNCTION_FOR_SUSPEND_FUNCTION_CALL, resolvedCall.call, enclosingSuspendFunction)
 
@@ -72,6 +76,9 @@ object CoroutineSuspendCallChecker : CallChecker {
     }
 }
 
+private fun HierarchicalScope.isScopeForDefaultParameterValuesOf(enclosingSuspendFunction: FunctionDescriptor) =
+        this is LexicalScope && this.kind == LexicalScopeKind.DEFAULT_VALUE && this.ownerDescriptor == enclosingSuspendFunction
+
 object BuilderFunctionsCallChecker : CallChecker {
     override fun check(resolvedCall: ResolvedCall<*>, reportOn: PsiElement, context: CallCheckerContext) {
         val descriptor = resolvedCall.candidateDescriptor as? FunctionDescriptor ?: return

compiler/testData/diagnostics/testsWithStdLib/coroutines/suspesionInDefaultValue.kt

@@ -0,0 +1,17 @@
+// !DIAGNOSTICS: -UNUSED_PARAMETER
+// SKIP_TXT
+
+suspend fun foo() = 1
+
+suspend fun bar(
+        x: Int = 2 + <!UNSUPPORTED!>foo<!>(),
+        y: suspend () -> Int = { foo() },
+        z: () -> Int = { <!NON_LOCAL_SUSPENSION_POINT!>foo<!>() },
+        w: Int = myInline { <!UNSUPPORTED!>foo<!>() },
+        v: Any? = object {
+            fun x() = <!NON_LOCAL_SUSPENSION_POINT!>foo<!>()
+            suspend fun y() = foo()
+        }
+) {}
+
+inline fun myInline(x: () -> Unit) = 1

compiler/tests/org/jetbrains/kotlin/checkers/DiagnosticsTestWithStdLibGenerated.java

@@ -827,6 +827,12 @@ public class DiagnosticsTestWithStdLibGenerated extends AbstractDiagnosticsTestW
             doTest(fileName);
         }
 
+        @TestMetadata("suspesionInDefaultValue.kt")
+        public void testSuspesionInDefaultValue() throws Exception {
+            String fileName = KotlinTestUtils.navigationMetadata("compiler/testData/diagnostics/testsWithStdLib/coroutines/suspesionInDefaultValue.kt");
+            doTest(fileName);
+        }
+
         @TestMetadata("tryCatchLambda.kt")
         public void testTryCatchLambda() throws Exception {
             String fileName = KotlinTestUtils.navigationMetadata("compiler/testData/diagnostics/testsWithStdLib/coroutines/tryCatchLambda.kt");