Destructure intention now handles the case with manual destructuring inside #KT-13943 Fixed

idea/testData/intentions/iterationOverMap/DataClassWithDestructuring.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+
+data class XY(val x: Int, val y: Int)
+
+fun foo(list: List<XY>) {
+    for (element<caret> in list) {
+        val (x, y) = element
+    }
+}

idea/testData/intentions/iterationOverMap/DataClassWithDestructuring.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+data class XY(val x: Int, val y: Int)
+
+fun foo(list: List<XY>) {
+    for ((x, y) in list) {
+    }
+}

idea/testData/intentions/iterationOverMap/DataClassWithDestructuringConflict.kt

@@ -0,0 +1,11 @@
+// IS_APPLICABLE: false
+// WITH_RUNTIME
+
+data class XY(val x: Int, val y: Int)
+
+fun foo(list: List<XY>) {
+    for (element<caret> in list) {
+        val z = element.y
+        val (x, y) = element
+    }
+}

idea/testData/intentions/iterationOverMap/DataClassWithDestructuringFakeConflict.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+
+data class XY(val x: Int, val y: Int)
+
+fun foo(list: List<XY>) {
+    for (element<caret> in list) {
+        val z = element.y
+        val (x) = element
+    }
+}

idea/testData/intentions/iterationOverMap/DataClassWithDestructuringFakeConflict.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+data class XY(val x: Int, val y: Int)
+
+fun foo(list: List<XY>) {
+    for ((x, z) in list) {
+    }
+}

idea/testData/intentions/iterationOverMap/DataClassWithDestructuringPartial.kt

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+
+data class XY(val x: Int, val y: Int)
+
+fun foo(list: List<XY>): Int {
+    var result = 0
+    for (element<caret> in list) {
+        val (x) = element
+        result += x
+        result += element.y
+    }
+    return result
+}

idea/testData/intentions/iterationOverMap/DataClassWithDestructuringPartial.kt.after

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+
+data class XY(val x: Int, val y: Int)
+
+fun foo(list: List<XY>): Int {
+    var result = 0
+    for ((x, y) in list) {
+        result += x
+        result += y
+    }
+    return result
+}

idea/testData/intentions/iterationOverMap/KeyOnlyWithDestructuring.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun foo(map: Map<Int, Int>) {
+    for (entry<caret> in map.entries) {
+        val (key) = entry
+    }
+}

idea/testData/intentions/iterationOverMap/KeyOnlyWithDestructuring.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+fun foo(map: Map<Int, Int>) {
+    for ((key) in map) {
+    }
+}

idea/testData/intentions/iterationOverMap/KeyValueWithDestructuring.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun foo(map: Map<Int, Int>) {
+    for (entry<caret> in map.entries) {
+        val (key, value) = entry
+    }
+}

idea/testData/intentions/iterationOverMap/KeyValueWithDestructuring.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+fun foo(map: Map<Int, Int>) {
+    for ((key, value) in map) {
+    }
+}

idea/testData/intentions/iterationOverMap/inspectionData/expected.xml

@@ -191,4 +191,44 @@
         <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Use destructuring declaration</problem_class>
         <description>Use destructuring declaration</description>
     </problem>
+    <problem>
+        <file>DataClassWithDestructuring.kt</file>
+        <line>6</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="temp:///src/DataClassWithDestructuring.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Use destructuring declaration</problem_class>
+        <description>Use destructuring declaration</description>
+    </problem>
+    <problem>
+        <file>DataClassWithDestructuringFakeConflict.kt</file>
+        <line>6</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="temp:///src/DataClassWithDestructuringFakeConflict.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Use destructuring declaration</problem_class>
+        <description>Use destructuring declaration</description>
+    </problem>
+    <problem>
+        <file>DataClassWithDestructuringPartial.kt</file>
+        <line>7</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="temp:///src/DataClassWithDestructuringPartial.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Use destructuring declaration</problem_class>
+        <description>Use destructuring declaration</description>
+    </problem>
+    <problem>
+        <file>KeyOnlyWithDestructuring.kt</file>
+        <line>4</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="temp:///src/KeyOnlyWithDestructuring.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Use destructuring declaration</problem_class>
+        <description>Use destructuring declaration</description>
+    </problem>
+    <problem>
+        <file>KeyValueWithDestructuring.kt</file>
+        <line>4</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="temp:///src/KeyValueWithDestructuring.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Use destructuring declaration</problem_class>
+        <description>Use destructuring declaration</description>
+    </problem>
 </problems>