azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Inspection & fix for redundant supertype qualification

Browse Source
This commit is contained in:
Valentin Kipyatkov
2015-08-26 15:05:10 +03:00
parent d62eeb1c25
commit 4717b17418
30 changed files with 531 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/testData/intentions/removeExplicitSuperQualifier/.intention
Vendored
+1
View File
@@ -0,0 +1 @@
org.jetbrains.kotlin.idea.intentions.RemoveExplicitSuperQualifierIntention
idea/testData/intentions/removeExplicitSuperQualifier/AmbiguousSuperMethod.kt
Vendored
+15
View File
@@ -0,0 +1,15 @@
// IS_APPLICABLE: false
open class B {
open fun foo(p: String){}
}
interface I {
fun foo(p: String) {}
}
class A : B(), I {
override fun foo(p: String) {
super<B><caret>.foo("")
}
}
idea/testData/intentions/removeExplicitSuperQualifier/AmbiguousSuperProperty.kt
Vendored
+15
View File
@@ -0,0 +1,15 @@
// IS_APPLICABLE: false
open class B {
open val v: Int = 0
}
interface I {
val v: Int
get() = 0
}
class A : B(), I {
override val v: Int
get() = super<B><caret>.v
}
idea/testData/intentions/removeExplicitSuperQualifier/DataFlowInfoUsed.kt
Vendored
+17
View File
@@ -0,0 +1,17 @@
open class B {
open fun foo(p: String){}
fun foo(p: Int){}
}
interface I {
fun foo(p: String)
}
class A : B(), I {
fun foo(p: Any) {
if (p is Int) {
super<B><caret>.foo(p)
}
}
}
idea/testData/intentions/removeExplicitSuperQualifier/DataFlowInfoUsed.kt.after
Vendored
+17
View File
@@ -0,0 +1,17 @@
open class B {
open fun foo(p: String){}
fun foo(p: Int){}
}
interface I {
fun foo(p: String)
}
class A : B(), I {
fun foo(p: Any) {
if (p is Int) {
super<caret>.foo(p)
}
}
}
idea/testData/intentions/removeExplicitSuperQualifier/IncompleteCall.kt
Vendored
+15
View File
@@ -0,0 +1,15 @@
// ERROR: No value passed for parameter p
open class B {
open fun foo(p: String){}
}
interface I {
fun foo(p: String)
}
class A : B(), I {
override fun foo(p: String) {
super<B><caret>.foo()
}
}
idea/testData/intentions/removeExplicitSuperQualifier/IncompleteCall.kt.after
Vendored
+15
View File
@@ -0,0 +1,15 @@
// ERROR: No value passed for parameter p
open class B {
open fun foo(p: String){}
}
interface I {
fun foo(p: String)
}
class A : B(), I {
override fun foo(p: String) {
super<caret>.foo()
}
}
idea/testData/intentions/removeExplicitSuperQualifier/IncompleteCallAmbiguous.kt
Vendored
+17
View File
@@ -0,0 +1,17 @@
// IS_APPLICABLE: false
// ERROR: <html>None of the following functions can be called with the arguments supplied. <ul><li>foo(<font color=red><b>Int</b></font>) <i>defined in</i> B</li><li>foo(<font color=red><b>String</b></font>) <i>defined in</i> B</li></ul></html>
open class B {
open fun foo(p: String){}
fun foo(p: Int){}
}
interface I {
fun foo(p: String)
}
class A : B(), I {
override fun foo(p: String) {
super<B><caret>.foo()
}
}
idea/testData/intentions/removeExplicitSuperQualifier/SingleSuper.kt
Vendored
+8
View File
@@ -0,0 +1,8 @@
open class B {
open fun foo(){}
}
class A : B() {
override fun foo() {
super<B><caret>.foo()
}
}
idea/testData/intentions/removeExplicitSuperQualifier/SingleSuper.kt.after
Vendored
+8
View File
@@ -0,0 +1,8 @@
open class B {
open fun foo(){}
}
class A : B() {
override fun foo() {
super<caret>.foo()
}
}
idea/testData/intentions/removeExplicitSuperQualifier/SuperWithLabel.kt
Vendored
+16
View File
@@ -0,0 +1,16 @@
open class Base {
open fun foo() {
}
}
class A : Base() {
override fun foo() {
super.foo()
}
inner class C {
fun test() {
super<Base><caret>@A.foo()
}
}
}
idea/testData/intentions/removeExplicitSuperQualifier/SuperWithLabel.kt.after
Vendored
+16
View File
@@ -0,0 +1,16 @@
open class Base {
open fun foo() {
}
}
class A : Base() {
override fun foo() {
super.foo()
}
inner class C {
fun test() {
super@A.foo()
}
}
}
idea/testData/intentions/removeExplicitSuperQualifier/UnambiguousSuperMethod.kt
Vendored
+15
View File
@@ -0,0 +1,15 @@
open class B {
open fun foo(p: String){}
fun foo(p: Int){}
}
interface I {
fun foo(p: String)
}
class A : B(), I {
override fun foo(p: String) {
super<B><caret>.foo("")
}
}
idea/testData/intentions/removeExplicitSuperQualifier/UnambiguousSuperMethod.kt.after
Vendored
+15
View File
@@ -0,0 +1,15 @@
open class B {
open fun foo(p: String){}
fun foo(p: Int){}
}
interface I {
fun foo(p: String)
}
class A : B(), I {
override fun foo(p: String) {
super<caret>.foo("")
}
}
idea/testData/intentions/removeExplicitSuperQualifier/UnambiguousSuperProperty.kt
Vendored
+12
View File
@@ -0,0 +1,12 @@
open class B {
open val v: Int = 0
}
interface I {
val v: Int
}
class A : B(), I {
override val v: Int
get() = super<caret><B>.v
}
idea/testData/intentions/removeExplicitSuperQualifier/UnambiguousSuperProperty.kt.after
Vendored
+12
View File
@@ -0,0 +1,12 @@
open class B {
open val v: Int = 0
}
interface I {
val v: Int
}
class A : B(), I {
override val v: Int
get() = super<caret>.v
}
idea/testData/intentions/removeExplicitSuperQualifier/WrongOffset1.kt
Vendored
+18
View File
@@ -0,0 +1,18 @@
// IS_APPLICABLE: false
open class Base {
open fun foo() {
}
}
class A : Base() {
override fun foo() {
super.foo()
}
inner class C {
fun test() {
super<Base>@<caret>A.foo()
}
}
}
idea/testData/intentions/removeExplicitSuperQualifier/WrongOffset2.kt
Vendored
+18
View File
@@ -0,0 +1,18 @@
// IS_APPLICABLE: false
open class Base {
open fun foo() {
}
}
class A : Base() {
override fun foo() {
super.foo()
}
inner class C {
fun test() {
supe<caret>r<Base>@A.foo()
}
}
}
idea/testData/intentions/removeExplicitSuperQualifier/inspectionData/expected.xml
Vendored
+73
View File
@@ -0,0 +1,73 @@
<problems>
<problem>
<file>UnambiguousSuperProperty.kt</file>
<line>11</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="UnambiguousSuperProperty.kt" />
<problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Supertype qualification is unnecessary</problem_class>
<description>Remove explicit supertype qualification</description>
</problem>
<problem>
<file>UnambiguousSuperMethod.kt</file>
<line>13</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="UnambiguousSuperMethod.kt" />
<problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Supertype qualification is unnecessary</problem_class>
<description>Remove explicit supertype qualification</description>
</problem>
<problem>
<file>SingleSuper.kt</file>
<line>6</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="SingleSuper.kt" />
<problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Supertype qualification is unnecessary</problem_class>
<description>Remove explicit supertype qualification</description>
</problem>
<problem>
<file>IncompleteCall.kt</file>
<line>13</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="IncompleteCall.kt" />
<problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Supertype qualification is unnecessary</problem_class>
<description>Remove explicit supertype qualification</description>
</problem>
<problem>
<file>DataFlowInfoUsed.kt</file>
<line>14</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="DataFlowInfoUsed.kt" />
<problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Supertype qualification is unnecessary</problem_class>
<description>Remove explicit supertype qualification</description>
</problem>
<problem>
<file>SuperWithLabel.kt</file>
<line>13</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="SuperWithLabel.kt" />
<problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Supertype qualification is unnecessary</problem_class>
<description>Remove explicit supertype qualification</description>
</problem>
<problem>
<file>WrongOffset1.kt</file>
<line>15</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="WrongOffset1.kt" />
<problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Supertype qualification is unnecessary</problem_class>
<description>Remove explicit supertype qualification</description>
</problem>
<problem>
<file>WrongOffset2.kt</file>
<line>15</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="WrongOffset2.kt" />
<problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Supertype qualification is unnecessary</problem_class>
<description>Remove explicit supertype qualification</description>
</problem>
</problems>
idea/testData/intentions/removeExplicitSuperQualifier/inspectionData/inspections.test
Vendored
+1
View File
@@ -0,0 +1 @@
// INSPECTION_CLASS: org.jetbrains.kotlin.idea.intentions.RemoveExplicitSuperQualifierInspection