From 470ad9332879adeedeb5a33616acdf4b775b7d87 Mon Sep 17 00:00:00 2001
From: Denis Zharkov <denis.zharkov@jetbrains.com>
Date: Wed, 22 Apr 2015 20:06:07 +0300
Subject: [PATCH] Do not report inspection "no reflection" in annotation
 entries

Annotation codegen shouldn't use something from reflection.jar
---
 .../inspections/ReflectionNotFoundInspection.kt   |  4 ++++
 .../inspectionData/expected.xml                   |  8 ++++++++
 .../reflectionNotFound/withinAnnotationEntry.kt   | 15 +++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 idea/testData/inspections/reflectionNotFound/withinAnnotationEntry.kt

diff --git a/idea/src/org/jetbrains/kotlin/idea/inspections/ReflectionNotFoundInspection.kt b/idea/src/org/jetbrains/kotlin/idea/inspections/ReflectionNotFoundInspection.kt
index 5b4f12681f3..f7429376b1a 100644
--- a/idea/src/org/jetbrains/kotlin/idea/inspections/ReflectionNotFoundInspection.kt
+++ b/idea/src/org/jetbrains/kotlin/idea/inspections/ReflectionNotFoundInspection.kt
@@ -45,6 +45,8 @@ import org.jetbrains.kotlin.psi.JetVisitorVoid
 import org.jetbrains.kotlin.resolve.BindingContext
 import org.jetbrains.kotlin.serialization.deserialization.findClassAcrossModuleDependencies
 import org.jetbrains.kotlin.builtins.ReflectionTypes
+import org.jetbrains.kotlin.psi.JetAnnotationEntry
+import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
 import org.jetbrains.kotlin.utils.PathUtil
 import org.jetbrains.kotlin.utils.addToStdlib.firstIsInstanceOrNull
 import org.jetbrains.kotlin.utils.singletonOrEmptyList
@@ -75,6 +77,8 @@ public class ReflectionNotFoundInspection : AbstractKotlinInspection() {
                 val expectedType = expression.analyze().get(BindingContext.EXPECTED_EXPRESSION_TYPE, expression)
                 if (expectedType != null && !ReflectionTypes.isReflectionType(expectedType)) return
 
+                if (expression.getStrictParentOfType<JetAnnotationEntry>() != null) return
+
                 // If a callable reference is used where a KFunction/KProperty/... expected, we should report that usage as dangerous
                 // because reflection features will fail without kotlin-reflect.jar in the classpath.
                 // If it's only used as a Function however (for example, "list.map(::function)"), we should not report anything
diff --git a/idea/testData/inspections/reflectionNotFound/inspectionData/expected.xml b/idea/testData/inspections/reflectionNotFound/inspectionData/expected.xml
index 51426e80ffa..fed4c656629 100644
--- a/idea/testData/inspections/reflectionNotFound/inspectionData/expected.xml
+++ b/idea/testData/inspections/reflectionNotFound/inspectionData/expected.xml
@@ -15,4 +15,12 @@
     <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Reflection not found</problem_class>
     <description>Reflection not found in the classpath</description>
   </problem>
+  <problem>
+    <file>withinAnnotationEntry.kt</file>
+    <line>13</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="temp:///src/withinAnnotationEntry.kt" />
+    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Reflection not found</problem_class>
+    <description>Reflection not found in the classpath</description>
+  </problem>
 </problems>
diff --git a/idea/testData/inspections/reflectionNotFound/withinAnnotationEntry.kt b/idea/testData/inspections/reflectionNotFound/withinAnnotationEntry.kt
new file mode 100644
index 00000000000..3e75d6bc3e8
--- /dev/null
+++ b/idea/testData/inspections/reflectionNotFound/withinAnnotationEntry.kt
@@ -0,0 +1,15 @@
+package test
+
+// WITH_RUNTIME
+
+import kotlin.reflect.KClass
+
+annotation class A(val arg: KClass<*>, val args: Array<KClass<*>>, vararg val other: KClass<*>)
+
+A(Int::class, array(String::class), Double::class, Char::class)
+class MyClass {
+    throws(Exception::class)
+    fun foo() {
+        Exception::class
+    }
+}