diff --git a/compiler/frontend/src/org/jetbrains/jet/lang/cfg/JetFlowInformationProvider.java b/compiler/frontend/src/org/jetbrains/jet/lang/cfg/JetFlowInformationProvider.java index cc6166b160f..3d2e70ecbbe 100644 --- a/compiler/frontend/src/org/jetbrains/jet/lang/cfg/JetFlowInformationProvider.java +++ b/compiler/frontend/src/org/jetbrains/jet/lang/cfg/JetFlowInformationProvider.java @@ -52,7 +52,7 @@ public class JetFlowInformationProvider { private final JetDeclaration subroutine; private final Pseudocode pseudocode; - private final PseudocodeVariablesData pseudocodeData; + private final PseudocodeVariablesData pseudocodeVariablesData; private BindingTrace trace; public JetFlowInformationProvider( @@ -62,7 +62,7 @@ public class JetFlowInformationProvider { subroutine = declaration; this.trace = trace; pseudocode = new JetControlFlowProcessor(trace).generatePseudocode(declaration); - pseudocodeData = new PseudocodeVariablesData(pseudocode, trace.getBindingContext()); + pseudocodeVariablesData = new PseudocodeVariablesData(pseudocode, trace.getBindingContext()); } private void collectReturnExpressions(@NotNull final Collection returnedExpressions) { @@ -187,16 +187,15 @@ public class JetFlowInformationProvider { final Collection varWithValReassignErrorGenerated = Sets.newHashSet(); final boolean processClassOrObject = subroutine instanceof JetClassOrObject; - Map>> initializers = pseudocodeData.getVariableInitializers(); - final Set declaredVariables = pseudocodeData.getDeclaredVariables(pseudocode); + Map>> initializers = pseudocodeVariablesData.getVariableInitializers(); + final Set declaredVariables = pseudocodeVariablesData.getDeclaredVariables(pseudocode); PseudocodeTraverser.traverse(pseudocode, true, true, initializers, new InstructionDataAnalyzeStrategy>() { @Override public void execute(@NotNull Instruction instruction, @Nullable Map in, @Nullable Map out) { assert in != null && out != null; - VariableDescriptor variableDescriptor = PseudocodeUtil.extractVariableDescriptorIfAny(instruction, true, - trace.getBindingContext()); + VariableDescriptor variableDescriptor = PseudocodeUtil.extractVariableDescriptorIfAny(instruction, true, trace.getBindingContext()); if (variableDescriptor == null) return; if (!(instruction instanceof ReadValueInstruction) && !(instruction instanceof WriteValueInstruction)) return; VariableInitializers outInitializers = out.get(variableDescriptor); @@ -224,7 +223,7 @@ public class JetFlowInformationProvider { } }); - Pseudocode pseudocode = pseudocodeData.getPseudocode(); + Pseudocode pseudocode = pseudocodeVariablesData.getPseudocode(); recordInitializedVariables(pseudocode, initializers); for (LocalDeclarationInstruction instruction : pseudocode.getLocalDeclarations()) { recordInitializedVariables(instruction.getBody(), initializers); @@ -399,8 +398,8 @@ public class JetFlowInformationProvider { private void recordInitializedVariables(@NotNull Pseudocode pseudocode, @NotNull Map>> initializersMap) { Edges> initializers = initializersMap.get(pseudocode.getExitInstruction()); - Set usedVariables = pseudocodeData.getUsedVariables(pseudocode); - Set declaredVariables = pseudocodeData.getDeclaredVariables(pseudocode); + Set usedVariables = pseudocodeVariablesData.getUsedVariables(pseudocode); + Set declaredVariables = pseudocodeVariablesData.getDeclaredVariables(pseudocode); for (VariableDescriptor variable : usedVariables) { if (variable instanceof PropertyDescriptor && declaredVariables.contains(variable)) { VariableInitializers variableInitializers = initializers.in.get(variable); @@ -414,7 +413,7 @@ public class JetFlowInformationProvider { // "Unused variable" & "unused value" analyses public void markUnusedVariables() { - Map>> variableStatusData = pseudocodeData.getVariableUseStatusData(); + Map>> variableStatusData = pseudocodeVariablesData.getVariableUseStatusData(); InstructionDataAnalyzeStrategy> variableStatusAnalyzeStrategy = new InstructionDataAnalyzeStrategy>() { @Override @@ -423,7 +422,7 @@ public class JetFlowInformationProvider { @Nullable Map out) { assert in != null && out != null; - Set declaredVariables = pseudocodeData.getDeclaredVariables(instruction.getOwner()); + Set declaredVariables = pseudocodeVariablesData.getDeclaredVariables(instruction.getOwner()); VariableDescriptor variableDescriptor = PseudocodeUtil.extractVariableDescriptorIfAny(instruction, false, trace.getBindingContext()); if (variableDescriptor == null || !declaredVariables.contains(variableDescriptor) || diff --git a/compiler/frontend/src/org/jetbrains/jet/lang/cfg/PseudocodeTraverser.java b/compiler/frontend/src/org/jetbrains/jet/lang/cfg/PseudocodeTraverser.java index b0a8e4884eb..77781e4e20b 100644 --- a/compiler/frontend/src/org/jetbrains/jet/lang/cfg/PseudocodeTraverser.java +++ b/compiler/frontend/src/org/jetbrains/jet/lang/cfg/PseudocodeTraverser.java @@ -37,7 +37,7 @@ public class PseudocodeTraverser { return directOrder ? pseudocode.getEnterInstruction() : pseudocode.getSinkInstruction(); } - public static Map> collectInformation( + public static Map> collectData( @NotNull Pseudocode pseudocode, boolean directOrder, boolean lookInside, @NotNull D initialDataValue, @NotNull D initialDataValueForEnterInstruction, @NotNull InstructionDataMergeStrategy instructionDataMergeStrategy) { @@ -50,8 +50,8 @@ public class PseudocodeTraverser { changed[0] = true; while (changed[0]) { changed[0] = false; - collectInformationFromSubgraph(pseudocode, directOrder, lookInside, edgesMap, instructionDataMergeStrategy, - Collections.emptyList(), changed, false); + collectDataFromSubgraph(pseudocode, directOrder, lookInside, edgesMap, instructionDataMergeStrategy, + Collections.emptyList(), changed, false); } return edgesMap; } @@ -70,7 +70,7 @@ public class PseudocodeTraverser { } } - private static void collectInformationFromSubgraph( + private static void collectDataFromSubgraph( @NotNull Pseudocode pseudocode, boolean directOrder, boolean lookInside, @NotNull Map> edgesMap, @NotNull InstructionDataMergeStrategy instructionDataMergeStrategy, @@ -97,9 +97,9 @@ public class PseudocodeTraverser { if (lookInside && instruction instanceof LocalDeclarationInstruction) { Pseudocode subroutinePseudocode = ((LocalDeclarationInstruction) instruction).getBody(); - collectInformationFromSubgraph(subroutinePseudocode, directOrder, lookInside, edgesMap, instructionDataMergeStrategy, - previousInstructions, - changed, true); + collectDataFromSubgraph(subroutinePseudocode, directOrder, lookInside, edgesMap, instructionDataMergeStrategy, + previousInstructions, + changed, true); Instruction lastInstruction = directOrder ? subroutinePseudocode.getSinkInstruction() : subroutinePseudocode.getEnterInstruction(); Edges previousValue = edgesMap.get(instruction); Edges newValue = edgesMap.get(lastInstruction); diff --git a/compiler/frontend/src/org/jetbrains/jet/lang/cfg/PseudocodeVariablesData.java b/compiler/frontend/src/org/jetbrains/jet/lang/cfg/PseudocodeVariablesData.java index c75e869cfe3..25704d635e7 100644 --- a/compiler/frontend/src/org/jetbrains/jet/lang/cfg/PseudocodeVariablesData.java +++ b/compiler/frontend/src/org/jetbrains/jet/lang/cfg/PseudocodeVariablesData.java @@ -118,7 +118,7 @@ public class PseudocodeVariablesData { final Map initialMapForStartInstruction = prepareInitializersMapForStartInstruction( usedVariables, declaredVariables); - Map>> variableInitializersMap = PseudocodeTraverser.collectInformation( + Map>> variableInitializersMap = PseudocodeTraverser.collectData( pseudocode, /* directOrder = */ true, /* lookInside = */ false, initialMap, initialMapForStartInstruction, new PseudocodeTraverser.InstructionDataMergeStrategy>() { @Override @@ -275,8 +275,9 @@ public class PseudocodeVariablesData { return Edges.create(enterResult, exitResult); } }; - variableStatusMap = PseudocodeTraverser.collectInformation(pseudocode, false, true, - Collections.emptyMap(), sinkInstructionData, collectVariableUseStatusStrategy); + variableStatusMap = PseudocodeTraverser.collectData(pseudocode, false, true, + Collections.emptyMap(), + sinkInstructionData, collectVariableUseStatusStrategy); } return variableStatusMap; }