KT-5692 Java to Kotlin conversion: convert int range loops in reverse order + a few more improvements

#KT-5692 Fixed

j2k/testData/fileOrElement/for/arrayIndicesReversed.java

@@ -0,0 +1,9 @@
+import java.util.Collection;
+
+public class A {
+    void foo(String[] array) {
+        for(int i = array.length - 1; i >= 0; i--) {
+            System.out.println(i);
+        }
+    }
+}

j2k/testData/fileOrElement/for/arrayIndicesReversed.kt

@@ -0,0 +1,7 @@
+public class A {
+    fun foo(array: Array<String>) {
+        for (i in array.indices.reversed()) {
+            System.out.println(i)
+        }
+    }
+}

j2k/testData/fileOrElement/for/downTo1.java

@@ -0,0 +1,7 @@
+public class A {
+    void foo() {
+        for(int i = 10; i >= 0; i--) {
+            System.out.println(i);
+        }
+    }
+}

j2k/testData/fileOrElement/for/downTo1.kt

@@ -0,0 +1,7 @@
+public class A {
+    fun foo() {
+        for (i in 10 downTo 0) {
+            System.out.println(i)
+        }
+    }
+}

j2k/testData/fileOrElement/for/downTo2.java

@@ -0,0 +1,7 @@
+public class A {
+    void foo() {
+        for(int i = 10; i > 0; i--) {
+            System.out.println(i);
+        }
+    }
+}

j2k/testData/fileOrElement/for/downTo2.kt

@@ -0,0 +1,7 @@
+public class A {
+    fun foo() {
+        for (i in 10 downTo 1) {
+            System.out.println(i)
+        }
+    }
+}

j2k/testData/fileOrElement/for/downTo3.java

@@ -0,0 +1,7 @@
+public class A {
+    void foo(int min) {
+        for(int i = 10; i > min; i--) {
+            System.out.println(i);
+        }
+    }
+}

j2k/testData/fileOrElement/for/downTo3.kt

@@ -0,0 +1,7 @@
+public class A {
+    fun foo(min: Int) {
+        for (i in 10 downTo min + 1) {
+            System.out.println(i)
+        }
+    }
+}

j2k/testData/fileOrElement/for/falseArrayIndicesReversed.java

@@ -0,0 +1,9 @@
+import java.util.Collection;
+
+public class A {
+    void foo(String[] array) {
+        for(int i = array.length; i >= 0; i--) {
+            System.out.println(i);
+        }
+    }
+}

j2k/testData/fileOrElement/for/falseArrayIndicesReversed.kt

@@ -0,0 +1,7 @@
+public class A {
+    fun foo(array: Array<String>) {
+        for (i in array.size() downTo 0) {
+            System.out.println(i)
+        }
+    }
+}

j2k/testData/fileOrElement/for/falseArrayIndicesReversed2.java

@@ -0,0 +1,9 @@
+import java.util.Collection;
+
+public class A {
+    void foo(String[] array) {
+        for(int i = array.length - 2; i >= 0; i--) {
+            System.out.println(i);
+        }
+    }
+}

j2k/testData/fileOrElement/for/falseArrayIndicesReversed2.kt

@@ -0,0 +1,7 @@
+public class A {
+    fun foo(array: Array<String>) {
+        for (i in array.size() - 2 downTo 0) {
+            System.out.println(i)
+        }
+    }
+}

j2k/testData/fileOrElement/for/falseIndicesReversed.java

@@ -0,0 +1,9 @@
+import java.util.Collection;
+
+public class A {
+    void foo(Collection<String> collection) {
+        for(int i = collection.size(); i >= 0; i--) {
+            System.out.println(i);
+        }
+    }
+}

j2k/testData/fileOrElement/for/falseIndicesReversed.kt

@@ -0,0 +1,7 @@
+public class A {
+    fun foo(collection: Collection<String>) {
+        for (i in collection.size() downTo 0) {
+            System.out.println(i)
+        }
+    }
+}

j2k/testData/fileOrElement/for/forRangeWithBlock.kt

@@ -1,4 +1,4 @@
 val array = IntArray(10)
-for (i in 0..10 - 1) {
+for (i in 0..9) {
     array[i] = i
 }

j2k/testData/fileOrElement/for/forRangeWithLT.kt

@@ -1,4 +1,4 @@
 val array = IntArray(10)
-for (i in 0..10 - 1) {
+for (i in 0..9) {
     array[i] = i
 }

j2k/testData/fileOrElement/for/forRangeWithLT2.java

@@ -0,0 +1,2 @@
+//statement
+for (int i = 0; i < N; i++) { System.out.println(i); }

j2k/testData/fileOrElement/for/forRangeWithLT2.kt

@@ -0,0 +1,3 @@
+for (i in 0..N - 1) {
+    System.out.println(i)
+}

j2k/testData/fileOrElement/for/forThroughCollectionIndices.java

@@ -0,0 +1,10 @@
+import java.lang.System;
+import java.util.Collection;
+
+class C{
+    void foo1(Collection<String> collection) {
+        for (int i = 0; i < collection.size(); i++) {
+            System.out.print(i);
+        }
+    }
+}

j2k/testData/fileOrElement/for/forThroughCollectionIndices.kt

@@ -0,0 +1,9 @@
+import java.lang.System
+
+class C {
+    fun foo1(collection: Collection<String>) {
+        for (i in collection.indices) {
+            System.out.print(i)
+        }
+    }
+}

j2k/testData/fileOrElement/for/forWithExpression.kt

@@ -1 +1 @@
-for (i in 0..0 - 1) t++
+for (i in 0..-1) t++

j2k/testData/fileOrElement/for/indicesReversed.java

@@ -0,0 +1,9 @@
+import java.util.Collection;
+
+public class A {
+    void foo(Collection<String> collection) {
+        for(int i = collection.size() - 1; i >= 0; i--) {
+            System.out.println(i);
+        }
+    }
+}

j2k/testData/fileOrElement/for/indicesReversed.kt

@@ -0,0 +1,7 @@
+public class A {
+    fun foo(collection: Collection<String>) {
+        for (i in collection.indices.reversed()) {
+            System.out.println(i)
+        }
+    }
+}

j2k/testData/fileOrElement/issues/kt-893.kt

@@ -2,7 +2,7 @@ package demo
 
 class Test {
     fun test() {
-        for (i in 0..10 - 1) {
+        for (i in 0..9) {
             System.out.println(i)
         }
     }

j2k/testData/fileOrElement/settings/specifyLocalVariableTypeByDefaultInFor.kt

@@ -1,7 +1,7 @@
 // !specifyLocalVariableTypeByDefault: true
 public fun foo(list: List<String>) {
     val array: IntArray = IntArray(10)
-    for (i: Int in 0..10 - 1) {
+    for (i: Int in 0..9) {
         array[i] = i
     }