azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] Fix false-positive INAPPLICABLE_LATEINIT_MODIFIER for property with unresolved type

Browse Source 
^KT-51624 Fixed
This commit is contained in:
Ivan Kochurkin
2022-03-17 14:19:59 +03:00
committed by teamcity
parent e2766e402c
commit 4617615fd9
7 changed files with 34 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirOldFrontendDiagnosticsTestGenerated.java
Generated
+6
View File
@@ -19406,6 +19406,12 @@ public class FirOldFrontendDiagnosticsTestGenerated extends AbstractFirDiagnosti
runTest("compiler/testData/diagnostics/tests/lateinit/modifierApplicability_lv12.kt");
}
@Test
@TestMetadata("NoInapplicableLateinitModifierForPropertyWithUnnresolvedType.kt")
public void testNoInapplicableLateinitModifierForPropertyWithUnnresolvedType() throws Exception {
runTest("compiler/testData/diagnostics/tests/lateinit/NoInapplicableLateinitModifierForPropertyWithUnnresolvedType.kt");
}
@Test
@TestMetadata("setter.kt")
public void testSetter() throws Exception {
compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirOldFrontendDiagnosticsWithLightTreeTestGenerated.java
Generated
+6
View File
@@ -19406,6 +19406,12 @@ public class FirOldFrontendDiagnosticsWithLightTreeTestGenerated extends Abstrac
runTest("compiler/testData/diagnostics/tests/lateinit/modifierApplicability_lv12.kt");
}
@Test
@TestMetadata("NoInapplicableLateinitModifierForPropertyWithUnnresolvedType.kt")
public void testNoInapplicableLateinitModifierForPropertyWithUnnresolvedType() throws Exception {
runTest("compiler/testData/diagnostics/tests/lateinit/NoInapplicableLateinitModifierForPropertyWithUnnresolvedType.kt");
}
@Test
@TestMetadata("setter.kt")
public void testSetter() throws Exception {
compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/declaration/FirInapplicableLateinitChecker.kt
+2 -5
View File
@@ -15,14 +15,11 @@ import org.jetbrains.kotlin.fir.declarations.impl.FirDefaultPropertyGetter
import org.jetbrains.kotlin.fir.declarations.impl.FirDefaultPropertySetter
import org.jetbrains.kotlin.fir.declarations.utils.hasExplicitBackingField
import org.jetbrains.kotlin.fir.declarations.utils.isLateInit
import org.jetbrains.kotlin.fir.types.ConeTypeParameterType
import org.jetbrains.kotlin.fir.types.coneType
import org.jetbrains.kotlin.fir.types.isNullable
import org.jetbrains.kotlin.fir.types.isPrimitiveOrNullablePrimitive
import org.jetbrains.kotlin.fir.types.*
object FirInapplicableLateinitChecker : FirPropertyChecker() {
override fun check(declaration: FirProperty, context: CheckerContext, reporter: DiagnosticReporter) {
if (!declaration.isLateInit) {
if (!declaration.isLateInit || declaration.returnTypeRef is FirErrorTypeRef) {
return
}