Delegated properties now cannot be used before initialization #KT-10869 Fixed

compiler/testData/cfg/declarations/properties/DelegatedProperty.instructions

@@ -54,12 +54,14 @@ val b by a
 L0:
   1 <START>
     v(val b by a)
-    r(a) -> <v0>
-    magic[VALUE_CONSUMER](val b by a|<v0>) -> <v1>
+    magic[UNRECOGNIZED_WRITE_RHS](val b by a) -> <v0>
+    w(b|<v0>)
+    r(a) -> <v1>
+    magic[VALUE_CONSUMER](val b by a|<v1>) -> <v2>
 L1:
-    <END>                                             NEXT:[<SINK>]
+    <END>                                                NEXT:[<SINK>]
 error:
-    <ERROR>                                           PREV:[]
+    <ERROR>                                              PREV:[]
 sink:
-    <SINK>                                            PREV:[<ERROR>, <END>]
+    <SINK>                                               PREV:[<ERROR>, <END>]
 =====================

compiler/testData/cfg/declarations/properties/DelegatedProperty.values

@@ -19,6 +19,7 @@ Delegate()   <v0>: Delegate   NEW: call(Delegate(), <init>) -> <v0>
 == b ==
 val b by a
 ---------------------
-    <v1>: *          NEW: magic[VALUE_CONSUMER](val b by a|<v0>) -> <v1>
-a   <v0>: Delegate   NEW: r(a) -> <v0>
+    <v0>: Int        NEW: magic[UNRECOGNIZED_WRITE_RHS](val b by a) -> <v0>
+    <v2>: *          NEW: magic[VALUE_CONSUMER](val b by a|<v1>) -> <v2>
+a   <v1>: Delegate   NEW: r(a) -> <v1>
 =====================

compiler/testData/cfg/declarations/properties/unreachableDelegation.instructions

@@ -4,14 +4,16 @@ val foo: Int by throw NullPointerException()
 L0:
   1 <START>
     v(val foo: Int by throw NullPointerException())
+    magic[UNRECOGNIZED_WRITE_RHS](val foo: Int by throw NullPointerException()) -> <v0>
+    w(foo|<v0>)
     mark(throw NullPointerException())
     mark(NullPointerException())
-    call(NullPointerException(), <init>) -> <v0>
-    throw (throw NullPointerException()|<v0>)          NEXT:[<ERROR>]
+    call(NullPointerException(), <init>) -> <v1>
+    throw (throw NullPointerException()|<v1>)                                              NEXT:[<ERROR>]
 L1:
-    <END>                                              NEXT:[<SINK>]                                             PREV:[]
+    <END>                                                                                  NEXT:[<SINK>]                                                                                 PREV:[]
 error:
-    <ERROR>                                            PREV:[throw (throw NullPointerException()|<v0>)]
+    <ERROR>                                                                                PREV:[throw (throw NullPointerException()|<v1>)]
 sink:
-    <SINK>                                             PREV:[<ERROR>, <END>]
-=====================
+    <SINK>                                                                                 PREV:[<ERROR>, <END>]
+=====================

compiler/testData/cfg/declarations/properties/unreachableDelegation.values

@@ -1,5 +1,6 @@
 == foo ==
 val foo: Int by throw NullPointerException()
 ---------------------
-NullPointerException()   <v0>: {<: Throwable}   NEW: call(NullPointerException(), <init>) -> <v0>
-=====================
+                         <v0>: Int              NEW: magic[UNRECOGNIZED_WRITE_RHS](val foo: Int by throw NullPointerException()) -> <v0>
+NullPointerException()   <v1>: {<: Throwable}   NEW: call(NullPointerException(), <init>) -> <v1>
+=====================

compiler/testData/diagnostics/tests/controlFlowAnalysis/delegatedPropertyEarlyAccess.kt

@@ -0,0 +1,32 @@
+// See also KT-10869: Accessing lazy properties from init causes IllegalArgumentException
+
+import kotlin.reflect.KProperty
+
+class CustomDelegate {
+    operator fun getValue(thisRef: Any?, prop: KProperty<*>): String = prop.name
+}
+
+class Kaboom() {
+    // Here and below we should have errors for simple AND delegated
+    init {
+        <!UNINITIALIZED_VARIABLE!>delegated<!>.hashCode()
+        <!UNINITIALIZED_VARIABLE!>simple<!>.hashCode()
+        withGetter.hashCode()
+    }
+
+    val other = <!UNINITIALIZED_VARIABLE!>delegated<!>
+
+    val another = <!UNINITIALIZED_VARIABLE!>simple<!>
+
+    val something = withGetter
+    
+    val delegated: String by CustomDelegate()
+
+    val simple = "xyz"
+
+    val withGetter: String
+        get() = "abc"
+
+    // No error should be here
+    val after = delegated
+}

compiler/testData/diagnostics/tests/controlFlowAnalysis/delegatedPropertyEarlyAccess.txt

@@ -0,0 +1,23 @@
+package
+
+public final class CustomDelegate {
+    public constructor CustomDelegate()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public final operator fun getValue(/*0*/ thisRef: kotlin.Any?, /*1*/ prop: kotlin.reflect.KProperty<*>): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class Kaboom {
+    public constructor Kaboom()
+    public final val after: kotlin.String
+    public final val another: kotlin.String = "xyz"
+    public final val delegated: kotlin.String
+    public final val other: kotlin.String
+    public final val simple: kotlin.String = "xyz"
+    public final val something: kotlin.String
+    public final val withGetter: kotlin.String
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}

compiler/testData/diagnostics/tests/delegatedProperty/recursiveType.kt

@@ -6,7 +6,7 @@ val a by <!TYPECHECKER_HAS_RUN_INTO_RECURSIVE_PROBLEM!>a<!>
 
 val b by Delegate(<!TYPECHECKER_HAS_RUN_INTO_RECURSIVE_PROBLEM!>b<!>)
 
-val c by <!DEBUG_INFO_ELEMENT_WITH_ERROR_TYPE!>d<!>
+val c by <!UNINITIALIZED_VARIABLE, DEBUG_INFO_ELEMENT_WITH_ERROR_TYPE!>d<!>
 val d by <!TYPECHECKER_HAS_RUN_INTO_RECURSIVE_PROBLEM!>c<!>
 
 class Delegate(i: Int) {