From 441f3e0209cdf2109661dbef240abce43797489c Mon Sep 17 00:00:00 2001 From: Yan Zhulanow Date: Mon, 13 Nov 2023 16:51:53 +0900 Subject: [PATCH] [Analysis API] Give a standalone module provider a better naming Some components in Analysis API have the 'Impl' suffix both in test and standalone environments. This commit fixes the logical ambiguity for a project structure provider. --- .../api/standalone/StandaloneAnalysisAPISessionBuilder.kt | 6 +++--- .../project/structure/builder/KtModuleProviderBuilder.kt | 4 ++-- ...viderImpl.kt => KtStandaloneProjectStructureProvider.kt} | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) rename analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/project/structure/impl/{KtModuleProviderImpl.kt => KtStandaloneProjectStructureProvider.kt} (98%) diff --git a/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/api/standalone/StandaloneAnalysisAPISessionBuilder.kt b/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/api/standalone/StandaloneAnalysisAPISessionBuilder.kt index 4056a67cf55..dc64e55bc44 100644 --- a/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/api/standalone/StandaloneAnalysisAPISessionBuilder.kt +++ b/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/api/standalone/StandaloneAnalysisAPISessionBuilder.kt @@ -23,7 +23,7 @@ import org.jetbrains.kotlin.analysis.low.level.api.fir.project.structure.LLFirLi import org.jetbrains.kotlin.analysis.project.structure.KtSourceModule import org.jetbrains.kotlin.analysis.project.structure.builder.KtModuleProviderBuilder import org.jetbrains.kotlin.analysis.project.structure.builder.buildProjectStructureProvider -import org.jetbrains.kotlin.analysis.project.structure.impl.KtModuleProviderImpl +import org.jetbrains.kotlin.analysis.project.structure.impl.KtStandaloneProjectStructureProvider import org.jetbrains.kotlin.analysis.project.structure.impl.KtSourceModuleImpl import org.jetbrains.kotlin.analysis.project.structure.impl.buildKtModuleProviderByCompilerConfiguration import org.jetbrains.kotlin.analysis.project.structure.impl.getPsiFilesFromPaths @@ -161,13 +161,13 @@ public class StandaloneAnalysisAPISessionBuilder( } private fun registerPsiDeclarationFromBinaryModuleProvider() { - val ktModuleProviderImpl = projectStructureProvider as KtModuleProviderImpl + val standaloneProjectStructureProvider = projectStructureProvider as KtStandaloneProjectStructureProvider kotlinCoreProjectEnvironment.project.apply { registerService( KotlinPsiDeclarationProviderFactory::class.java, KotlinStaticPsiDeclarationProviderFactory( this, - ktModuleProviderImpl.binaryModules, + standaloneProjectStructureProvider.binaryModules, kotlinCoreProjectEnvironment.environment.jarFileSystem as CoreJarFileSystem ) ) diff --git a/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/project/structure/builder/KtModuleProviderBuilder.kt b/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/project/structure/builder/KtModuleProviderBuilder.kt index 03f81e94d9c..fa85a62bb5c 100644 --- a/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/project/structure/builder/KtModuleProviderBuilder.kt +++ b/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/project/structure/builder/KtModuleProviderBuilder.kt @@ -7,7 +7,7 @@ package org.jetbrains.kotlin.analysis.project.structure.builder import org.jetbrains.kotlin.analysis.api.standalone.base.project.structure.KtStaticProjectStructureProvider import org.jetbrains.kotlin.analysis.project.structure.KtModule -import org.jetbrains.kotlin.analysis.project.structure.impl.KtModuleProviderImpl +import org.jetbrains.kotlin.analysis.project.structure.impl.KtStandaloneProjectStructureProvider import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreProjectEnvironment import org.jetbrains.kotlin.platform.TargetPlatform import kotlin.contracts.ExperimentalContracts @@ -27,7 +27,7 @@ public class KtModuleProviderBuilder( public lateinit var platform: TargetPlatform public fun build(): KtStaticProjectStructureProvider { - return KtModuleProviderImpl( + return KtStandaloneProjectStructureProvider( platform, kotlinCoreProjectEnvironment.project, mainModules, diff --git a/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/project/structure/impl/KtModuleProviderImpl.kt b/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/project/structure/impl/KtStandaloneProjectStructureProvider.kt similarity index 98% rename from analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/project/structure/impl/KtModuleProviderImpl.kt rename to analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/project/structure/impl/KtStandaloneProjectStructureProvider.kt index 239e5853c15..37356507008 100644 --- a/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/project/structure/impl/KtModuleProviderImpl.kt +++ b/analysis/analysis-api-standalone/src/org/jetbrains/kotlin/analysis/project/structure/impl/KtStandaloneProjectStructureProvider.kt @@ -21,7 +21,7 @@ import org.jetbrains.kotlin.psi.analysisContext import org.jetbrains.kotlin.serialization.deserialization.builtins.BuiltInSerializerProtocol import org.jetbrains.kotlin.utils.KotlinExceptionWithAttachments -internal class KtModuleProviderImpl( +internal class KtStandaloneProjectStructureProvider( private val platform: TargetPlatform, private val project: Project, override val allKtModules: List,