From 43ef0ffa507efdcf1451df29af40e1cd2e252aea Mon Sep 17 00:00:00 2001 From: Dmitry Savvinov Date: Wed, 5 Jun 2019 12:01:34 +0300 Subject: [PATCH] [Testing] Support diagnostics filters in MultiModuleIdeResolveTest --- .../org/jetbrains/kotlin/checkers/BaseDiagnosticsTest.kt | 2 +- .../caches/resolve/AbstractMultiModuleIdeResolveTest.kt | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/compiler/tests-common/tests/org/jetbrains/kotlin/checkers/BaseDiagnosticsTest.kt b/compiler/tests-common/tests/org/jetbrains/kotlin/checkers/BaseDiagnosticsTest.kt index 67bd33d775e..d9f04081a81 100644 --- a/compiler/tests-common/tests/org/jetbrains/kotlin/checkers/BaseDiagnosticsTest.kt +++ b/compiler/tests-common/tests/org/jetbrains/kotlin/checkers/BaseDiagnosticsTest.kt @@ -405,7 +405,7 @@ abstract class BaseDiagnosticsTest : KotlinMultiFileTestWithJava, allowUnderscoreUsage: Boolean ): Condition { diff --git a/idea/tests/org/jetbrains/kotlin/idea/caches/resolve/AbstractMultiModuleIdeResolveTest.kt b/idea/tests/org/jetbrains/kotlin/idea/caches/resolve/AbstractMultiModuleIdeResolveTest.kt index 4d218c9e406..d0d5ce088dd 100644 --- a/idea/tests/org/jetbrains/kotlin/idea/caches/resolve/AbstractMultiModuleIdeResolveTest.kt +++ b/idea/tests/org/jetbrains/kotlin/idea/caches/resolve/AbstractMultiModuleIdeResolveTest.kt @@ -7,6 +7,7 @@ package org.jetbrains.kotlin.idea.caches.resolve import com.intellij.psi.PsiFile import com.intellij.util.io.exists +import org.jetbrains.kotlin.checkers.BaseDiagnosticsTest import org.jetbrains.kotlin.checkers.utils.CheckerTestUtil import org.jetbrains.kotlin.descriptors.impl.ModuleDescriptorImpl import org.jetbrains.kotlin.idea.multiplatform.setupMppProjectFromTextFile @@ -60,6 +61,9 @@ abstract class AbstractMultiModuleIdeResolveTest : AbstractMultiModuleTest() { val resolutionFacade = file.getResolutionFacade() val (bindingContext, moduleDescriptor) = resolutionFacade.analyzeWithAllCompilerChecks(listOf(file)) + val directives = KotlinTestUtils.parseDirectives(file.text) + val diagnosticsFilter = BaseDiagnosticsTest.parseDiagnosticFilterDirective(directives, allowUnderscoreUsage = false) + val actualDiagnostics = CheckerTestUtil.getDiagnosticsIncludingSyntaxErrors( bindingContext, file, @@ -70,7 +74,7 @@ abstract class AbstractMultiModuleIdeResolveTest : AbstractMultiModuleTest() { languageVersionSettings = resolutionFacade.frontendService(), dataFlowValueFactory = resolutionFacade.frontendService(), moduleDescriptor = moduleDescriptor as ModuleDescriptorImpl - ) + ).filter { diagnosticsFilter.value(it.diagnostic) } val actualTextWithDiagnostics = CheckerTestUtil.addDiagnosticMarkersToText( file,