azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clearer diagnostic message for platform type inspection #KT-14630 Fixed

Browse Source
This commit is contained in:
Mikhail Glukhikh
2017-01-10 13:13:59 +03:00
parent 3bf38e62c8
commit 43a4035390
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/kotlin/idea/inspections/HasPlatformTypeInspection.kt
+2 -1
View File
@@ -47,7 +47,8 @@ class HasPlatformTypeInspection(
override val problemHighlightType = ProblemHighlightType.WEAK_WARNING override val problemHighlightType = ProblemHighlightType.WEAK_WARNING
override val problemText = "Declaration has platform type. Make the type explicit to prevent subtle bugs." override val problemText = "Declaration has type inferred from a platform call, which can lead to unchecked nullability issues. " +
"Specify type explicitly as nullable or non-nullable."
override fun additionalFixes(element: KtCallableDeclaration): List<LocalQuickFix>? { override fun additionalFixes(element: KtCallableDeclaration): List<LocalQuickFix>? {
val type = SpecifyTypeExplicitlyIntention.dangerousFlexibleTypeOrNull(element, publicAPIOnly, reportPlatformArguments) ?: return null val type = SpecifyTypeExplicitlyIntention.dangerousFlexibleTypeOrNull(element, publicAPIOnly, reportPlatformArguments) ?: return null
idea/testData/inspections/hasPlatformType/inspectionData/expected.xml
Vendored
+3 -3
View File
@@ -5,7 +5,7 @@
<module>light_idea_test_case</module> <module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/function.kt" /> <entry_point TYPE="file" FQNAME="temp:///src/function.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Function, property or variable has platform type.</problem_class> <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Function, property or variable has platform type.</problem_class>
<description>Declaration has platform type. Make the type explicit to prevent subtle bugs.</description> <description>Declaration has type inferred from a platform call, which can lead to unchecked nullability issues. Specify type explicitly as nullable or non-nullable.</description>
</problem> </problem>
<problem> <problem>
<file>function.kt</file> <file>function.kt</file>
@@ -13,7 +13,7 @@
<module>light_idea_test_case</module> <module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/function.kt" /> <entry_point TYPE="file" FQNAME="temp:///src/function.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Function or property has platform type</problem_class> <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Function or property has platform type</problem_class>
<description>Declaration has platform type. Make the type explicit to prevent subtle bugs.</description> <description>Declaration has type inferred from a platform call, which can lead to unchecked nullability issues. Specify type explicitly as nullable or non-nullable.</description>
</problem> </problem>
<problem> <problem>
<file>property1.kt</file> <file>property1.kt</file>
@@ -21,6 +21,6 @@
<module>light_idea_test_case</module> <module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/property1.kt" /> <entry_point TYPE="file" FQNAME="temp:///src/property1.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Function, property or variable has platform type.</problem_class> <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Function, property or variable has platform type.</problem_class>
<description>Declaration has platform type. Make the type explicit to prevent subtle bugs.</description> <description>Declaration has type inferred from a platform call, which can lead to unchecked nullability issues. Specify type explicitly as nullable or non-nullable.</description>
</problem> </problem>
</problems> </problems>