From 436b63728263d9147b29f14ced13b77cf02b6662 Mon Sep 17 00:00:00 2001 From: Nikolay Krasko Date: Thu, 20 Jul 2017 20:35:40 +0300 Subject: [PATCH] Refactoring: show using ProcessCancelException in method name --- idea/src/org/jetbrains/kotlin/idea/ProgressUtil.kt | 3 +-- .../kotlin/idea/debugger/evaluate/KotlinDebuggerCaches.kt | 6 +++--- .../idea/debugger/evaluate/KotlinEvaluationBuilder.kt | 4 ++-- .../debugger/evaluate/extractFunctionForDebuggerUtil.kt | 4 ++-- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/idea/src/org/jetbrains/kotlin/idea/ProgressUtil.kt b/idea/src/org/jetbrains/kotlin/idea/ProgressUtil.kt index c08f0aca04d..29026d5a97e 100644 --- a/idea/src/org/jetbrains/kotlin/idea/ProgressUtil.kt +++ b/idea/src/org/jetbrains/kotlin/idea/ProgressUtil.kt @@ -21,8 +21,7 @@ import com.intellij.openapi.progress.ProgressManager import com.intellij.openapi.progress.util.ProgressIndicatorUtils import com.intellij.openapi.project.Project - -fun runInReadActionWithWriteActionPriority(f: () -> T): T { +fun runInReadActionWithWriteActionPriorityWithPCE(f: () -> T): T { var r: T? = null val complete = ProgressIndicatorUtils.runInReadActionWithWriteActionPriority { r = f() diff --git a/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/KotlinDebuggerCaches.kt b/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/KotlinDebuggerCaches.kt index f4fc6fac609..f2167833ef9 100644 --- a/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/KotlinDebuggerCaches.kt +++ b/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/KotlinDebuggerCaches.kt @@ -43,7 +43,7 @@ import org.jetbrains.kotlin.idea.debugger.BinaryCacheKey import org.jetbrains.kotlin.idea.debugger.BytecodeDebugInfo import org.jetbrains.kotlin.idea.debugger.WeakBytecodeDebugInfoStorage import org.jetbrains.kotlin.idea.debugger.evaluate.classLoading.ClassToLoad -import org.jetbrains.kotlin.idea.runInReadActionWithWriteActionPriority +import org.jetbrains.kotlin.idea.runInReadActionWithWriteActionPriorityWithPCE import org.jetbrains.kotlin.idea.util.application.runReadAction import org.jetbrains.kotlin.psi.KtCodeFragment import org.jetbrains.kotlin.psi.KtElement @@ -177,12 +177,12 @@ class KotlinDebuggerCaches(project: Project) { runReadAction { element as? KtElement ?: PsiTreeUtil.getParentOfType(element, KtElement::class.java)!! } private fun createTypeMapperForLibraryFile(element: KtElement, file: KtFile): KotlinTypeMapper = - runInReadActionWithWriteActionPriority { + runInReadActionWithWriteActionPriorityWithPCE { createTypeMapper(file, element.analyzeAndGetResult()) } private fun createTypeMapperForSourceFile(file: KtFile): KotlinTypeMapper = - runInReadActionWithWriteActionPriority { + runInReadActionWithWriteActionPriorityWithPCE { createTypeMapper(file, file.analyzeFullyAndGetResult().apply(AnalysisResult::throwIfError)) } diff --git a/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/KotlinEvaluationBuilder.kt b/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/KotlinEvaluationBuilder.kt index 7d45bd02f1d..ecde68af484 100644 --- a/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/KotlinEvaluationBuilder.kt +++ b/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/KotlinEvaluationBuilder.kt @@ -65,7 +65,7 @@ import org.jetbrains.kotlin.idea.debugger.evaluate.classLoading.ClassToLoad import org.jetbrains.kotlin.idea.debugger.evaluate.compilingEvaluator.loadClasses import org.jetbrains.kotlin.idea.debugger.evaluate.compilingEvaluator.loadClassesSafely import org.jetbrains.kotlin.idea.refactoring.introduce.extractionEngine.ExtractionResult -import org.jetbrains.kotlin.idea.runInReadActionWithWriteActionPriority +import org.jetbrains.kotlin.idea.runInReadActionWithWriteActionPriorityWithPCE import org.jetbrains.kotlin.idea.util.application.runReadAction import org.jetbrains.kotlin.idea.util.attachment.attachmentByPsiFile import org.jetbrains.kotlin.idea.util.attachment.mergeAttachments @@ -526,7 +526,7 @@ class KotlinEvaluator(val codeFragment: KtCodeFragment, val sourcePosition: Sour // contextFile must be NotNull when analyzeInlineFunctions = true private fun KtFile.checkForErrors(analyzeInlineFunctions: Boolean = false, contextFile: KtFile? = null): ExtendedAnalysisResult { - return runInReadActionWithWriteActionPriority { + return runInReadActionWithWriteActionPriorityWithPCE { try { AnalyzingUtils.checkForSyntacticErrors(this) } diff --git a/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/extractFunctionForDebuggerUtil.kt b/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/extractFunctionForDebuggerUtil.kt index 73982881437..45166a2b474 100644 --- a/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/extractFunctionForDebuggerUtil.kt +++ b/idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/extractFunctionForDebuggerUtil.kt @@ -30,7 +30,7 @@ import org.jetbrains.kotlin.idea.core.replaced import org.jetbrains.kotlin.idea.refactoring.introduce.extractionEngine.* import org.jetbrains.kotlin.idea.refactoring.introduce.extractionEngine.AnalysisResult.ErrorMessage import org.jetbrains.kotlin.idea.refactoring.introduce.extractionEngine.AnalysisResult.Status -import org.jetbrains.kotlin.idea.runInReadActionWithWriteActionPriority +import org.jetbrains.kotlin.idea.runInReadActionWithWriteActionPriorityWithPCE import org.jetbrains.kotlin.idea.util.application.runReadAction import org.jetbrains.kotlin.idea.util.attachment.attachmentByPsiFile import org.jetbrains.kotlin.idea.util.attachment.mergeAttachments @@ -154,7 +154,7 @@ private fun KtFile.findContextElement(): KtElement? { private var PsiElement.DEBUG_SMART_CAST: PsiElement? by CopyableUserDataProperty(Key.create("DEBUG_SMART_CAST")) private fun KtCodeFragment.markSmartCasts() { - val bindingContext = runInReadActionWithWriteActionPriority { analyzeFully() } + val bindingContext = runInReadActionWithWriteActionPriorityWithPCE { analyzeFully() } val factory = KtPsiFactory(project) getContentElement()?.forEachDescendantOfType { expression ->