azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve wording in some inspections

Browse Source
This commit is contained in:
Mikhail Glukhikh
2017-12-26 18:06:40 +03:00
parent 1534488dd1
commit 429c31c010
52 changed files with 83 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/divSanityTest.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '/' operator
// FIX: Replace with '/'
fun test() {
class Test {
operator fun div(a: Int): Test = Test()
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/divSanityTest.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '/' operator
// FIX: Replace with '/'
fun test() {
class Test {
operator fun div(a: Int): Test = Test()
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/equals.kt
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '==' operator
// FIX: Replace with '=='
val x = 2.<caret>equals(2)
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/equals.kt.after
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '==' operator
// FIX: Replace with '=='
val x = 2 == 2
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/greater.kt
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '>' operator
// FIX: Replace with '>'
val x = 3.compare<caret>To(2) > 0
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/greater.kt.after
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '>' operator
// FIX: Replace with '>'
val x = 3 > 2
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/lessEquals.kt
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '<=' operator
// FIX: Replace with '<='
val x = 0 >= 4.compare<caret>To(5)
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/lessEquals.kt.after
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '<=' operator
// FIX: Replace with '<='
val x = 4 <= 5
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/minusSanityTest.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '-' operator
// FIX: Replace with '-'
fun test() {
class Test {
operator fun minus(a: Int): Test = Test()
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/minusSanityTest.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '-' operator
// FIX: Replace with '-'
fun test() {
class Test {
operator fun minus(a: Int): Test = Test()
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEquals.kt
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '!=' operator
// FIX: Replace with '!='
val x = !2.eq<caret>uals(3)
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEquals.kt.after
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '!=' operator
// FIX: Replace with '!='
val x = 2 != 3
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEqualsBrackets.kt
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '!=' operator
// FIX: Replace with '!='
val x = !(2.<caret>equals(3))
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEqualsBrackets.kt.after
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '!=' operator
// FIX: Replace with '!='
val x = 2 != 3
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEqualsBracketsComplex.kt
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '==' operator
// FIX: Replace with '=='
val x = !(2.equ<caret>als(3) && 4.equals(5))
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/notEqualsBracketsComplex.kt.after
Vendored
+1 -1
View File
@@ -1,3 +1,3 @@
// FIX: Replace with '==' operator
// FIX: Replace with '=='
val x = !(2 == 3 && 4.equals(5))
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/plusSanityTest.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '+' operator
// FIX: Replace with '+'
fun test() {
class Test {
operator fun plus(a: Int): Test = Test()
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/plusSanityTest.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '+' operator
// FIX: Replace with '+'
fun test() {
class Test {
operator fun plus(a: Int): Test = Test()
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/rangeToSanityTest.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '..' operator
// FIX: Replace with '..'
fun test() {
class Test {
operator fun rangeTo(a: Int): Test = Test()
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/rangeToSanityTest.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '..' operator
// FIX: Replace with '..'
fun test() {
class Test {
operator fun rangeTo(a: Int): Test = Test()
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/remSanityTest.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '%' operator
// FIX: Replace with '%'
fun test() {
class Test {
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/remSanityTest.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '%' operator
// FIX: Replace with '%'
fun test() {
class Test {
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/timesSanityTest.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '*' operator
// FIX: Replace with '*'
fun test() {
class Test {
operator fun times(a: Int): Test = Test()
idea/testData/inspectionsLocal/conventionNameCalls/replaceCallWithBinaryOperator/timesSanityTest.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Replace with '*' operator
// FIX: Replace with '*'
fun test() {
class Test {
operator fun times(a: Int): Test = Test()
idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/inspectionData/expected.xml
Vendored
+9 -9
View File
@@ -5,7 +5,7 @@
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="singleArgument.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
<description>Call replaceable with indexing operator</description>
<description>Should be replaced with indexing</description>
</problem>
<problem>
@@ -14,7 +14,7 @@
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="multiArgument.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
<description>Call replaceable with indexing operator</description>
<description>Should be replaced with indexing</description>
</problem>
<problem>
@@ -23,7 +23,7 @@
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="functionalArgument.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
<description>Call replaceable with indexing operator</description>
<description>Should be replaced with indexing</description>
</problem>
<problem>
@@ -32,7 +32,7 @@
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="extensionFunction.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
<description>Call replaceable with indexing operator</description>
<description>Should be replaced with indexing</description>
</problem>
<problem>
@@ -41,7 +41,7 @@
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="argumentAndFunction.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
<description>Call replaceable with indexing operator</description>
<description>Should be replaced with indexing</description>
</problem>
<problem>
@@ -50,7 +50,7 @@
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="acceptableVararg.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
<description>Call replaceable with indexing operator</description>
<description>Should be replaced with indexing</description>
</problem>
<problem>
@@ -59,7 +59,7 @@
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="qualifier.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
<description>Call replaceable with indexing operator</description>
<description>Should be replaced with indexing</description>
</problem>
<problem>
@@ -68,7 +68,7 @@
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="set.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
<description>Call replaceable with indexing operator</description>
<description>Should be replaced with indexing</description>
</problem>
<problem>
@@ -77,6 +77,6 @@
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="set2.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
<description>Call replaceable with indexing operator</description>
<description>Should be replaced with indexing</description>
</problem>
</problems>
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/equals.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '==' expression to '!='
// FIX: Replace negated '==' operation with '!='
fun test(n: Int) {
<caret>!(0 == 1)
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/equals.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '==' expression to '!='
// FIX: Replace negated '==' operation with '!='
fun test(n: Int) {
0 != 1
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/greaterThan.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '>' expression to '<='
// FIX: Replace negated '>' operation with '<='
fun test(n: Int) {
<caret>!(0 > 1)
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/greaterThan.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '>' expression to '<='
// FIX: Replace negated '>' operation with '<='
fun test(n: Int) {
0 <= 1
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/greaterThanOrEquals.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '>=' expression to '<'
// FIX: Replace negated '>=' operation with '<'
fun test(n: Int) {
<caret>!(0 >= 1)
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/greaterThanOrEquals.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '>=' expression to '<'
// FIX: Replace negated '>=' operation with '<'
fun test(n: Int) {
0 < 1
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/in.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated 'in' expression to '!in'
// FIX: Replace negated 'in' operation with '!in'
class A(val e: Int) {
operator fun contains(i: Int): Boolean = e == i
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/in.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated 'in' expression to '!in'
// FIX: Replace negated 'in' operation with '!in'
class A(val e: Int) {
operator fun contains(i: Int): Boolean = e == i
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/inspectionData/expected.xml
Vendored
+20 -30
View File
@@ -5,9 +5,8 @@
<line>3</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/notIs.kt"/>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified
</problem_class>
<description>Negated expression should be simplified</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified</problem_class>
<description>Negated operation should be simplified</description>
</problem>
<problem>
@@ -15,9 +14,8 @@
<line>8</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/notIn.kt"/>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified
</problem_class>
<description>Negated expression should be simplified</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified</problem_class>
<description>Negated operation should be simplified</description>
</problem>
<problem>
@@ -25,9 +23,8 @@
<line>3</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/notEquals.kt"/>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified
</problem_class>
<description>Negated expression should be simplified</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified</problem_class>
<description>Negated operation should be simplified</description>
</problem>
<problem>
@@ -35,9 +32,8 @@
<line>3</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/lessThanOrEquals.kt"/>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified
</problem_class>
<description>Negated expression should be simplified</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified</problem_class>
<description>Negated operation should be simplified</description>
</problem>
<problem>
@@ -45,9 +41,8 @@
<line>3</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/lessThan.kt"/>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified
</problem_class>
<description>Negated expression should be simplified</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified</problem_class>
<description>Negated operation should be simplified</description>
</problem>
<problem>
@@ -55,9 +50,8 @@
<line>3</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/is.kt"/>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified
</problem_class>
<description>Negated expression should be simplified</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified</problem_class>
<description>Negated operation should be simplified</description>
</problem>
<problem>
@@ -65,9 +59,8 @@
<line>8</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/in.kt"/>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified
</problem_class>
<description>Negated expression should be simplified</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified</problem_class>
<description>Negated operation should be simplified</description>
</problem>
<problem>
@@ -75,9 +68,8 @@
<line>3</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/greaterThanOrEquals.kt"/>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified
</problem_class>
<description>Negated expression should be simplified</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified</problem_class>
<description>Negated operation should be simplified</description>
</problem>
<problem>
@@ -85,9 +77,8 @@
<line>3</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/greaterThan.kt"/>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified
</problem_class>
<description>Negated expression should be simplified</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified</problem_class>
<description>Negated operation should be simplified</description>
</problem>
<problem>
@@ -95,9 +86,8 @@
<line>3</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/equals.kt"/>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified
</problem_class>
<description>Negated expression should be simplified</description>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Negated boolean expression that can be simplified</problem_class>
<description>Negated operation should be simplified</description>
</problem>
</problems>
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/is.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated 'is' expression to '!is'
// FIX: Replace negated 'is' operation with '!is'
fun test(n: Int) {
<caret>!(0 is Int)
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/is.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated 'is' expression to '!is'
// FIX: Replace negated 'is' operation with '!is'
fun test(n: Int) {
0 !is Int
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/lessThan.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '<' expression to '>='
// FIX: Replace negated '<' operation with '>='
fun test(n: Int) {
<caret>!(0 < 1)
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/lessThan.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '<' expression to '>='
// FIX: Replace negated '<' operation with '>='
fun test(n: Int) {
0 >= 1
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/lessThanOrEquals.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '<=' expression to '>'
// FIX: Replace negated '<=' operation with '>'
fun test(n: Int) {
<caret>!(0 <= 1)
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/lessThanOrEquals.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '<=' expression to '>'
// FIX: Replace negated '<=' operation with '>'
fun test(n: Int) {
0 > 1
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/notEquals.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '!=' expression to '=='
// FIX: Replace negated '!=' operation with '=='
fun test(n: Int) {
<caret>!(0 != 1)
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/notEquals.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '!=' expression to '=='
// FIX: Replace negated '!=' operation with '=='
fun test(n: Int) {
0 == 1
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/notIn.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '!in' expression to 'in'
// FIX: Replace negated '!in' operation with 'in'
class A(val e: Int) {
operator fun contains(i: Int): Boolean = e == i
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/notIn.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '!in' expression to 'in'
// FIX: Replace negated '!in' operation with 'in'
class A(val e: Int) {
operator fun contains(i: Int): Boolean = e == i
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/notIs.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '!is' expression to 'is'
// FIX: Replace negated '!is' operation with 'is'
fun test(n: Int) {
<caret>!(0 !is Int)
}
idea/testData/inspectionsLocal/simplifyNegatedBinaryExpression/notIs.kt.after
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// FIX: Simplify negated '!is' expression to 'is'
// FIX: Replace negated '!is' operation with 'is'
fun test(n: Int) {
0 is Int
}