From 422128f3dc79dc731f040d40175cdf96bbc74976 Mon Sep 17 00:00:00 2001 From: Sergej Jaskiewicz Date: Thu, 11 Jan 2024 18:42:04 +0100 Subject: [PATCH] [MPP] Fix a failing MPP diagnostic test This test had the IGNORE_FIR2IR_EXCEPTIONS_IF_FIR_CONTAINS_ERRORS directive enabled. This prevented some diagnostics from showing up in this test, because there was this exception thrown in FIR2IR: java.lang.IllegalStateException: IrSimpleFunctionPublicSymbolImpl for /foo|foo(){}[0] is already bound: FUN name:foo visibility:public modality:FINAL <> () returnType:kotlin.Unit a0ba878b1dd73ec0870a770d1fc7d6eaf09532d0 disabled the `linkViaSignatures` flag in JS tests, which also fixed the exception. Because of that, the full pipeline could be run, and the diagnostics started to appear, which is the correct behavior. Not that this only concerns _tests_, not production code, because in the production pipeline `linkViaSignatures` had been disabled even before that change. --- .../topLevelFun/conflictingImplDeclarations.fir.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/testData/diagnostics/tests/multiplatform/topLevelFun/conflictingImplDeclarations.fir.kt b/compiler/testData/diagnostics/tests/multiplatform/topLevelFun/conflictingImplDeclarations.fir.kt index 1ad9727242a..34b85ebb9f3 100644 --- a/compiler/testData/diagnostics/tests/multiplatform/topLevelFun/conflictingImplDeclarations.fir.kt +++ b/compiler/testData/diagnostics/tests/multiplatform/topLevelFun/conflictingImplDeclarations.fir.kt @@ -1,7 +1,7 @@ // MODULE: m1-common // FILE: common.kt -expect fun foo() +expect fun foo() // MODULE: m2-jvm()()(m1-common) // FILE: jvm.kt