azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

K2: Fix ISE from inference on delegate vars with implicit types

Browse Source 
See the test data.
ISE happened because at some point after incomplete `getValue` resolution
of `a` property, we updated in the `transformAccessors` the property type
to the `Variable(Y)` type and then used it as a 3rd argument for
`setValue` call which is incorrect because the variable belongs
to a different constraint system (from `getValue`).

Mostly, the fix is just a repeating K1 behavior, namely postponing
`setValue` resolution until delegate inference is completed.

^KT-59066 Fixed
This commit is contained in:
Denis.Zharkov
2023-06-09 11:36:47 +02:00
committed by Space Team
parent b8c4a4c80a
commit 41933facbb
9 changed files with 175 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/DiagnosticCompilerTestFE10TestdataTestGenerated.java
Generated
+12
View File
@@ -8974,12 +8974,24 @@ public class DiagnosticCompilerTestFE10TestdataTestGenerated extends AbstractDia
runTest("compiler/testData/diagnostics/tests/delegatedProperty/missedSetter.kt");
}
@Test
@TestMetadata("noInferenceFromGetValueThroughSetValue.kt")
public void testNoInferenceFromGetValueThroughSetValue() throws Exception {
runTest("compiler/testData/diagnostics/tests/delegatedProperty/noInferenceFromGetValueThroughSetValue.kt");
}
@Test
@TestMetadata("noInferenceFromWrappedDelegate.kt")
public void testNoInferenceFromWrappedDelegate() throws Exception {
runTest("compiler/testData/diagnostics/tests/delegatedProperty/noInferenceFromWrappedDelegate.kt");
}
@Test
@TestMetadata("noPreliminarySetterInferenceForImplicitlyTypedVar.kt")
public void testNoPreliminarySetterInferenceForImplicitlyTypedVar() throws Exception {
runTest("compiler/testData/diagnostics/tests/delegatedProperty/noPreliminarySetterInferenceForImplicitlyTypedVar.kt");
}
@Test
@TestMetadata("nonDefaultAccessors.kt")
public void testNonDefaultAccessors() throws Exception {
analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/LLFirPreresolvedReversedDiagnosticCompilerFE10TestDataTestGenerated.java
Generated
+12
View File
@@ -8974,12 +8974,24 @@ public class LLFirPreresolvedReversedDiagnosticCompilerFE10TestDataTestGenerated
runTest("compiler/testData/diagnostics/tests/delegatedProperty/missedSetter.kt");
}
@Test
@TestMetadata("noInferenceFromGetValueThroughSetValue.kt")
public void testNoInferenceFromGetValueThroughSetValue() throws Exception {
runTest("compiler/testData/diagnostics/tests/delegatedProperty/noInferenceFromGetValueThroughSetValue.kt");
}
@Test
@TestMetadata("noInferenceFromWrappedDelegate.kt")
public void testNoInferenceFromWrappedDelegate() throws Exception {
runTest("compiler/testData/diagnostics/tests/delegatedProperty/noInferenceFromWrappedDelegate.kt");
}
@Test
@TestMetadata("noPreliminarySetterInferenceForImplicitlyTypedVar.kt")
public void testNoPreliminarySetterInferenceForImplicitlyTypedVar() throws Exception {
runTest("compiler/testData/diagnostics/tests/delegatedProperty/noPreliminarySetterInferenceForImplicitlyTypedVar.kt");
}
@Test
@TestMetadata("nonDefaultAccessors.kt")
public void testNonDefaultAccessors() throws Exception {