From 417f4f821b29987689a68a5fd50ea588a8bd5732 Mon Sep 17 00:00:00 2001 From: Alexey Tsvetkov Date: Tue, 11 Oct 2016 18:20:13 +0300 Subject: [PATCH] Minor: remove duplicated logger utils --- .../kotlin/annotation/AnnotationFileUpdater.kt | 2 +- .../kotlin/gradle/plugin/gradleUtils.kt | 4 ++++ .../org/jetbrains/kotlin/gradle/tasks/Tasks.kt | 18 +++--------------- .../incremental/ChangedJavaFilesProcessor.kt | 2 +- .../kotlin/incremental/GradleIncReporter.kt | 2 +- 5 files changed, 10 insertions(+), 18 deletions(-) diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/annotation/AnnotationFileUpdater.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/annotation/AnnotationFileUpdater.kt index eabe285ffb4..8e144f449f5 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/annotation/AnnotationFileUpdater.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/annotation/AnnotationFileUpdater.kt @@ -1,7 +1,7 @@ package org.jetbrains.kotlin.annotation import org.gradle.api.logging.Logging -import org.jetbrains.kotlin.gradle.tasks.kotlinDebug +import org.jetbrains.kotlin.gradle.plugin.kotlinDebug import org.jetbrains.kotlin.resolve.jvm.JvmClassName import java.io.File import java.util.* diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/gradleUtils.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/gradleUtils.kt index 6f98ffaba15..ebecb6732e9 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/gradleUtils.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/gradleUtils.kt @@ -44,6 +44,10 @@ internal inline fun Any.addExtension(name: String, extension: internal fun Any.getConvention(name: String): Any? = (this as HasConvention).convention.plugins[name] +internal fun Logger.kotlinInfo(message: String) { + this.info("[KOTLIN] $message") +} + internal fun Logger.kotlinDebug(message: String) { this.debug("[KOTLIN] $message") } diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/tasks/Tasks.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/tasks/Tasks.kt index b40b73643e5..65809b066d7 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/tasks/Tasks.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/tasks/Tasks.kt @@ -29,6 +29,8 @@ import org.jetbrains.kotlin.compilerRunner.OutputItemsCollector import org.jetbrains.kotlin.compilerRunner.OutputItemsCollectorImpl import org.jetbrains.kotlin.config.Services import org.jetbrains.kotlin.gradle.dsl.* +import org.jetbrains.kotlin.gradle.plugin.kotlinDebug +import org.jetbrains.kotlin.gradle.plugin.kotlinInfo import org.jetbrains.kotlin.incremental.* import org.jetbrains.kotlin.incremental.components.LookupTracker import org.jetbrains.kotlin.incremental.components.SourceRetentionAnnotationHandler @@ -417,18 +419,4 @@ internal class GradleMessageCollector(val logger: Logger) : MessageCollector { else -> throw IllegalArgumentException("Unknown CompilerMessageSeverity: $severity") } } -} - -internal fun Logger.kotlinInfo(message: String) { - this.info("[KOTLIN] $message") -} - -internal fun Logger.kotlinDebug(message: String) { - this.debug("[KOTLIN] $message") -} - -internal inline fun Logger.kotlinDebug(message: ()->String) { - if (isDebugEnabled) { - kotlinDebug(message()) - } -} +} \ No newline at end of file diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/incremental/ChangedJavaFilesProcessor.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/incremental/ChangedJavaFilesProcessor.kt index 36b4c45be12..152b76eb755 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/incremental/ChangedJavaFilesProcessor.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/incremental/ChangedJavaFilesProcessor.kt @@ -26,7 +26,7 @@ import org.jetbrains.kotlin.com.intellij.psi.PsiFile import org.jetbrains.kotlin.com.intellij.psi.PsiFileFactory import org.jetbrains.kotlin.com.intellij.psi.PsiJavaFile import org.jetbrains.kotlin.config.CompilerConfiguration -import org.jetbrains.kotlin.gradle.tasks.kotlinDebug +import org.jetbrains.kotlin.gradle.plugin.kotlinDebug import org.jetbrains.kotlin.incremental.ChangesEither import org.jetbrains.kotlin.incremental.LookupSymbol import org.jetbrains.kotlin.incremental.snapshots.FileCollectionDiff diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/incremental/GradleIncReporter.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/incremental/GradleIncReporter.kt index 03713496c37..62979ee8a02 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/incremental/GradleIncReporter.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/incremental/GradleIncReporter.kt @@ -1,7 +1,7 @@ package org.jetbrains.kotlin.incremental import org.gradle.api.logging.Logging -import org.jetbrains.kotlin.gradle.tasks.kotlinDebug +import org.jetbrains.kotlin.gradle.plugin.kotlinDebug import java.io.File internal class GradleIncReporter(private val projectRootFile: File) : IncReporter() {