azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change Signature: Clear callback after the call

Browse Source 
Retaining the callback leads to the leak of obsolete resolve data
This commit is contained in:
Alexey Sedunov
2018-10-10 13:51:19 +03:00
parent c3af3cc482
commit 3fcf6e7719
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/kotlin/idea/refactoring/changeSignature/KotlinChangeSignatureProcessor.kt
+10
View File
@@ -45,6 +45,16 @@ class KotlinChangeSignatureProcessor(
val ktChangeInfo val ktChangeInfo
get() = changeInfo.delegate!! get() = changeInfo.delegate!!
override fun setPrepareSuccessfulSwingThreadCallback(callback: Runnable?) {
val actualCallback = if (callback != null) {
Runnable {
callback.run()
setPrepareSuccessfulSwingThreadCallback(null)
}
} else null
super.setPrepareSuccessfulSwingThreadCallback(actualCallback)
}
override fun createUsageViewDescriptor(usages: Array<UsageInfo>): UsageViewDescriptor { override fun createUsageViewDescriptor(usages: Array<UsageInfo>): UsageViewDescriptor {
val subject = if (ktChangeInfo.kind.isConstructor) "constructor" else "function" val subject = if (ktChangeInfo.kind.isConstructor) "constructor" else "function"
return KotlinUsagesViewDescriptor(myChangeInfo.method, RefactoringBundle.message("0.to.change.signature", subject)) return KotlinUsagesViewDescriptor(myChangeInfo.method, RefactoringBundle.message("0.to.change.signature", subject))