"Inapplicable operator modifier" and "Inapplicable infix modifier" are now errors

idea/testData/checker/ExtensionFunctions.kt

@@ -46,7 +46,7 @@ fun Int.foo() = this
           val foo : Int = 0
         }
 
-        <warning>operator</warning> fun Any.equals(<warning>other</warning> : Any?) : Boolean = true
+        <error>operator</error> fun Any.equals(<warning>other</warning> : Any?) : Boolean = true
         fun Any?.equals1(<warning>other</warning> : Any?) : Boolean = true
         fun Any.equals2(<warning>other</warning> : Any?) : Boolean = true
 

idea/testData/checker/ForRangeConventions.kt

@@ -27,7 +27,7 @@ abstract class NotRange4() {
 }
 
 abstract class ImproperIterator3 {
-  abstract <warning>operator</warning> fun hasNext() : Int
+  abstract <error>operator</error> fun hasNext() : Int
   abstract operator fun next() : Int
 }
 

idea/testData/checker/IncDec.kt

@@ -16,8 +16,8 @@ fun testIncDec() {
 }
 
 class WrongIncDec() {
-  <warning>operator</warning> fun inc() : Int = 1
-  <warning>operator</warning> fun dec() : Int = 1
+  <error>operator</error> fun inc() : Int = 1
+  <error>operator</error> fun dec() : Int = 1
 }
 
 fun testWrongIncDec() {
@@ -29,8 +29,8 @@ fun testWrongIncDec() {
 }
 
 class UnitIncDec() {
-  <warning>operator</warning> fun inc() : Unit {}
-  <warning>operator</warning> fun dec() : Unit {}
+  <error>operator</error> fun inc() : Unit {}
+  <error>operator</error> fun dec() : Unit {}
 }
 
 fun testUnitIncDec() {

idea/testData/intentions/conventionNameCalls/replaceCallWithBinaryOperator/acceptableVararg1.kt

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun plus(a: Int, vararg b: Int, c: Int = 0) : Int = 0
-    }
-    val test = Test()
-    test.p<caret>lus(1)
-}

idea/testData/intentions/conventionNameCalls/replaceCallWithBinaryOperator/acceptableVararg1.kt.after

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun plus(a: Int, vararg b: Int, c: Int = 0) : Int = 0
-    }
-    val test = Test()
-    test + 1
-}

idea/testData/intentions/conventionNameCalls/replaceCallWithBinaryOperator/acceptableVararg2.kt

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun plus(vararg b: Int, c: Int = 0) : Int = 0
-    }
-    val test = Test()
-    test.p<caret>lus(1)
-}

idea/testData/intentions/conventionNameCalls/replaceCallWithBinaryOperator/acceptableVararg2.kt.after

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun plus(vararg b: Int, c: Int = 0) : Int = 0
-    }
-    val test = Test()
-    test + 1
-}

idea/testData/intentions/conventionNameCalls/replaceCallWithBinaryOperator/allowableDefaultArgument.kt

@@ -1,7 +0,0 @@
-fun test() {
-    class Test {
-        operator fun plus(a: Int, b: Int=5): Test = Test()
-    }
-    val test = Test()
-    test.pl<caret>us(1)
-}

idea/testData/intentions/conventionNameCalls/replaceCallWithBinaryOperator/allowableDefaultArgument.kt.after

@@ -1,7 +0,0 @@
-fun test() {
-    class Test {
-        operator fun plus(a: Int, b: Int=5): Test = Test()
-    }
-    val test = Test()
-    test + 1
-}

idea/testData/intentions/conventionNameCalls/replaceCallWithBinaryOperator/missingDefaultArgument.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have a single value parameter
 fun test() {
     class Test{
         operator fun plus(a: Int=1, b: Int=2) : Int = 0

idea/testData/intentions/conventionNameCalls/replaceCallWithBinaryOperator/multipleArguments.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have a single value parameter
 fun test() {
     class Test {
         operator fun plus(a: Int, b: Int): Test = Test()

idea/testData/intentions/conventionNameCalls/replaceCallWithBinaryOperator/unacceptableVararg1.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have a single value parameter
 fun test() {
     class Test{
         operator fun plus(vararg b: Int, c: Int = 0): Int = 0

idea/testData/intentions/conventionNameCalls/replaceCallWithBinaryOperator/unacceptableVararg2.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have a single value parameter
 fun test() {
     class Test{
         operator fun plus(vararg b: Int, c: Int = 0): Int = 0

idea/testData/intentions/conventionNameCalls/replaceCallWithUnaryOperator/acceptableVararg.kt

@@ -1,7 +0,0 @@
-fun test() {
-    class Test {
-        operator fun unaryPlus(vararg a: Int): Test = Test()
-    }
-    val test = Test()
-    test.unaryPl<caret>us()
-}

idea/testData/intentions/conventionNameCalls/replaceCallWithUnaryOperator/acceptableVararg.kt.after

@@ -1,7 +0,0 @@
-fun test() {
-    class Test {
-        operator fun unaryPlus(vararg a: Int): Test = Test()
-    }
-    val test = Test()
-    +test
-}

idea/testData/intentions/conventionNameCalls/replaceCallWithUnaryOperator/defaultArgument.kt

@@ -1,7 +0,0 @@
-fun test() {
-    class Test {
-        operator fun unaryPlus(a: Int=1): Test = Test()
-    }
-    val test = Test()
-    test.unaryPl<caret>us()
-}

idea/testData/intentions/conventionNameCalls/replaceCallWithUnaryOperator/defaultArgument.kt.after

@@ -1,7 +0,0 @@
-fun test() {
-    class Test {
-        operator fun unaryPlus(a: Int=1): Test = Test()
-    }
-    val test = Test()
-    +test
-}

idea/testData/intentions/conventionNameCalls/replaceCallWithUnaryOperator/functionLiteralArgument.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have no value parameters
 fun test() {
     class Test {
         operator fun unaryPlus(fn: () -> Unit): Test = Test()

idea/testData/intentions/conventionNameCalls/replaceCallWithUnaryOperator/namedValueArgument.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have no value parameters
 fun test() {
     class Test {
         operator fun unaryPlus(a: Int): Test = Test()

idea/testData/intentions/conventionNameCalls/replaceCallWithUnaryOperator/unacceptableVararg.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have no value parameters
 fun test() {
     class Test {
         operator fun unaryPlus(vararg a: Int): Test = Test()

idea/testData/intentions/conventionNameCalls/replaceCallWithUnaryOperator/valueArgument.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have no value parameters
 fun test() {
     class Test {
         operator fun unaryPlus(a: Int): Test = Test()

idea/testData/intentions/conventionNameCalls/replaceContains/acceptableVararg.kt

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun contains(vararg a: Int, b: Int = 0): Boolean = true
-    }
-    val test = Test()
-    test.contai<caret>ns(1)
-}

idea/testData/intentions/conventionNameCalls/replaceContains/acceptableVararg.kt.after

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun contains(vararg a: Int, b: Int = 0): Boolean = true
-    }
-    val test = Test()
-    1 in test
-}

idea/testData/intentions/conventionNameCalls/replaceContains/acceptableVararg2.kt

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun contains(c: Int, vararg a: Int, b: Int = 0): Boolean = true
-    }
-    val test = Test()
-    test.contai<caret>ns(1)
-}

idea/testData/intentions/conventionNameCalls/replaceContains/acceptableVararg2.kt.after

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun contains(c: Int, vararg a: Int, b: Int = 0): Boolean = true
-    }
-    val test = Test()
-    1 in test
-}

idea/testData/intentions/conventionNameCalls/replaceContains/allowableDefaultArgument.kt

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun contains(a: Int, b: Int=5) : Boolean = true
-    }
-    val test = Test()
-    test.c<caret>ontains(1)
-}

idea/testData/intentions/conventionNameCalls/replaceContains/allowableDefaultArgument.kt.after

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun contains(a: Int, b: Int=5) : Boolean = true
-    }
-    val test = Test()
-    1 in test
-}

idea/testData/intentions/conventionNameCalls/replaceContains/invalidArgument.kt

@@ -1,5 +1,6 @@
 // IS_APPLICABLE: false
 // ERROR: Cannot find a parameter with this name: c
+// ERROR: operator modifier is inapplicable on this function: must have a single value parameter
 fun test() {
     class Test{
         operator fun contains(a: Int=1, b: Int=2): Boolean = true

idea/testData/intentions/conventionNameCalls/replaceContains/missingArgument.kt

@@ -1,5 +1,6 @@
 // IS_APPLICABLE: false
 // ERROR: No value passed for parameter b
+// ERROR: operator modifier is inapplicable on this function: must have a single value parameter
 fun test() {
     class Test{
         operator fun contains(a: Int, b: Int): Boolean = true

idea/testData/intentions/conventionNameCalls/replaceContains/missingDefaultArgument.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have a single value parameter
 fun test() {
     class Test{
         operator fun contains(a: Int=1, b: Int=2) : Boolean = true

idea/testData/intentions/conventionNameCalls/replaceContains/multipleArguments.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have a single value parameter
 fun test() {
     class Test{
         operator fun contains(a: Int, b: Int) : Boolean = true

idea/testData/intentions/conventionNameCalls/replaceContains/unacceptableVararg1.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have a single value parameter
 fun test() {
     class Test{
         operator fun contains(vararg b: Int, c: Int = 0): Boolean = true

idea/testData/intentions/conventionNameCalls/replaceContains/unacceptableVararg2.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have a single value parameter
 fun test() {
     class Test{
         operator fun contains(vararg b: Int, c: Int = 0): Boolean = true

idea/testData/intentions/conventionNameCalls/replaceContains/validNamedArgument.kt

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun contains(a: Int=1, b: Int=2) : Boolean = true
-    }
-    val test = Test()
-    test.c<caret>ontains(a=5)
-}

idea/testData/intentions/conventionNameCalls/replaceContains/validNamedArgument.kt.after

@@ -1,7 +0,0 @@
-fun test() {
-    class Test{
-        operator fun contains(a: Int=1, b: Int=2) : Boolean = true
-    }
-    val test = Test()
-    5 in test
-}

idea/testData/intentions/conventionNameCalls/replaceGetOrSet/noArgument.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have at least 1 value parameter
 fun test() {
     class Test{
         operator fun get() : Int = 0

idea/testData/intentions/conventionNameCalls/replaceGetOrSet/setWithNoParameters.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must have at least 2 value parameters
 
 class C {
     operator fun set(){}

idea/testData/intentions/conventionNameCalls/replaceGetOrSet/setWithVararg.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: last parameter must not have a default value or be a vararg
 
 class C {
     operator fun set(s: String, vararg value: Int): Boolean = true

idea/testData/intentions/conventionNameCalls/replaceGetOrSet/topLevelFun.kt

@@ -1,4 +1,6 @@
 // IS_APPLICABLE: false
+// ERROR: operator modifier is inapplicable on this function: must be a member or an extension
+
 package p
 
 operator fun get(s: String) = s

idea/testData/intentions/toInfixCall/multipleArguments.kt

@@ -1,5 +1,5 @@
 // IS_APPLICABLE: false
-// WARNING: 'infix' modifier is inapplicable on this function
+// ERROR: 'infix' modifier is inapplicable on this function
 interface Foo {
     infix fun foo(a: Int, b: Int)
 }

idea/testData/intentions/toInfixCall/namedArgument.kt

@@ -1,4 +1,5 @@
 // IS_APPLICABLE: false
+// ERROR: 'infix' modifier is inapplicable on this function
 fun foo(x: Foo) {
     x.<caret>foo(bar = x)
 }

idea/testData/intentions/toInfixCall/packageFunctionCall.kt

@@ -1,5 +1,5 @@
 // IS_APPLICABLE: false
-// WARNING: 'infix' modifier is inapplicable on this function
+// ERROR: 'infix' modifier is inapplicable on this function
 package ppp
 
 infix fun foo(p: String){}

idea/testData/intentions/toInfixCall/secondParameterLabeled.kt

@@ -1,4 +1,6 @@
 // IS_APPLICABLE: false
+// ERROR: 'infix' modifier is inapplicable on this function
+
 class Foo {
     infix fun foo(x: Int = 0, y: Int = 0) {
     }

idea/testData/intentions/toInfixCall/simpleArgumentAndFunctionLiteralArgument.kt

@@ -1,5 +1,5 @@
 // IS_APPLICABLE: false
-// WARNING: 'infix' modifier is inapplicable on this function
+// ERROR: 'infix' modifier is inapplicable on this function
 
 fun foo(x: Foo) {
     x.<caret>foo(1) { it * 2 }

idea/testData/intentions/toInfixCall/singlePackageFunctionCall.kt

@@ -1,6 +1,6 @@
 // WITH_RUNTIME
 // IS_APPLICABLE: false
-// WARNING: 'infix' modifier is inapplicable on this function
+// ERROR: 'infix' modifier is inapplicable on this function
 
 package demo
 

idea/testData/quickfix/deprecatedSymbolUsage/infixCall.kt

@@ -1,4 +1,5 @@
 // "Replace with 'newFun(p, this)'" "true"
+// ERROR: 'infix' modifier is inapplicable on this function
 
 @Deprecated("", ReplaceWith("newFun(p, this)"))
 infix fun String.oldFun(p: Int) {

idea/testData/quickfix/deprecatedSymbolUsage/infixCall.kt.after

@@ -1,4 +1,5 @@
 // "Replace with 'newFun(p, this)'" "true"
+// ERROR: 'infix' modifier is inapplicable on this function
 
 @Deprecated("", ReplaceWith("newFun(p, this)"))
 infix fun String.oldFun(p: Int) {