Replace all throw error(...) with just error(...)

`throw` is not needed in this case, because `error(...)` already
  raises exception (so `throw` is unreachable). Also after previous
  commit compiler reports `UNREACHABLE_CODE` warning on such `throw`

compiler/frontend/src/org/jetbrains/kotlin/analyzer/AbstractResolverForProject.kt

@@ -292,7 +292,7 @@ private object DiagnoseUnknownModuleInfoReporter {
                             else -> errorInModulesResolver(message)
                         }
                     }
-                    else -> throw errorInModulesResolver(message)
+                    else -> errorInModulesResolver(message)
                 }
             }
             name.contains(ResolverForProject.resolverForScriptDependenciesName) -> errorInScriptDependenciesInfoResolver(message)

compiler/ir/backend.js/src/org/jetbrains/kotlin/ir/backend/js/lower/MoveBodilessDeclarationsToSeparatePlace.kt

@@ -134,7 +134,7 @@ fun validateIsExternal(packageFragment: IrPackageFragment) {
 fun validateNestedExternalDeclarations(declaration: IrDeclaration, isExternalTopLevel: Boolean) {
     fun IrPossiblyExternalDeclaration.checkExternal() {
         if (isExternal != isExternalTopLevel) {
-            throw error("isExternal validation failed for declaration ${declaration.render()}")
+            error("isExternal validation failed for declaration ${declaration.render()}")
         }
     }
 

compiler/psi/src/org/jetbrains/kotlin/psi/KtFile.kt

@@ -190,7 +190,7 @@ open class KtFile(viewProvider: FileViewProvider, val isCompiled: Boolean) :
             return stub
         }
 
-        throw error("Illegal stub for KtFile: type=${this.javaClass}, stub=${stub?.javaClass} name=$name")
+        error("Illegal stub for KtFile: type=${this.javaClass}, stub=${stub?.javaClass} name=$name")
     }
 
     override fun getClasses(): Array<PsiClass> {