Introduce inspection: "Setter backing field should be assigned"

#KT-20273 Fixed
This commit is contained in:
Toshiaki Kameyama
2018-10-09 13:35:18 +03:00
committed by Mikhail Glukhikh
parent 784d9f14f6
commit 3ede93df11
21 changed files with 293 additions and 0 deletions
@@ -0,0 +1 @@
org.jetbrains.kotlin.idea.inspections.SetterBackingFieldAssignmentInspection
@@ -0,0 +1,10 @@
// PROBLEM: none
class Test {
var foo: Int = 1
<caret>set(value) {
bar()
field = value
}
fun bar() {}
}
@@ -0,0 +1,7 @@
// PROBLEM: none
class Test {
var foo: Int = 10
<caret>set(value) {
field--
}
}
@@ -0,0 +1,7 @@
// PROBLEM: none
class Test {
var foo: Int = 10
<caret>set(value) {
--field
}
}
@@ -0,0 +1,7 @@
// PROBLEM: none
class Test {
var foo: Int = 10
<caret>set(value) {
field /= value
}
}
@@ -0,0 +1,9 @@
// PROBLEM: none
class Test {
var foo: Int = 10
<caret>set(value) {
bar(value)
}
fun bar(value: Int) {}
}
@@ -0,0 +1,7 @@
// PROBLEM: none
class Test {
var foo: Int = 10
<caret>set(value) {
field++
}
}
@@ -0,0 +1,7 @@
// PROBLEM: none
class Test {
var foo: Int = 10
<caret>set(value) {
++field
}
}
@@ -0,0 +1,7 @@
// PROBLEM: none
class Test {
var foo: Int = 10
<caret>set(value) {
field -= value
}
}
@@ -0,0 +1,7 @@
// PROBLEM: none
class Test {
var foo: Int = 10
<caret>set(value) {
field %= value
}
}
@@ -0,0 +1,5 @@
class Test {
var foo: Int = 1
<caret>set(value) {
}
}
@@ -0,0 +1,6 @@
class Test {
var foo: Int = 1
set(value) {
field = value
}
}
@@ -0,0 +1,8 @@
class Test {
var foo: Int = 1
<caret>set(value) {
bar(field)
}
fun bar(i: Int) {}
}
@@ -0,0 +1,9 @@
class Test {
var foo: Int = 1
set(value) {
bar(field)
field = value
}
fun bar(i: Int) {}
}
@@ -0,0 +1,7 @@
// PROBLEM: none
class Test {
var foo: Int
get() = 1
<caret>set(value) {
}
}
@@ -0,0 +1,7 @@
// PROBLEM: none
class Test {
var foo: Int = 10
<caret>set(value) {
field += value
}
}
@@ -0,0 +1,7 @@
// PROBLEM: none
class Test {
var foo: Int = 10
<caret>set(value) {
field *= value
}
}