K2: remove dependency fir-deserialization -> compiler.common.jvm
- Rename DeserializedClassConfigurator -> FirDeserializationExtension to abstract the existing behavior (about the Serializable supertype), as well as any future JVM-specific deserialization behavior. - Rename JvmDeserializedClassConfigurator -> FirJvmDeserializationExtension and move it to fir:java.
This commit is contained in:
committed by
Space Team
parent
6943d03883
commit
3e313bca78
@@ -9,7 +9,6 @@ dependencies {
|
||||
implementation(project(":core:deserialization.common"))
|
||||
implementation(project(":core:deserialization.common.jvm"))
|
||||
implementation(project(":core:compiler.common"))
|
||||
implementation(project(":core:compiler.common.jvm"))
|
||||
|
||||
api(project(":compiler:fir:cones"))
|
||||
api(project(":compiler:fir:tree"))
|
||||
|
||||
+7
-33
@@ -5,7 +5,6 @@
|
||||
|
||||
package org.jetbrains.kotlin.fir.deserialization
|
||||
|
||||
import org.jetbrains.kotlin.builtins.jvm.JvmBuiltInsSignatures
|
||||
import org.jetbrains.kotlin.descriptors.ClassKind
|
||||
import org.jetbrains.kotlin.descriptors.EffectiveVisibility
|
||||
import org.jetbrains.kotlin.descriptors.Modality
|
||||
@@ -37,7 +36,10 @@ import org.jetbrains.kotlin.metadata.ProtoBuf
|
||||
import org.jetbrains.kotlin.metadata.SerializationPluginMetadataExtensions
|
||||
import org.jetbrains.kotlin.metadata.deserialization.*
|
||||
import org.jetbrains.kotlin.metadata.jvm.JvmProtoBuf
|
||||
import org.jetbrains.kotlin.name.*
|
||||
import org.jetbrains.kotlin.name.CallableId
|
||||
import org.jetbrains.kotlin.name.ClassId
|
||||
import org.jetbrains.kotlin.name.Name
|
||||
import org.jetbrains.kotlin.name.StandardClassIds
|
||||
import org.jetbrains.kotlin.serialization.SerializerExtensionProtocol
|
||||
import org.jetbrains.kotlin.serialization.deserialization.ProtoEnumFlags
|
||||
import org.jetbrains.kotlin.serialization.deserialization.descriptors.DeserializedContainerSource
|
||||
@@ -203,8 +205,8 @@ fun deserializeClassToSymbol(
|
||||
}
|
||||
|
||||
addCloneForArrayIfNeeded(classId, context.dispatchReceiver, session)
|
||||
session.deserializedClassConfigurator?.run {
|
||||
configure(classId)
|
||||
session.deserializationExtension?.run {
|
||||
configureDeserializedClass(classId)
|
||||
}
|
||||
|
||||
companionObjectSymbol = (declarations.firstOrNull { it is FirRegularClass && it.isCompanion } as FirRegularClass?)?.symbol
|
||||
@@ -237,9 +239,6 @@ fun deserializeClassToSymbol(
|
||||
classProto.getExtensionOrNull(JvmProtoBuf.classModuleName)?.let { idx ->
|
||||
moduleName = nameResolver.getString(idx)
|
||||
}
|
||||
session.deserializedClassConfigurator?.run {
|
||||
configure(classId)
|
||||
}
|
||||
|
||||
if (!Flags.HAS_ENUM_ENTRIES.get(flags)) {
|
||||
hasNoEnumEntriesAttr = true
|
||||
@@ -262,19 +261,6 @@ private val ARRAY_CLASSES: Set<Name> = setOf(
|
||||
Name.identifier("BooleanArray"),
|
||||
)
|
||||
|
||||
private val JAVA_IO_SERIALIZABLE = ClassId.topLevel(FqName("java.io.Serializable"))
|
||||
|
||||
private fun FirRegularClassBuilder.addSerializableIfNeeded(classId: ClassId) {
|
||||
if (!JvmBuiltInsSignatures.isSerializableInJava(classId.asSingleFqName().toUnsafe())) return
|
||||
superTypeRefs += buildResolvedTypeRef {
|
||||
type = ConeClassLikeTypeImpl(
|
||||
JAVA_IO_SERIALIZABLE.toLookupTag(),
|
||||
typeArguments = emptyArray(),
|
||||
isNullable = false
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
fun FirRegularClassBuilder.addCloneForArrayIfNeeded(classId: ClassId, dispatchReceiver: ConeClassLikeType?, session: FirSession) {
|
||||
if (classId.packageFqName != StandardClassIds.BASE_KOTLIN_PACKAGE) return
|
||||
if (classId.shortClassName !in ARRAY_CLASSES) return
|
||||
@@ -315,18 +301,6 @@ fun FirRegularClassBuilder.addCloneForArrayIfNeeded(classId: ClassId, dispatchRe
|
||||
}
|
||||
}
|
||||
|
||||
abstract class DeserializedClassConfigurator(val session: FirSession) : FirSessionComponent {
|
||||
open fun FirRegularClassBuilder.configure(classId: ClassId) {}
|
||||
|
||||
open fun FirRegularClass.configure(classId: ClassId) {}
|
||||
}
|
||||
|
||||
class JvmDeserializedClassConfigurator(session: FirSession) : DeserializedClassConfigurator(session) {
|
||||
override fun FirRegularClassBuilder.configure(classId: ClassId) {
|
||||
addSerializableIfNeeded(classId)
|
||||
}
|
||||
}
|
||||
|
||||
private fun ProtoBuf.ClassOrBuilder.propertiesInOrder(context: FirDeserializationContext): List<ProtoBuf.Property> {
|
||||
val properties = propertyList
|
||||
val versionRequirements = VersionRequirement.create(this, context.nameResolver, context.versionRequirementTable)
|
||||
@@ -345,4 +319,4 @@ private fun ProtoBuf.ClassOrBuilder.propertiesInOrder(context: FirDeserializatio
|
||||
}
|
||||
}
|
||||
|
||||
val FirSession.deserializedClassConfigurator: DeserializedClassConfigurator? by FirSession.nullableSessionComponentAccessor()
|
||||
val FirSession.deserializationExtension: FirDeserializationExtension? by FirSession.nullableSessionComponentAccessor()
|
||||
|
||||
+15
@@ -0,0 +1,15 @@
|
||||
/*
|
||||
* Copyright 2010-2023 JetBrains s.r.o. and Kotlin Programming Language contributors.
|
||||
* Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
|
||||
*/
|
||||
|
||||
package org.jetbrains.kotlin.fir.deserialization
|
||||
|
||||
import org.jetbrains.kotlin.fir.FirSession
|
||||
import org.jetbrains.kotlin.fir.FirSessionComponent
|
||||
import org.jetbrains.kotlin.fir.declarations.builder.FirRegularClassBuilder
|
||||
import org.jetbrains.kotlin.name.ClassId
|
||||
|
||||
abstract class FirDeserializationExtension(val session: FirSession) : FirSessionComponent {
|
||||
open fun FirRegularClassBuilder.configureDeserializedClass(classId: ClassId) {}
|
||||
}
|
||||
Reference in New Issue
Block a user