Fail on compilation errors in AbstractBytecodeTextTest

compiler/testData/codegen/bytecodeText/inlineClasses/propertyAccessorsAreCalledByInlineClass.kt

@@ -1,6 +1,7 @@
 // !LANGUAGE: +InlineClasses
 
 // FILE: Z.kt
+@Suppress("RESERVED_VAR_PROPERTY_OF_VALUE_CLASS")
 inline class Z(val x: Int) {
     val aVal: Int
         get() = x

compiler/testData/codegen/bytecodeText/mangling/parenthesesNoSanitize.kt

@@ -1,3 +1,4 @@
+// IGNORE_DEXING
 class `(X)` {
     fun `(Y)`() {}
 }

compiler/testData/codegen/bytecodeText/parameterlessMain/dontGenerateOnJvmOverloads.kt

@@ -1,3 +1,4 @@
+// IGNORE_BACKEND: JVM
 fun main() {
   println("FAIL")
 }

compiler/testData/codegen/bytecodeText/statements/labeled.kt

@@ -1,3 +1,5 @@
+// IGNORE_BACKEND_FIR: JVM_IR
+
 fun main()
 {
     l@ if (2 != 1) "fail 3"

compiler/testData/codegen/bytecodeText/whenEnumOptimization/whenOr.kt

@@ -1,7 +1,7 @@
 // IGNORE_BACKEND: JVM
 
 fun test(x: Int): String {
-    when {
+    return when {
         x == 1 || x == 3 || x == 5 -> "135"
         x == 2 || x == 4 || x == 6 -> "246"
         else -> "other"

compiler/tests-common-new/tests/org/jetbrains/kotlin/test/runners/codegen/AbstractBytecodeTextTest.kt

@@ -10,6 +10,8 @@ import org.jetbrains.kotlin.test.TargetBackend
 import org.jetbrains.kotlin.test.backend.BlackBoxCodegenSuppressor
 import org.jetbrains.kotlin.test.backend.classic.ClassicJvmBackendFacade
 import org.jetbrains.kotlin.test.backend.handlers.BytecodeTextHandler
+import org.jetbrains.kotlin.test.backend.handlers.NoCompilationErrorsHandler
+import org.jetbrains.kotlin.test.backend.handlers.NoFirCompilationErrorsHandler
 import org.jetbrains.kotlin.test.backend.ir.JvmIrBackendFacade
 import org.jetbrains.kotlin.test.builders.TestConfigurationBuilder
 import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives
@@ -42,6 +44,8 @@ abstract class AbstractBytecodeTextTestBase<R : ResultingArtifact.FrontendOutput
             +WITH_REFLECT
         }
 
+       commonHandlersForCodegenTest()
+
         useArtifactsHandlers(::BytecodeTextHandler)
 
         useAfterAnalysisCheckers(::BlackBoxCodegenSuppressor)

compiler/tests-common-new/tests/org/jetbrains/kotlin/test/runners/codegen/AbstractCompileKotlinAgainstInlineKotlinTest.kt

@@ -40,7 +40,7 @@ abstract class AbstractCompileKotlinAgainstInlineKotlinTestBase<I : ResultingArt
             backendFacade
         )
         useInlineHandlers()
-        commonHandlersForCodegenTest()
+        commonHandlersForBoxTest()
         useModuleStructureTransformers(
             ModuleTransformerForTwoFilesBoxTests()
         )

compiler/tests-common-new/tests/org/jetbrains/kotlin/test/runners/codegen/AbstractCompileKotlinAgainstKotlinWithDifferentBackendsTest.kt

@@ -19,7 +19,6 @@ import org.jetbrains.kotlin.test.frontend.classic.ClassicFrontend2IrConverter
 import org.jetbrains.kotlin.test.frontend.classic.ClassicFrontendFacade
 import org.jetbrains.kotlin.test.model.FrontendKinds
 import org.jetbrains.kotlin.test.runners.AbstractKotlinCompilerWithTargetBackendTest
-import org.jetbrains.kotlin.test.runners.codegen.commonConfigurationForCodegenTest
 import org.jetbrains.kotlin.test.services.ModuleTransformerForSwitchingBackend
 
 @OptIn(TestInfrastructureInternals::class)
@@ -37,7 +36,7 @@ abstract class AbstractJvmIrAgainstOldBoxTestBase(targetBackend: TargetBackend)
             ::ClassicJvmBackendFacade
         )
 
-        commonHandlersForCodegenTest()
+        commonHandlersForBoxTest()
 
         useFrontend2BackendConverters(::ClassicFrontend2IrConverter)
         useBackendFacades(::JvmIrBackendFacade)

compiler/tests-common-new/tests/org/jetbrains/kotlin/test/runners/codegen/AbstractJvmBlackBoxCodegenTestBase.kt

@@ -23,7 +23,7 @@ abstract class AbstractJvmBlackBoxCodegenTestBase<R : ResultingArtifact.Frontend
 
     override fun TestConfigurationBuilder.configuration() {
         commonConfigurationForCodegenTest(targetFrontend, frontendFacade, frontendToBackendConverter, backendFacade)
-        commonHandlersForCodegenTest()
+        commonHandlersForBoxTest()
         useArtifactsHandlers(::BytecodeListingHandler)
         useAfterAnalysisCheckers(::BlackBoxCodegenSuppressor)
     }

compiler/tests-common-new/tests/org/jetbrains/kotlin/test/runners/codegen/AbstractJvmIrAgainstOldBoxTest.kt

@@ -37,7 +37,7 @@ open class AbstractBackendAgainstBackendBoxTestBase(
         useFrontend2BackendConverters(::ClassicFrontend2IrConverter)
         useBackendFacades(::JvmIrBackendFacade)
 
-        commonHandlersForCodegenTest()
+        commonHandlersForBoxTest()
         useInlineHandlers()
 
         useAfterAnalysisCheckers(::BlackBoxCodegenSuppressor.bind(CodegenTestDirectives.IGNORE_BACKEND_MULTI_MODULE))

compiler/tests-common-new/tests/org/jetbrains/kotlin/test/runners/codegen/BaseCodegenConfiguration.kt

@@ -11,7 +11,6 @@ import org.jetbrains.kotlin.test.backend.handlers.*
 import org.jetbrains.kotlin.test.builders.TestConfigurationBuilder
 import org.jetbrains.kotlin.test.directives.CodegenTestDirectives.DUMP_SMAP
 import org.jetbrains.kotlin.test.directives.CodegenTestDirectives.RUN_DEX_CHECKER
-import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.USE_PSI_CLASS_FILES_READING
 import org.jetbrains.kotlin.test.model.*
 import org.jetbrains.kotlin.test.services.configuration.CommonEnvironmentConfigurator
 import org.jetbrains.kotlin.test.services.configuration.JvmEnvironmentConfigurator
@@ -51,6 +50,13 @@ fun <R : ResultingArtifact.FrontendOutput<R>> TestConfigurationBuilder.commonCon
     useBackendFacades(backendFacade)
 }
 
+fun TestConfigurationBuilder.commonHandlersForBoxTest() {
+    commonHandlersForCodegenTest()
+    useArtifactsHandlers(
+        ::JvmBoxRunner
+    )
+}
+
 fun TestConfigurationBuilder.commonHandlersForCodegenTest() {
     useFrontendHandlers(
         ::NoCompilationErrorsHandler,
@@ -58,7 +64,6 @@ fun TestConfigurationBuilder.commonHandlersForCodegenTest() {
     )
 
     useArtifactsHandlers(
-        ::JvmBoxRunner,
         ::NoJvmSpecificCompilationErrorsHandler,
         ::DxCheckerHandler,
     )