[FIR] drop redundant receiver copy

^KT-54417

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/inference/FirCallCompleter.kt

@@ -309,8 +309,8 @@ class FirCallCompleter(
             lambdaArgument.replaceReceiverParameter(
                 lambdaArgument.receiverParameter?.let { receiverParameter ->
                     receiverType?.approximateLambdaInputType()?.let { approximatedType ->
-                        buildReceiverParameterCopy(receiverParameter) {
+                        receiverParameter.apply {
-                            type = receiverParameter.type.resolvedTypeFromPrototype(approximatedType)
+                            replaceType(type.resolvedTypeFromPrototype(approximatedType))
                         }
                     }
                 }

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/transformers/FirCallCompletionResultsWriterTransformer.kt

@@ -618,11 +618,7 @@ class FirCallCompletionResultsWriterTransformer(
         val initialReceiverType = receiverParameter?.type?.coneTypeSafe<ConeKotlinType>()
         val resultReceiverType = initialReceiverType?.let { finalSubstitutor.substituteOrNull(it) }
         if (resultReceiverType != null) {
-            anonymousFunction.replaceReceiverParameter(
+            receiverParameter.replaceType(receiverParameter.type.resolvedTypeFromPrototype(resultReceiverType))
-                buildReceiverParameterCopy(receiverParameter) {
-                    type = receiverParameter.type.resolvedTypeFromPrototype(resultReceiverType)
-                }
-            )
             needUpdateLambdaType = true
         }
 

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/transformers/body/resolve/FirDeclarationsResolveTransformer.kt

@@ -813,15 +813,12 @@ open class FirDeclarationsResolveTransformer(transformer: FirAbstractBodyResolve
             resolvedLambdaAtom != null -> obtainValueParametersFromResolvedLambdaAtom(resolvedLambdaAtom, lambda)
             else -> lambda.valueParameters
         }
-        val returnTypeRefFromResolvedAtom =
+        val returnTypeRefFromResolvedAtom = resolvedLambdaAtom?.returnType?.let { lambda.returnTypeRef.resolvedTypeFromPrototype(it) }
-            resolvedLambdaAtom?.returnType?.let { lambda.returnTypeRef.resolvedTypeFromPrototype(it) }
         lambda = buildAnonymousFunctionCopy(lambda) {
             receiverParameter = lambda.receiverParameter?.takeIf { it.type !is FirImplicitTypeRef }
                 ?: resolvedLambdaAtom?.receiver?.let { coneKotlinType ->
-                    lambda.receiverParameter?.let {
+                    lambda.receiverParameter?.apply {
-                        buildReceiverParameterCopy(it) {
+                        replaceType(type.resolvedTypeFromPrototype(coneKotlinType))
-                            type = it.type.resolvedTypeFromPrototype(coneKotlinType)
-                        }
                     }
                 }
 

compiler/fir/tree/gen/org/jetbrains/kotlin/fir/declarations/FirReceiverParameter.kt

@@ -29,6 +29,8 @@ abstract class FirReceiverParameter : FirPureAbstractElement(), FirAnnotationCon
     override fun <E: FirElement, D> transform(transformer: FirTransformer<D>, data: D): E = 
         transformer.transformReceiverParameter(this, data) as E
 
+    abstract fun replaceType(newType: FirTypeRef)
+
     abstract fun <D> transformType(transformer: FirTransformer<D>, data: D): FirReceiverParameter
 
     abstract override fun <D> transformAnnotations(transformer: FirTransformer<D>, data: D): FirReceiverParameter

compiler/fir/tree/gen/org/jetbrains/kotlin/fir/declarations/impl/FirReceiverParameterImpl.kt

@@ -43,4 +43,8 @@ internal class FirReceiverParameterImpl(
         annotations.transformInplace(transformer, data)
         return this
     }
+
+    override fun replaceType(newType: FirTypeRef) {
+        type = newType
+    }
 }

compiler/fir/tree/tree-generator/src/org/jetbrains/kotlin/fir/tree/generator/NodeConfigurator.kt

@@ -394,7 +394,7 @@ object NodeConfigurator : AbstractFieldConfigurator<FirTreeBuilder>(FirTreeBuild
         }
 
         receiverParameter.configure {
-            +field("type", typeRef).withTransform()
+            +field("type", typeRef).withTransform().withReplace()
             +annotations
         }