[AA] make consistent hasStableParameterNames for setter and getter

^KT-54311

analysis/analysis-api-fe10/src/org/jetbrains/kotlin/analysis/api/descriptors/symbols/descriptorBased/KtFe10DescPropertyGetterSymbol.kt

@@ -39,7 +39,7 @@ internal class KtFe10DescPropertyGetterSymbol(
         get() = withValidityAssertion { descriptor.valueParameters.map { KtFe10DescValueParameterSymbol(it, analysisContext) } }
 
     override val hasStableParameterNames: Boolean
-        get() = withValidityAssertion { descriptor.ktHasStableParameterNames }
+        get() = withValidityAssertion { true }
 
     override val callableIdIfNonLocal: CallableId?
         get() = withValidityAssertion { descriptor.correspondingProperty.getterCallableIdIfNotLocal }

analysis/analysis-api-fe10/src/org/jetbrains/kotlin/analysis/api/descriptors/symbols/descriptorBased/KtFe10DescPropertySetterSymbol.kt

@@ -41,7 +41,7 @@ internal class KtFe10DescPropertySetterSymbol(
         get() = withValidityAssertion { descriptor.valueParameters.map { KtFe10DescValueParameterSymbol(it, analysisContext) } }
 
     override val hasStableParameterNames: Boolean
-        get() = withValidityAssertion { descriptor.ktHasStableParameterNames }
+        get() = withValidityAssertion { true }
 
     override val callableIdIfNonLocal: CallableId?
         get() = withValidityAssertion { descriptor.correspondingProperty.setterCallableIdIfNotLocal }

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/symbols/KtFirPropertyGetterSymbol.kt

@@ -72,7 +72,7 @@ internal class KtFirPropertyGetterSymbol(
     override val valueParameters: List<KtValueParameterSymbol> get() = withValidityAssertion { emptyList() }
 
     override val hasStableParameterNames: Boolean
-        get() = withValidityAssertion { firSymbol.fir.getHasStableParameterNames(firSymbol.moduleData.session) }
+        get() = withValidityAssertion { true }
 
     override fun createPointer(): KtSymbolPointer<KtPropertyGetterSymbol> = withValidityAssertion {
         KtPsiBasedSymbolPointer.createForSymbolFromSource(this)?.let { return it }

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/symbols/KtFirPropertySetterSymbol.kt

@@ -95,7 +95,7 @@ internal class KtFirPropertySetterSymbol(
 
 
     override val hasStableParameterNames: Boolean
-        get() = withValidityAssertion { firSymbol.fir.getHasStableParameterNames(firSymbol.moduleData.session) }
+        get() = withValidityAssertion { true }
 
     override fun createPointer(): KtSymbolPointer<KtPropertySetterSymbol> = withValidityAssertion {
         KtPsiBasedSymbolPointer.createForSymbolFromSource(this)?.let { return it }

analysis/analysis-api/testData/scopes/delegatedMemberScope/propertyWithGetter.descriptors.txt

@@ -7,7 +7,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: false
     isExtension: false
     isInline: false

analysis/analysis-api/testData/scopes/delegatedMemberScope/simple.descriptors.txt

@@ -7,7 +7,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -42,7 +42,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -164,7 +164,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -215,7 +215,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -250,7 +250,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -318,7 +318,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false

analysis/analysis-api/testData/scopes/fileScopeTest/fileScope.descriptors.txt

@@ -91,7 +91,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -141,7 +141,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -176,7 +176,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -243,7 +243,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -278,7 +278,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -345,7 +345,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -380,7 +380,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -447,7 +447,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: true
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: false
     isExtension: false
     isInline: false
@@ -482,7 +482,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -549,7 +549,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -587,7 +587,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: false
     isExtension: false
     isInline: false
@@ -654,7 +654,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -692,7 +692,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: false
     isExtension: false
     isInline: false
@@ -762,7 +762,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: true
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: false
     isExtension: false
     isInline: false
@@ -815,7 +815,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: true
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: false
     isExtension: false
     isInline: false
@@ -865,7 +865,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: true
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: false
     isExtension: false
     isInline: false
@@ -915,7 +915,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: true
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: false
     isExtension: false
     isInline: false
@@ -967,7 +967,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -1017,7 +1017,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false
@@ -1052,7 +1052,7 @@ KtKotlinPropertySymbol:
     callableIdIfNonLocal: null
     contextReceivers: []
     hasBody: false
-    hasStableParameterNames: false
+    hasStableParameterNames: true
     isDefault: true
     isExtension: false
     isInline: false

analysis/analysis-api/testData/scopes/fileScopeTest/simpleFileScope.descriptors.txt

@@ -1,136 +0,0 @@
-FILE SYMBOL:
-KtFileSymbol:
-  annotationsList: []
-  origin: SOURCE
-  getContainingModule: KtSourceModule "Sources of main"
-  deprecationStatus: null
-
-CALLABLE NAMES:
-[test, testVal]
-
-CALLABLE SYMBOLS:
-KtFunctionSymbol:
-  annotationsList: []
-  callableIdIfNonLocal: /test
-  contextReceivers: []
-  hasStableParameterNames: true
-  isBuiltinFunctionInvoke: false
-  isExtension: false
-  isExternal: false
-  isInfix: false
-  isInline: false
-  isOperator: false
-  isOverride: false
-  isStatic: false
-  isSuspend: false
-  modality: FINAL
-  name: test
-  origin: SOURCE
-  receiverType: null
-  returnType: kotlin/Int
-  symbolKind: TOP_LEVEL
-  typeParameters: []
-  valueParameters: []
-  visibility: Public
-  getContainingModule: KtSourceModule "Sources of main"
-  deprecationStatus: null
-
-KtKotlinPropertySymbol:
-  annotationsList: []
-  callableIdIfNonLocal: /testVal
-  contextReceivers: []
-  getter: KtPropertyGetterSymbol:
-    annotationsList: []
-    callableIdIfNonLocal: null
-    contextReceivers: []
-    hasBody: false
-    hasStableParameterNames: false
-    isDefault: true
-    isExtension: false
-    isInline: false
-    isOverride: false
-    modality: FINAL
-    origin: SOURCE
-    receiverType: null
-    returnType: kotlin/Int
-    symbolKind: ACCESSOR
-    typeParameters: []
-    valueParameters: []
-    visibility: Public
-  hasBackingField: true
-  hasGetter: true
-  hasSetter: false
-  initializer: KtConstantInitializerValue(2)
-  isConst: false
-  isDelegatedProperty: false
-  isExtension: false
-  isFromPrimaryConstructor: false
-  isLateInit: false
-  isOverride: false
-  isStatic: false
-  isVal: true
-  modality: FINAL
-  name: testVal
-  origin: SOURCE
-  receiverType: null
-  returnType: kotlin/Int
-  setter: null
-  symbolKind: TOP_LEVEL
-  typeParameters: []
-  visibility: Public
-  getContainingModule: KtSourceModule "Sources of main"
-  deprecationStatus: null
-  getterDeprecationStatus: null
-  javaGetterName: getTestVal
-  javaSetterName: null
-  setterDeprecationStatus: null
-
-CLASSIFIER NAMES:
-[C, I]
-
-CLASSIFIER SYMBOLS:
-KtNamedClassOrObjectSymbol:
-  annotationsList: []
-  classIdIfNonLocal: C
-  classKind: CLASS
-  companionObject: null
-  contextReceivers: []
-  isData: false
-  isExternal: false
-  isFun: false
-  isInline: false
-  isInner: false
-  modality: FINAL
-  name: C
-  origin: SOURCE
-  superTypes: [
-    kotlin/Any
-  ]
-  symbolKind: TOP_LEVEL
-  typeParameters: []
-  visibility: Public
-  getContainingModule: KtSourceModule "Sources of main"
-  deprecationStatus: null
-
-KtNamedClassOrObjectSymbol:
-  annotationsList: []
-  classIdIfNonLocal: I
-  classKind: INTERFACE
-  companionObject: null
-  contextReceivers: []
-  isData: false
-  isExternal: false
-  isFun: false
-  isInline: false
-  isInner: false
-  modality: ABSTRACT
-  name: I
-  origin: SOURCE
-  superTypes: [
-    kotlin/Any
-  ]
-  symbolKind: TOP_LEVEL
-  typeParameters: []
-  visibility: Public
-  getContainingModule: KtSourceModule "Sources of main"
-  deprecationStatus: null

analysis/analysis-api/testData/symbols/symbolByPsi/annotations.descriptors.txt

@@ -11,7 +11,7 @@ KtValueParameterSymbol:
       callableIdIfNonLocal: null
       contextReceivers: []
       hasBody: false
-      hasStableParameterNames: false
+      hasStableParameterNames: true
       isDefault: true
       isExtension: false
       isInline: false
@@ -73,7 +73,7 @@ KtValueParameterSymbol:
       callableIdIfNonLocal: null
       contextReceivers: []
       hasBody: false
-      hasStableParameterNames: false
+      hasStableParameterNames: true
       isDefault: true
       isExtension: false
       isInline: false
@@ -149,7 +149,7 @@ KtConstructorSymbol:
           callableIdIfNonLocal: null
           contextReceivers: []
           hasBody: false
-          hasStableParameterNames: false
+          hasStableParameterNames: true
           isDefault: true
           isExtension: false
           isInline: false
@@ -208,7 +208,7 @@ KtConstructorSymbol:
           callableIdIfNonLocal: null
           contextReceivers: []
           hasBody: false
-          hasStableParameterNames: false
+          hasStableParameterNames: true
           isDefault: true
           isExtension: false
           isInline: false

analysis/analysis-api/testData/symbols/symbolByPsi/classPrimaryConstructor.descriptors.txt

@@ -11,7 +11,7 @@ KtValueParameterSymbol:
       callableIdIfNonLocal: null
       contextReceivers: []
       hasBody: false
-      hasStableParameterNames: false
+      hasStableParameterNames: true
       isDefault: true
       isExtension: false
       isInline: false
@@ -107,7 +107,7 @@ KtConstructorSymbol:
           callableIdIfNonLocal: null
           contextReceivers: []
           hasBody: false
-          hasStableParameterNames: false
+          hasStableParameterNames: true
           isDefault: true
           isExtension: false
           isInline: false

analysis/analysis-api/testData/symbols/symbolByPsi/delegateField.descriptors.txt

@@ -11,7 +11,7 @@ KtValueParameterSymbol:
       callableIdIfNonLocal: null
       contextReceivers: []
       hasBody: false
-      hasStableParameterNames: false
+      hasStableParameterNames: true
       isDefault: true
       isExtension: false
       isInline: false
@@ -73,7 +73,7 @@ KtValueParameterSymbol:
       callableIdIfNonLocal: null
       contextReceivers: []
       hasBody: false
-      hasStableParameterNames: false
+      hasStableParameterNames: true
       isDefault: true
       isExtension: false
       isInline: false
@@ -135,7 +135,7 @@ KtValueParameterSymbol:
       callableIdIfNonLocal: null
       contextReceivers: []
       hasBody: false
-      hasStableParameterNames: false
+      hasStableParameterNames: true
       isDefault: true
       isExtension: false
       isInline: false
@@ -211,7 +211,7 @@ KtConstructorSymbol:
           callableIdIfNonLocal: null
           contextReceivers: []
           hasBody: false
-          hasStableParameterNames: false
+          hasStableParameterNames: true
           isDefault: true
           isExtension: false
           isInline: false
@@ -270,7 +270,7 @@ KtConstructorSymbol:
           callableIdIfNonLocal: null
           contextReceivers: []
           hasBody: false
-          hasStableParameterNames: false
+          hasStableParameterNames: true
           isDefault: true
           isExtension: false
           isInline: false
@@ -329,7 +329,7 @@ KtConstructorSymbol:
           callableIdIfNonLocal: null
           contextReceivers: []
           hasBody: false
-          hasStableParameterNames: false
+          hasStableParameterNames: true
           isDefault: true
           isExtension: false
           isInline: false

analysis/analysis-api/testData/symbols/symbolByPsi/destructuringDeclaration.descriptors.txt

@@ -11,7 +11,7 @@ KtValueParameterSymbol:
       callableIdIfNonLocal: null
       contextReceivers: []
       hasBody: false
-      hasStableParameterNames: false
+      hasStableParameterNames: true
       isDefault: true
       isExtension: false
       isInline: false
@@ -73,7 +73,7 @@ KtValueParameterSymbol:
       callableIdIfNonLocal: null
       contextReceivers: []
       hasBody: false
-      hasStableParameterNames: false
+      hasStableParameterNames: true
       isDefault: true
       isExtension: false
       isInline: false
@@ -149,7 +149,7 @@ KtConstructorSymbol:
           callableIdIfNonLocal: null
           contextReceivers: []
           hasBody: false
-          hasStableParameterNames: false
+          hasStableParameterNames: true
           isDefault: true
           isExtension: false
           isInline: false
@@ -208,7 +208,7 @@ KtConstructorSymbol:
           callableIdIfNonLocal: null
           contextReceivers: []
           hasBody: false
-          hasStableParameterNames: false
+          hasStableParameterNames: true
           isDefault: true
           isExtension: false
           isInline: false

analysis/analysis-api/testData/symbols/symbolByPsi/enumValueMember.descriptors.txt

@@ -11,7 +11,7 @@ KtValueParameterSymbol:
       callableIdIfNonLocal: null
       contextReceivers: []
       hasBody: false
-      hasStableParameterNames: false
+      hasStableParameterNames: true
       isDefault: true
       isExtension: false
       isInline: false
@@ -87,7 +87,7 @@ KtConstructorSymbol:
           callableIdIfNonLocal: null
           contextReceivers: []
           hasBody: false
-          hasStableParameterNames: false
+          hasStableParameterNames: true
           isDefault: true
           isExtension: false
           isInline: false

analysis/analysis-api/testData/symbols/symbolByReference/accessorField.descriptors.txt

@@ -22,7 +22,7 @@ KtBackingFieldSymbol:
       callableIdIfNonLocal: null
       contextReceivers: []
       hasBody: true
-      hasStableParameterNames: false
+      hasStableParameterNames: true
       isDefault: false
       isExtension: false
       isInline: false
@@ -62,7 +62,7 @@ KtBackingFieldSymbol:
       callableIdIfNonLocal: null
       contextReceivers: []
       hasBody: true
-      hasStableParameterNames: false
+      hasStableParameterNames: true
       isDefault: false
       isExtension: false
       isInline: false