[FIR] Report CANNOT_CHECK_FOR_ERASED independent of reified parameters

This changes the logic so that Foo<T> is reported no matter if T is
reified or not. Even for Array<reified T> to align K2 with K1 logic.

#KT-55903 Fixed

compiler/testData/diagnostics/tests/cast/IsErasedUpcastToNonReified.fir.kt

@@ -15,10 +15,25 @@ fun <T, S : T> test(x: T?, y: S, z: T) {
     null <!UNCHECKED_CAST!>as S<!>
 }
 
-inline fun <reified T> test(x: T?) {
+class Box<T>
+
+inline fun <reified T> test(x: T?, a: Any) {
     x is T
     null as T
     null as T?
+
+    a is T
+    a as T
+
+    a is <!CANNOT_CHECK_FOR_ERASED!>Box<T><!>
+    a is <!CANNOT_CHECK_FOR_ERASED!>Array<T><!>
+    a <!UNCHECKED_CAST!>as Box<T><!>
+    a <!UNCHECKED_CAST!>as Array<T><!>
+
+    a is <!CANNOT_CHECK_FOR_ERASED!>Box<List<T>><!>
+    a is <!CANNOT_CHECK_FOR_ERASED!>Array<List<T>><!>
+    a <!UNCHECKED_CAST!>as Box<List<T>><!>
+    a <!UNCHECKED_CAST!>as Array<List<T>><!>
 }
 
 fun <T> foo(x: List<T>, y: List<T>?) {

compiler/testData/diagnostics/tests/cast/IsErasedUpcastToNonReified.kt

@@ -15,13 +15,28 @@ fun <T, S : T> test(x: T?, y: S, z: T) {
     null <!UNCHECKED_CAST!>as S<!>
 }
 
-inline fun <reified T> test(x: T?) {
+class Box<T>
+
+inline fun <reified T> test(x: T?, a: Any) {
     x is T
     null as T
     null <!USELESS_CAST!>as T?<!>
+
+    a is T
+    a as T
+
+    a is <!CANNOT_CHECK_FOR_ERASED!>Box<T><!>
+    a is <!CANNOT_CHECK_FOR_ERASED!>Array<T><!>
+    a <!UNCHECKED_CAST!>as Box<T><!>
+    a <!UNCHECKED_CAST!>as Array<T><!>
+
+    a is <!CANNOT_CHECK_FOR_ERASED!>Box<List<T>><!>
+    a is <!CANNOT_CHECK_FOR_ERASED!>Array<List<T>><!>
+    a <!UNCHECKED_CAST!>as Box<List<T>><!>
+    a <!UNCHECKED_CAST!>as Array<List<T>><!>
 }
 
 fun <T> foo(x: List<T>, y: List<T>?) {
     <!USELESS_IS_CHECK!>x is List<T><!>
     y is List<T>
-}
+}

compiler/testData/diagnostics/tests/cast/IsErasedUpcastToNonReified.txt

@@ -1,5 +1,13 @@
 package
 
 public fun </*0*/ T> foo(/*0*/ x: kotlin.collections.List<T>, /*1*/ y: kotlin.collections.List<T>?): kotlin.Unit
-public inline fun </*0*/ reified T> test(/*0*/ x: T?): kotlin.Unit
 public fun </*0*/ T, /*1*/ S : T> test(/*0*/ x: T?, /*1*/ y: S, /*2*/ z: T): kotlin.Unit
+public inline fun </*0*/ reified T> test(/*0*/ x: T?, /*1*/ a: kotlin.Any): kotlin.Unit
+
+public final class Box</*0*/ T> {
+    public constructor Box</*0*/ T>()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+