Fix warnings in stdlib samples and test modules

libraries/stdlib/test/collections/ArraysTest.kt

@@ -1470,7 +1470,8 @@ class ArraysTest {
         doTest(build = { map {'a' + it}.toCharArray() },        reverse = { reverse() }, snapshot = { toList() })
         doTest(build = { map {it % 2 == 0}.toBooleanArray() },  reverse = { reverse() }, snapshot = { toList() })
         doTest(build = { map {it.toString()}.toTypedArray() },  reverse = { reverse() }, snapshot = { toList() })
-        doTest(build = { map {it.toString()}.toTypedArray() as Array<out String> },  reverse = { reverse() }, snapshot = { toList() })
+        @Suppress("USELESS_CAST")
+        doTest(build = { map {it.toString()}.toTypedArray() as Array<out String> }, reverse = { reverse() }, snapshot = { toList() })
         doTest(build = { map {it.toUInt()}.toUIntArray() },     reverse = { reverse() }, snapshot = { toList() })
         doTest(build = { map {it.toULong()}.toULongArray() },   reverse = { reverse() }, snapshot = { toList() })
         doTest(build = { map {it.toUByte()}.toUByteArray() },   reverse = { reverse() }, snapshot = { toList() })
@@ -1503,6 +1504,7 @@ class ArraysTest {
         }
 
         doTest(build = { map {it.toString()}.toTypedArray() },  reverse = { from, to -> reverse(from, to) }, snapshot = { toList() })
+        @Suppress("USELESS_CAST")
         doTest(build = { map {it.toString()}.toTypedArray() as Array<out String> },  reverse = { from, to -> reverse(from, to) }, snapshot = { toList() })
 
         doTest(build = { map {it}.toIntArray() },               reverse = { from, to -> reverse(from, to) }, snapshot = { toList() })
@@ -1928,6 +1930,7 @@ class ArraysTest {
         testStableSort({ sort(1, 5) }, { sort(1, 5) })
         testStableSort({ sort(0, 6) }, { sort(0, 6) })
         doTest(build = { map {it.toString()}.toTypedArray() }, sort = { from, to -> sort(from, to) }, snapshot = { toList() })
+        @Suppress("USELESS_CAST")
         doTest(build = { map {it.toString()}.toTypedArray() as Array<out String> }, sort = { from, to -> sort(from, to) }, snapshot = { toList() })
 
         doTest(build = { map {it}.toIntArray() }, sort = { from, to -> sort(from, to) }, snapshot = { toList() })
@@ -1971,6 +1974,7 @@ class ArraysTest {
         testStableSort({ sortDescending(1, 5) }, { sortDescending(1, 5) })
         testStableSort({ sortDescending(0, 6) }, { sortDescending(0, 6) })
         doTest(build = { map {it.toString()}.toTypedArray() }, sortDescending = { from, to -> sortDescending(from, to) }, snapshot = { toList() })
+        @Suppress("USELESS_CAST")
         doTest(build = { map {it.toString()}.toTypedArray() as Array<out String> }, sortDescending = { from, to -> sortDescending(from, to) }, snapshot = { toList() })
 
         doTest(build = { map {it}.toIntArray() }, sortDescending = { from, to -> sortDescending(from, to) }, snapshot = { toList() })
@@ -1997,6 +2001,7 @@ class ArraysTest {
             checkSorted<Array<String>>({ sortedArray() }, { sortedArrayDescending()}, { iterator() } )
         }
 
+        @Suppress("USELESS_CAST")
         with (arrayData("ac", "aD", "aba") { toList().toTypedArray() as Array<out String> }) {
             checkSorted<List<String>>({ sorted() }, { sortedDescending() }, { iterator() })
             checkSorted<Array<out String>>({ sortedArray() }, { sortedArrayDescending()}, { iterator() } )

libraries/stdlib/test/collections/MapTest.kt

@@ -463,7 +463,7 @@ class MapTest {
         doTest("HashMap", mapLetterToIndex.toMap(HashMap()), "c", 2)
         doTest("LinkedHashMap", mapLetterToIndex.toMap(LinkedHashMap()), "d", 3)
 
-        val builtMap = buildMap {
+        buildMap {
             putAll(mapLetterToIndex)
             doTest("MapBuilder", this, "z", 25)
         }
@@ -479,6 +479,7 @@ class MapTest {
         assertEquals("Alice", firstAdult)
         assertEquals("Alice", firstAdultOrNull)
 
+        @Suppress("UNUSED_VARIABLE")
         assertFailsWith<NoSuchElementException> { val firstChild = map.firstNotNullOf { (name, age) -> name.takeIf { age <= 11 } } }
         val firstChildOrNull = map.firstNotNullOfOrNull { (name, age) -> name.takeIf { age <= 11 } }
 

libraries/stdlib/test/numbers/FloorDivModTest.kt

@@ -171,7 +171,9 @@ class FloorDivModTest {
         }
 
         check(Long.MAX_VALUE, 2, Long.MAX_VALUE / 2, 1)
+        @Suppress("INTEGER_OPERATOR_RESOLVE_WILL_CHANGE") // KT-47729
         check(Long.MAX_VALUE, 1.shl(30), expectedMod = 1.shl(30) - 1)
+        @Suppress("INTEGER_OPERATOR_RESOLVE_WILL_CHANGE") // KT-47729
         check(-1L, 1.shl(30), expectedMod = 1.shl(30) - 1)
         check(Long.MAX_VALUE, Int.MAX_VALUE, expectedMod = 1)
         check(Long.MAX_VALUE, Int.MIN_VALUE, expectedMod = -1)
@@ -197,6 +199,7 @@ class FloorDivModTest {
 
         check(Short.MAX_VALUE, Int.MAX_VALUE, 0, Short.MAX_VALUE.toInt())
         check(Short.MAX_VALUE, Int.MIN_VALUE, -1, Int.MIN_VALUE + Short.MAX_VALUE)
+        @Suppress("INTEGER_OPERATOR_RESOLVE_WILL_CHANGE") // KT-47729
         check((-1).toShort(), 1.shl(30), -1, 1.shl(30) - 1)
     }
 

libraries/stdlib/test/numbers/NumbersTest.kt

@@ -48,7 +48,7 @@ class NumbersTest {
         // overflow behavior
         expect(Int.MIN_VALUE) { Int.MAX_VALUE + one }
         expect(Int.MAX_VALUE) { Int.MIN_VALUE - one }
-        expect(Int.MIN_VALUE) { Int.MIN_VALUE / -1 }
+        expect(Int.MIN_VALUE) { Int.MIN_VALUE / -one }
         expect(0) { (Int.MIN_VALUE % -1) + 0 } // +0 is a workaround for KT-45620
     }
 
@@ -62,7 +62,7 @@ class NumbersTest {
         // overflow behavior
         expect(Long.MIN_VALUE) { Long.MAX_VALUE + one }
         expect(Long.MAX_VALUE) { Long.MIN_VALUE - one }
-        expect(Long.MIN_VALUE) { Long.MIN_VALUE / -1L }
+        expect(Long.MIN_VALUE) { Long.MIN_VALUE / -one }
         expect(0L) { Long.MIN_VALUE % -1L }
     }
 

libraries/stdlib/test/utils/TODOTest.kt

@@ -10,6 +10,7 @@ import kotlin.test.*
 class TODOTest {
     private class PartiallyImplementedClass {
         public val prop: String get() = TODO()
+
         @Suppress("UNREACHABLE_CODE", "CAST_NEVER_SUCCEEDS")
         fun method1() = TODO() as String
 
@@ -20,6 +21,7 @@ class TODOTest {
                 TODO("what if false")
             else {
                 if (value.length < 3)
+                    @Suppress("UNREACHABLE_CODE")
                     throw TODO("write message")
             }