Load Java overrides of Kotlin suspend functions as suspend, too

There's still some blind spots:
- Covariant overrides in Java (KT-25036)
- Current implementation assumes that when language version is 1.3 every suspend function
reference only release-coroutines-package Continuation
(we need to check if it's a correct statement)

 #KT-24848 Fixed
 #KT-25036 Open

compiler/testData/diagnostics/testsWithStdLib/coroutines/suspendCovarianJavaOverride.kt

@@ -0,0 +1,48 @@
+// COMMON_COROUTINES_TEST
+// FILE: I.kt
+
+interface I {
+    suspend fun foo(x: Int): String
+}
+
+// FILE: JavaClass.java
+public class JavaClass implements I {
+    @Override
+    public String foo(int x, COROUTINES_PACKAGE.Continuation<String> continuation) {
+        return null;
+    }
+}
+
+// FILE: main.kt
+
+import COROUTINES_PACKAGE.Continuation
+class K1 : JavaClass()
+
+class K2 : JavaClass() {
+    override suspend fun foo(x: Int): String = ""
+}
+
+class K3 : JavaClass() {
+    <!NOTHING_TO_OVERRIDE!>override<!> fun foo(x: Int, y: Continuation<String>): Any? = null
+}
+
+fun builder(<!UNUSED_PARAMETER!>block<!>: suspend () -> Unit) {}
+
+fun main(x: Continuation<String>) {
+    JavaClass().<!ILLEGAL_SUSPEND_FUNCTION_CALL!>foo<!>(5, <!TOO_MANY_ARGUMENTS!>x<!>)
+    K1().<!ILLEGAL_SUSPEND_FUNCTION_CALL!>foo<!>(6, <!TOO_MANY_ARGUMENTS!>x<!>)
+    K2().<!ILLEGAL_SUSPEND_FUNCTION_CALL!>foo<!>(7, <!TOO_MANY_ARGUMENTS!>x<!>)
+    K3().foo(8, x)
+
+    builder {
+        JavaClass().foo(1)
+        K1().foo(2)
+        K2().foo(3)
+        K3().foo(4)
+
+        JavaClass().foo(5, <!TOO_MANY_ARGUMENTS!>x<!>)
+        K1().foo(6, <!TOO_MANY_ARGUMENTS!>x<!>)
+        K2().foo(7, <!TOO_MANY_ARGUMENTS!>x<!>)
+        K3().foo(8, x)
+    }
+}

compiler/testData/diagnostics/testsWithStdLib/coroutines/suspendCovarianJavaOverride.txt

@@ -0,0 +1,44 @@
+package
+
+public fun builder(/*0*/ block: suspend () -> kotlin.Unit): kotlin.Unit
+public fun main(/*0*/ x: COROUTINES_PACKAGE.Continuation<kotlin.String>): kotlin.Unit
+
+public interface I {
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public abstract suspend fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public open class JavaClass : I {
+    public constructor JavaClass()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    @java.lang.Override public open override /*1*/ suspend fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class K1 : JavaClass {
+    public constructor K1()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    @java.lang.Override public open override /*1*/ suspend /*fake_override*/ fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class K2 : JavaClass {
+    public constructor K2()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ suspend fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class K3 : JavaClass {
+    public constructor K3()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    @java.lang.Override public open override /*1*/ suspend /*fake_override*/ fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open fun foo(/*0*/ x: kotlin.Int, /*1*/ y: COROUTINES_PACKAGE.Continuation<kotlin.String>): kotlin.Any?
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}

compiler/testData/diagnostics/testsWithStdLib/coroutines/suspendJavaImplementationFromDifferentClass.kt

@@ -0,0 +1,51 @@
+// COMMON_COROUTINES_TEST
+// FILE: I.kt
+
+interface I {
+    suspend fun foo(x: Int): String
+}
+
+// FILE: BaseJavaClass.java
+public class BaseJavaClass {
+    public Object foo(int x, COROUTINES_PACKAGE.Continuation<String> continuation) {
+        return null;
+    }
+}
+
+// FILE: JavaClass.java
+public class JavaClass extends BaseJavaClass implements I {
+}
+
+// FILE: main.kt
+
+import COROUTINES_PACKAGE.Continuation
+class K1 : JavaClass()
+
+class K2 : JavaClass() {
+    override suspend fun foo(x: Int): String = ""
+}
+
+class K3 : JavaClass() {
+    <!NOTHING_TO_OVERRIDE!>override<!> fun foo(x: Int, y: Continuation<String>): Any? = null
+}
+
+fun builder(<!UNUSED_PARAMETER!>block<!>: suspend () -> Unit) {}
+
+fun main(x: Continuation<String>) {
+    JavaClass().<!ILLEGAL_SUSPEND_FUNCTION_CALL!>foo<!>(5, <!TOO_MANY_ARGUMENTS!>x<!>)
+    K1().<!ILLEGAL_SUSPEND_FUNCTION_CALL!>foo<!>(6, <!TOO_MANY_ARGUMENTS!>x<!>)
+    K2().<!ILLEGAL_SUSPEND_FUNCTION_CALL!>foo<!>(7, <!TOO_MANY_ARGUMENTS!>x<!>)
+    K3().foo(8, x)
+
+    builder {
+        JavaClass().foo(1)
+        K1().foo(2)
+        K2().foo(3)
+        K3().foo(4)
+
+        JavaClass().foo(5, <!TOO_MANY_ARGUMENTS!>x<!>)
+        K1().foo(6, <!TOO_MANY_ARGUMENTS!>x<!>)
+        K2().foo(7, <!TOO_MANY_ARGUMENTS!>x<!>)
+        K3().foo(8, x)
+    }
+}

compiler/testData/diagnostics/testsWithStdLib/coroutines/suspendJavaImplementationFromDifferentClass.txt

@@ -0,0 +1,52 @@
+package
+
+public fun builder(/*0*/ block: suspend () -> kotlin.Unit): kotlin.Unit
+public fun main(/*0*/ x: COROUTINES_PACKAGE.Continuation<kotlin.String>): kotlin.Unit
+
+public open class BaseJavaClass {
+    public constructor BaseJavaClass()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open fun foo(/*0*/ x: kotlin.Int, /*1*/ continuation: COROUTINES_PACKAGE.Continuation<kotlin.String!>!): kotlin.Any!
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public interface I {
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public abstract suspend fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public open class JavaClass : BaseJavaClass, I {
+    public constructor JavaClass()
+    public open override /*2*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*2*/ suspend /*fake_override*/ fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*2*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*2*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class K1 : JavaClass {
+    public constructor K1()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ suspend /*fake_override*/ fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class K2 : JavaClass {
+    public constructor K2()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ suspend fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class K3 : JavaClass {
+    public constructor K3()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ suspend /*fake_override*/ fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open fun foo(/*0*/ x: kotlin.Int, /*1*/ y: COROUTINES_PACKAGE.Continuation<kotlin.String>): kotlin.Any?
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}

compiler/testData/diagnostics/testsWithStdLib/coroutines/suspendJavaOverrides.kt

@@ -0,0 +1,48 @@
+// COMMON_COROUTINES_TEST
+// FILE: I.kt
+
+interface I {
+    suspend fun foo(x: Int): String
+}
+
+// FILE: JavaClass.java
+public class JavaClass implements I {
+    @Override
+    public Object foo(int x, COROUTINES_PACKAGE.Continuation<String> continuation) {
+        return null;
+    }
+}
+
+// FILE: main.kt
+
+import COROUTINES_PACKAGE.Continuation
+class K1 : JavaClass()
+
+class K2 : JavaClass() {
+    override suspend fun foo(x: Int): String = ""
+}
+
+class K3 : JavaClass() {
+    <!NOTHING_TO_OVERRIDE!>override<!> fun foo(x: Int, y: Continuation<String>): Any? = null
+}
+
+fun builder(<!UNUSED_PARAMETER!>block<!>: suspend () -> Unit) {}
+
+fun main(x: Continuation<String>) {
+    JavaClass().<!ILLEGAL_SUSPEND_FUNCTION_CALL!>foo<!>(5, <!TOO_MANY_ARGUMENTS!>x<!>)
+    K1().<!ILLEGAL_SUSPEND_FUNCTION_CALL!>foo<!>(6, <!TOO_MANY_ARGUMENTS!>x<!>)
+    K2().<!ILLEGAL_SUSPEND_FUNCTION_CALL!>foo<!>(7, <!TOO_MANY_ARGUMENTS!>x<!>)
+    K3().foo(8, x)
+
+    builder {
+        JavaClass().foo(1)
+        K1().foo(2)
+        K2().foo(3)
+        K3().foo(4)
+
+        JavaClass().foo(5, <!TOO_MANY_ARGUMENTS!>x<!>)
+        K1().foo(6, <!TOO_MANY_ARGUMENTS!>x<!>)
+        K2().foo(7, <!TOO_MANY_ARGUMENTS!>x<!>)
+        K3().foo(8, x)
+    }
+}

compiler/testData/diagnostics/testsWithStdLib/coroutines/suspendJavaOverrides.txt

@@ -0,0 +1,44 @@
+package
+
+public fun builder(/*0*/ block: suspend () -> kotlin.Unit): kotlin.Unit
+public fun main(/*0*/ x: COROUTINES_PACKAGE.Continuation<kotlin.String>): kotlin.Unit
+
+public interface I {
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public abstract suspend fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public open class JavaClass : I {
+    public constructor JavaClass()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    @java.lang.Override public open override /*1*/ suspend fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class K1 : JavaClass {
+    public constructor K1()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    @java.lang.Override public open override /*1*/ suspend /*fake_override*/ fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class K2 : JavaClass {
+    public constructor K2()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ suspend fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
+public final class K3 : JavaClass {
+    public constructor K3()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    @java.lang.Override public open override /*1*/ suspend /*fake_override*/ fun foo(/*0*/ x: kotlin.Int): kotlin.String
+    public open fun foo(/*0*/ x: kotlin.Int, /*1*/ y: COROUTINES_PACKAGE.Continuation<kotlin.String>): kotlin.Any?
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}

compiler/testData/diagnostics/testsWithStdLib/coroutines/suspendOverridability.kt

@@ -25,7 +25,7 @@ interface C : A {
 }
 
 <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class D<!> : J {
-    <!ACCIDENTAL_OVERRIDE!>suspend override fun foo()<!> {
+    suspend override fun foo() {
 
     }
 }

compiler/testData/diagnostics/testsWithStdLib/coroutines/suspendOverridability.txt

@@ -29,7 +29,6 @@ public final class D : J {
     public abstract override /*1*/ /*fake_override*/ fun bar(): kotlin.Unit
     public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
     public open override /*1*/ suspend fun foo(): kotlin.Unit
-    public abstract override /*1*/ /*fake_override*/ fun foo(/*0*/ y: kotlin.coroutines.experimental.Continuation<kotlin.Unit!>!): kotlin.Any!
     public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
     public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
 }
@@ -37,8 +36,7 @@ public final class D : J {
 public interface J : A {
     public abstract override /*1*/ /*fake_override*/ fun bar(): kotlin.Unit
     public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
-    public abstract override /*1*/ suspend /*fake_override*/ fun foo(): kotlin.Unit
-    public abstract fun foo(/*0*/ y: kotlin.coroutines.experimental.Continuation<kotlin.Unit!>!): kotlin.Any!
+    public abstract override /*1*/ suspend fun foo(): kotlin.Unit
     public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
     public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
 }