Extend recovery set when expecting property accessor

#KT-12987 Fixed

compiler/frontend/src/org/jetbrains/kotlin/parsing/KotlinParsing.java

@@ -1279,7 +1279,9 @@ public class KotlinParsing extends AbstractKotlinParsing {
 
             if (!atSet(EOL_OR_SEMICOLON, RBRACE)) {
                 if (getLastToken() != SEMICOLON) {
-                    errorUntil("Property getter or setter expected", TokenSet.create(EOL_OR_SEMICOLON, LBRACE, RBRACE));
+                    errorUntil(
+                            "Property getter or setter expected",
+                            TokenSet.orSet(DECLARATION_FIRST, TokenSet.create(EOL_OR_SEMICOLON, LBRACE, RBRACE)));
                 }
             }
             else {

compiler/testData/diagnostics/tests/incompleteCode/diagnosticWithSyntaxError/valWithNoNameBeforeNextDeclarationWithModifiers.kt

@@ -10,4 +10,6 @@ abstract class A {
     private val<!SYNTAX!><!>
     fun foo3() {
     }
+
+    private val private<!SYNTAX!><!> fun foo() {}
 }

compiler/testData/diagnostics/tests/incompleteCode/diagnosticWithSyntaxError/valWithNoNameBeforeNextDeclarationWithModifiers.txt

@@ -5,7 +5,9 @@ public abstract class A {
     private final val <no name provided>: [ERROR : No type, no body]
     private final val <no name provided>: [ERROR : No type, no body]
     private final val <no name provided>: [ERROR : No type, no body]
+    private final val private: [ERROR : No type, no body]
     public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public final fun foo(): kotlin.Unit
     private final fun foo1(): kotlin.Unit
     protected abstract fun foo2(): kotlin.Unit
     public final fun foo3(): kotlin.Unit

compiler/testData/psi/DefaultKeyword.txt

@@ -293,14 +293,15 @@ JetFile: DefaultKeyword.kt
     PsiWhiteSpace(' ')
     REFERENCE_EXPRESSION
       PsiElement(IDENTIFIER)('companion')
-    PsiWhiteSpace(' ')
     PsiErrorElement:Property getter or setter expected
-      PsiElement(object)('object')
-  PsiWhiteSpace(' ')
-  FUN
-    PsiErrorElement:Expecting a top level declaration
       <empty list>
-    BLOCK
+  PsiWhiteSpace(' ')
+  OBJECT_DECLARATION
+    PsiElement(object)('object')
+    PsiErrorElement:Name expected
+      <empty list>
+    PsiWhiteSpace(' ')
+    CLASS_BODY
       PsiElement(LBRACE)('{')
       PsiWhiteSpace('\n\n')
       PsiElement(RBRACE)('}')

compiler/testData/psi/FunctionExpressions_ERR.txt

@@ -384,10 +384,13 @@ JetFile: FunctionExpressions_ERR.kt
     PsiWhiteSpace(' ')
     REFERENCE_EXPRESSION
       PsiElement(IDENTIFIER)('public')
-    PsiWhiteSpace(' ')
     PsiErrorElement:Property getter or setter expected
-      PsiElement(fun)('fun')
+      <empty list>
-      PsiWhiteSpace(' ')
+  PsiWhiteSpace(' ')
+  FUN
+    PsiElement(fun)('fun')
+    PsiWhiteSpace(' ')
+    VALUE_PARAMETER_LIST
       PsiElement(LPAR)('(')
       PsiElement(RPAR)(')')
   PsiWhiteSpace('\n')
@@ -400,10 +403,13 @@ JetFile: FunctionExpressions_ERR.kt
     PsiWhiteSpace(' ')
     REFERENCE_EXPRESSION
       PsiElement(IDENTIFIER)('open')
-    PsiWhiteSpace(' ')
     PsiErrorElement:Property getter or setter expected
-      PsiElement(fun)('fun')
+      <empty list>
-      PsiWhiteSpace(' ')
+  PsiWhiteSpace(' ')
+  FUN
+    PsiElement(fun)('fun')
+    PsiWhiteSpace(' ')
+    VALUE_PARAMETER_LIST
       PsiElement(LPAR)('(')
       PsiElement(RPAR)(')')
   PsiWhiteSpace('\n')
@@ -416,10 +422,13 @@ JetFile: FunctionExpressions_ERR.kt
     PsiWhiteSpace(' ')
     REFERENCE_EXPRESSION
       PsiElement(IDENTIFIER)('final')
-    PsiWhiteSpace(' ')
     PsiErrorElement:Property getter or setter expected
-      PsiElement(fun)('fun')
+      <empty list>
-      PsiWhiteSpace(' ')
+  PsiWhiteSpace(' ')
+  FUN
+    PsiElement(fun)('fun')
+    PsiWhiteSpace(' ')
+    VALUE_PARAMETER_LIST
       PsiElement(LPAR)('(')
       PsiElement(RPAR)(')')
   PsiWhiteSpace('\n\n')
@@ -647,4 +656,4 @@ JetFile: FunctionExpressions_ERR.kt
                           PsiElement(IDENTIFIER)('V')
           PsiElement(RPAR)(')')
       PsiWhiteSpace('\n')
-      PsiElement(RBRACE)('}')
+      PsiElement(RBRACE)('}')

compiler/testData/psi/TypealiasIsKeyword.txt

@@ -7,10 +7,16 @@ JetFile: TypealiasIsKeyword.kt
     PsiElement(val)('val')
     PsiErrorElement:Expecting property name or receiver type
       <empty list>
-    PsiWhiteSpace(' ')
     PsiErrorElement:Property getter or setter expected
-      PsiElement(typealias)('typealias')
+      <empty list>
-      PsiWhiteSpace(' ')
+  PsiWhiteSpace(' ')
-      PsiElement(EQ)('=')
+  TYPEALIAS
-      PsiWhiteSpace(' ')
+    PsiElement(typealias)('typealias')
-      PsiElement(INTEGER_LITERAL)('0')
+    PsiErrorElement:Type name expected
+      <empty list>
+    PsiWhiteSpace(' ')
+    PsiElement(EQ)('=')
+    PsiWhiteSpace(' ')
+    TYPE_REFERENCE
+      PsiErrorElement:Type expected
+        PsiElement(INTEGER_LITERAL)('0')

compiler/testData/psi/functionReceivers/PropertiesWithFunctionReceiversRecovery.txt

@@ -278,21 +278,41 @@ JetFile: PropertiesWithFunctionReceiversRecovery.kt
     PsiElement(val)('val')
     PsiErrorElement:Expecting property name or receiver type
       <empty list>
-    PsiWhiteSpace(' ')
     PsiErrorElement:Property getter or setter expected
-      PsiElement(val)('val')
+      <empty list>
-      PsiWhiteSpace(' ')
+  PsiWhiteSpace(' ')
-      PsiElement(AT)('@')
+  DESTRUCTURING_DECLARATION
-      PsiElement(IDENTIFIER)('a')
+    PsiElement(val)('val')
-      PsiWhiteSpace(' ')
+    PsiWhiteSpace(' ')
-      PsiElement(IDENTIFIER)('T')
+    PsiErrorElement:Receiver type is not allowed on a destructuring declaration
-      PsiElement(LT)('<')
+      TYPE_REFERENCE
-      PsiElement(IDENTIFIER)('T')
+        ANNOTATION_ENTRY
-      PsiElement(GT)('>')
+          PsiElement(AT)('@')
+          CONSTRUCTOR_CALLEE
+            TYPE_REFERENCE
+              USER_TYPE
+                REFERENCE_EXPRESSION
+                  PsiElement(IDENTIFIER)('a')
+        PsiWhiteSpace(' ')
+        USER_TYPE
+          REFERENCE_EXPRESSION
+            PsiElement(IDENTIFIER)('T')
+          TYPE_ARGUMENT_LIST
+            PsiElement(LT)('<')
+            TYPE_PROJECTION
+              TYPE_REFERENCE
+                USER_TYPE
+                  REFERENCE_EXPRESSION
+                    PsiElement(IDENTIFIER)('T')
+            PsiElement(GT)('>')
       PsiElement(DOT)('.')
+    PsiErrorElement:Destructuring declarations are only allowed for local variables/values
       PsiElement(LPAR)('(')
-      PsiElement(IDENTIFIER)('A')
+      DESTRUCTURING_DECLARATION_ENTRY
-      PsiElement(LT)('<')
+        PsiElement(IDENTIFIER)('A')
+      PsiErrorElement:Expecting ')'
+        PsiElement(LT)('<')
+    PsiErrorElement:Property getter or setter expected
       PsiElement(IDENTIFIER)('B')
       PsiElement(GT)('>')
       PsiElement(RPAR)(')')
@@ -433,4 +453,4 @@ JetFile: PropertiesWithFunctionReceiversRecovery.kt
       PsiWhiteSpace(' ')
       PsiElement(IDENTIFIER)('A')
       PsiElement(DOT)('.')
-      PsiElement(IDENTIFIER)('B')
+      PsiElement(IDENTIFIER)('B')