From 37e9062fcc57932687a84734b5f4fffcf0a06fec Mon Sep 17 00:00:00 2001 From: Vladimir Sukharev Date: Fri, 12 Jan 2024 16:15:58 +0100 Subject: [PATCH] [FIR] Rename FirCallableDeclaration.getOverriddenSymbols() to getDirectOverriddenSymbols() --- .../native/checkers/FirNativeObjCOverrideInitChecker.kt | 4 ++-- .../jetbrains/kotlin/fir/analysis/checkers/FirHelpers.kt | 2 +- .../checkers/declaration/FirInlineDeclarationChecker.kt | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/compiler/fir/checkers/checkers.native/src/org/jetbrains/kotlin/fir/analysis/native/checkers/FirNativeObjCOverrideInitChecker.kt b/compiler/fir/checkers/checkers.native/src/org/jetbrains/kotlin/fir/analysis/native/checkers/FirNativeObjCOverrideInitChecker.kt index 2da4b02eaf4..e879762181b 100644 --- a/compiler/fir/checkers/checkers.native/src/org/jetbrains/kotlin/fir/analysis/native/checkers/FirNativeObjCOverrideInitChecker.kt +++ b/compiler/fir/checkers/checkers.native/src/org/jetbrains/kotlin/fir/analysis/native/checkers/FirNativeObjCOverrideInitChecker.kt @@ -9,7 +9,7 @@ import org.jetbrains.kotlin.diagnostics.DiagnosticReporter import org.jetbrains.kotlin.diagnostics.reportOn import org.jetbrains.kotlin.fir.* import org.jetbrains.kotlin.fir.analysis.checkers.context.CheckerContext -import org.jetbrains.kotlin.fir.analysis.checkers.getOverriddenSymbols +import org.jetbrains.kotlin.fir.analysis.checkers.getDirectOverriddenSymbols import org.jetbrains.kotlin.fir.analysis.checkers.declaration.FirClassChecker import org.jetbrains.kotlin.fir.analysis.diagnostics.native.FirNativeErrors import org.jetbrains.kotlin.fir.backend.native.interop.getObjCInitMethod @@ -71,7 +71,7 @@ object FirNativeObjCOverrideInitChecker : FirClassChecker() { // Remove fake overrides of this init method, also check for explicit overriding: firClass.declarations.forEach { - if (it is FirSimpleFunction && initMethod in it.getOverriddenSymbols(context) && !it.isSubstitutionOrIntersectionOverride) { + if (it is FirSimpleFunction && initMethod in it.getDirectOverriddenSymbols(context) && !it.isSubstitutionOrIntersectionOverride) { reporter.reportOn( constructor.source, FirNativeErrors.CONSTRUCTOR_OVERRIDES_ALREADY_OVERRIDDEN_OBJC_INITIALIZER, diff --git a/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/FirHelpers.kt b/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/FirHelpers.kt index 14f8dbd514e..f2c5661a6f4 100644 --- a/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/FirHelpers.kt +++ b/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/FirHelpers.kt @@ -734,7 +734,7 @@ fun ConeKotlinType.getInlineClassUnderlyingType(session: FirSession): ConeKotlin return toRegularClassSymbol(session)!!.primaryConstructorSymbol(session)!!.valueParameterSymbols[0].resolvedReturnTypeRef.coneType } -fun FirCallableDeclaration.getOverriddenSymbols(context: CheckerContext): List> { +fun FirCallableDeclaration.getDirectOverriddenSymbols(context: CheckerContext): List> { if (!this.isOverride) return emptyList() val classSymbol = this.containingClassLookupTag()?.toSymbol(context.session) as? FirClassSymbol<*> ?: return emptyList() val scope = classSymbol.unsubstitutedScope(context) diff --git a/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/declaration/FirInlineDeclarationChecker.kt b/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/declaration/FirInlineDeclarationChecker.kt index e00e4e2905e..08a533eb489 100644 --- a/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/declaration/FirInlineDeclarationChecker.kt +++ b/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/declaration/FirInlineDeclarationChecker.kt @@ -17,7 +17,7 @@ import org.jetbrains.kotlin.diagnostics.DiagnosticReporter import org.jetbrains.kotlin.diagnostics.reportOn import org.jetbrains.kotlin.fir.* import org.jetbrains.kotlin.fir.analysis.checkers.context.CheckerContext -import org.jetbrains.kotlin.fir.analysis.checkers.getOverriddenSymbols +import org.jetbrains.kotlin.fir.analysis.checkers.getDirectOverriddenSymbols import org.jetbrains.kotlin.fir.analysis.checkers.inlineCheckerExtension import org.jetbrains.kotlin.fir.analysis.checkers.isInlineOnly import org.jetbrains.kotlin.fir.analysis.diagnostics.FirErrors @@ -459,14 +459,14 @@ object FirInlineDeclarationChecker : FirFunctionChecker() { fun checkCallableDeclaration(declaration: FirCallableDeclaration, context: CheckerContext, reporter: DiagnosticReporter) { if (declaration is FirPropertyAccessor) return - val overriddenSymbols = declaration.getOverriddenSymbols(context) + val directOverriddenSymbols = declaration.getDirectOverriddenSymbols(context) if (declaration is FirSimpleFunction) { - checkParameters(declaration, overriddenSymbols, context, reporter) + checkParameters(declaration, directOverriddenSymbols, context, reporter) checkNothingToInline(declaration, context, reporter) } val canBeInlined = checkCanBeInlined(declaration, declaration.effectiveVisibility, context, reporter) - if (canBeInlined && overriddenSymbols.isNotEmpty()) { + if (canBeInlined && directOverriddenSymbols.isNotEmpty()) { reporter.reportOn(declaration.source, FirErrors.OVERRIDE_BY_INLINE, context) } }