[FE 1.0] Don't lose diagnostics during lambda analysis at the overload resolution by return type stage

^KT-49658 Fixed

compiler/testData/diagnostics/tests/inference/kt49658.fir.kt

@@ -0,0 +1,16 @@
+// WITH_STDLIB
+
+fun doTheMapThing1(elements: List<CharSequence>): List<String> {
+    return elements.flatMap {
+        <!ARGUMENT_TYPE_MISMATCH!>when (it) { // NullPointerException
+            is String -> listOf("Yeah")
+            else -> null
+        }<!>
+    }
+}
+
+fun doTheMapThing2(elements: List<CharSequence>): List<String> {
+    return elements.flatMap {
+        <!ARGUMENT_TYPE_MISMATCH!>if (it is String) listOf("Yeah") else null<!> // it's OK with `if`
+    }
+}

compiler/testData/diagnostics/tests/inference/kt49658.kt

@@ -0,0 +1,16 @@
+// WITH_STDLIB
+
+fun doTheMapThing1(elements: List<CharSequence>): List<String> {
+    return elements.flatMap {
+        <!TYPE_MISMATCH_WARNING!>when (it) { // NullPointerException
+            is String -> listOf("Yeah")
+            else -> null
+        }<!>
+    }
+}
+
+fun doTheMapThing2(elements: List<CharSequence>): List<String> {
+    return elements.flatMap {
+        <!TYPE_MISMATCH, TYPE_MISMATCH, TYPE_MISMATCH_WARNING!>if (it is String) listOf("Yeah") else null<!> // it's OK with `if`
+    }
+}

compiler/testData/diagnostics/tests/inference/kt49658.txt

@@ -0,0 +1,5 @@
+package
+
+public fun doTheMapThing1(/*0*/ elements: kotlin.collections.List<kotlin.CharSequence>): kotlin.collections.List<kotlin.String>
+public fun doTheMapThing2(/*0*/ elements: kotlin.collections.List<kotlin.CharSequence>): kotlin.collections.List<kotlin.String>
+

compiler/testData/diagnostics/tests/inference/kt49658Strict.fir.kt

@@ -0,0 +1,17 @@
+// !LANGUAGE: +DontLoseDiagnosticsDuringOverloadResolutionByReturnType
+// WITH_STDLIB
+
+fun doTheMapThing1(elements: List<CharSequence>): List<String> {
+    return elements.flatMap {
+        <!ARGUMENT_TYPE_MISMATCH!>when (it) { // NullPointerException
+            is String -> listOf("Yeah")
+            else -> null
+        }<!>
+    }
+}
+
+fun doTheMapThing2(elements: List<CharSequence>): List<String> {
+    return elements.flatMap {
+        <!ARGUMENT_TYPE_MISMATCH!>if (it is String) listOf("Yeah") else null<!> // it's OK with `if`
+    }
+}

compiler/testData/diagnostics/tests/inference/kt49658Strict.kt

@@ -0,0 +1,17 @@
+// !LANGUAGE: +DontLoseDiagnosticsDuringOverloadResolutionByReturnType
+// WITH_STDLIB
+
+fun doTheMapThing1(elements: List<CharSequence>): List<String> {
+    return elements.<!CANDIDATE_CHOSEN_USING_OVERLOAD_RESOLUTION_BY_LAMBDA_ANNOTATION!>flatMap {
+        <!TYPE_MISMATCH!>when (it) { // NullPointerException
+            is String -> listOf("Yeah")
+            else -> null
+        }<!>
+    }<!>
+}
+
+fun doTheMapThing2(elements: List<CharSequence>): List<String> {
+    return elements.<!CANDIDATE_CHOSEN_USING_OVERLOAD_RESOLUTION_BY_LAMBDA_ANNOTATION!>flatMap {
+        <!TYPE_MISMATCH, TYPE_MISMATCH, TYPE_MISMATCH!>if (it is String) listOf("Yeah") else null<!> // it's OK with `if`
+    }<!>
+}

compiler/testData/diagnostics/tests/inference/kt49658Strict.txt

@@ -0,0 +1,4 @@
+package
+
+public fun doTheMapThing1(/*0*/ elements: kotlin.collections.List<kotlin.CharSequence>): kotlin.collections.List<kotlin.String>
+public fun doTheMapThing2(/*0*/ elements: kotlin.collections.List<kotlin.CharSequence>): kotlin.collections.List<kotlin.String>