Code improvements after review

This commit is contained in:
Valentin Kipyatkov
2015-04-03 13:58:56 +03:00
parent 5dbd23088f
commit 37af12c4bf
3 changed files with 9 additions and 10 deletions
@@ -125,7 +125,7 @@ public class QualifiedExpressionResolver {
else { else {
Name aliasName = JetPsiUtil.getAliasName(importDirective); Name aliasName = JetPsiUtil.getAliasName(importDirective);
if (aliasName == null) return JetScope.Empty.INSTANCE$; if (aliasName == null) return JetScope.Empty.INSTANCE$;
return new SingleAliasScope(aliasName, descriptors); return new SingleImportScope(aliasName, descriptors);
} }
} }
@@ -22,7 +22,7 @@ import org.jetbrains.kotlin.resolve.scopes.DescriptorKindFilter
import org.jetbrains.kotlin.resolve.scopes.JetScope import org.jetbrains.kotlin.resolve.scopes.JetScope
import org.jetbrains.kotlin.utils.Printer import org.jetbrains.kotlin.utils.Printer
class SingleAliasScope(private val aliasName: Name, private val descriptors: Collection<DeclarationDescriptor>) : JetScope { class SingleImportScope(private val aliasName: Name, private val descriptors: Collection<DeclarationDescriptor>) : JetScope {
override fun getClassifier(name: Name) override fun getClassifier(name: Name)
= if (name == aliasName) descriptors.filterIsInstance<ClassifierDescriptor>().singleOrNull() else null = if (name == aliasName) descriptors.filterIsInstance<ClassifierDescriptor>().singleOrNull() else null
@@ -48,6 +48,6 @@ class SingleAliasScope(private val aliasName: Name, private val descriptors: Col
override fun getOwnDeclaredDescriptors(): Collection<DeclarationDescriptor> = emptyList() override fun getOwnDeclaredDescriptors(): Collection<DeclarationDescriptor> = emptyList()
override fun printScopeStructure(p: Printer) { override fun printScopeStructure(p: Printer) {
p.println(javaClass.getSimpleName()) p.println(javaClass.getSimpleName(), ": ", aliasName)
} }
} }
@@ -99,23 +99,22 @@ class LazyImportResolver(
else { else {
directiveUnderResolve = directive directiveUnderResolve = directive
val directiveImportScope: JetScope
val descriptors: Collection<DeclarationDescriptor>
try { try {
val resolver = resolveSession.getQualifiedExpressionResolver() val resolver = resolveSession.getQualifiedExpressionResolver()
directiveImportScope = resolver.processImportReference( val directiveImportScope = resolver.processImportReference(
directive, rootScope, packageView.getMemberScope(), traceForImportResolve, mode) directive, rootScope, packageView.getMemberScope(), traceForImportResolve, mode)
descriptors = if (directive.isAllUnder()) emptyList() else directiveImportScope.getAllDescriptors() val descriptors = if (directive.isAllUnder()) emptyList() else directiveImportScope.getAllDescriptors()
if (mode == LookupMode.EVERYTHING) { if (mode == LookupMode.EVERYTHING) {
PlatformTypesMappedToKotlinChecker.checkPlatformTypesMappedToKotlin(packageView.getModule(), traceForImportResolve, directive, descriptors) PlatformTypesMappedToKotlinChecker.checkPlatformTypesMappedToKotlin(packageView.getModule(), traceForImportResolve, directive, descriptors)
} }
importResolveStatus = ImportResolveStatus(mode, directiveImportScope, descriptors)
directiveImportScope
} }
finally { finally {
directiveUnderResolve = null directiveUnderResolve = null
} }
importResolveStatus = ImportResolveStatus(mode, directiveImportScope, descriptors)
directiveImportScope
} }
} }
} }