From 3765c5119fd7d748cdbd5ee196ae430cd625ca1a Mon Sep 17 00:00:00 2001
From: Dmitriy Novozhilov <dmitriy.novozhilov@jetbrains.com>
Date: Thu, 4 Jun 2020 15:27:49 +0300
Subject: [PATCH] [FIR] Cache nodes in sorted order in CFG

---
 .../kotlin/fir/analysis/cfa/CfgUtils.kt       | 33 ++--------
 .../fir/resolve/dfa/cfg/ControlFlowGraph.kt   | 66 ++++++++++++++++++-
 2 files changed, 67 insertions(+), 32 deletions(-)

diff --git a/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/cfa/CfgUtils.kt b/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/cfa/CfgUtils.kt
index 3e9ac3ef079..022db68b395 100644
--- a/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/cfa/CfgUtils.kt
+++ b/compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/cfa/CfgUtils.kt
@@ -20,37 +20,12 @@ fun <D> ControlFlowGraph.traverse(
     visitor: ControlFlowGraphVisitor<*, D>,
     data: D
 ) {
-    val visitedNodes = mutableSetOf<CFGNode<*>>()
-    // used to prevent infinite cycle
-    val delayedNodes = mutableSetOf<CFGNode<*>>()
-    val stack = ArrayDeque<CFGNode<*>>()
-    val initialNode = when (direction) {
-        TraverseDirection.Forward -> enterNode
-        TraverseDirection.Backward -> exitNode
+    val nodes = when (direction) {
+        TraverseDirection.Forward -> nodes
+        TraverseDirection.Backward -> nodes.reversed()
     }
-    stack.addFirst(initialNode)
-    while (stack.isNotEmpty()) {
-        val node = stack.removeFirst()
-        visitedNodes.add(node)
-        val previousNodes = when (direction) {
-            TraverseDirection.Forward -> node.previousNodes
-            TraverseDirection.Backward -> node.followingNodes
-        }
-        if (!previousNodes.all { it in visitedNodes }) {
-            if (!delayedNodes.add(node)) {
-                throw IllegalArgumentException("Infinite loop")
-            }
-            stack.addLast(node)
-        }
-
+    for (node in nodes) {
         node.accept(visitor, data)
-
-        val followingNodes = when (direction) {
-            TraverseDirection.Forward -> node.followingNodes
-            TraverseDirection.Backward -> node.previousNodes
-        }
-
-        followingNodes.filterNot { visitedNodes.contains(it) }.forEach { stack.addFirst(it) }
     }
 }
 
diff --git a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/dfa/cfg/ControlFlowGraph.kt b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/dfa/cfg/ControlFlowGraph.kt
index 414db34cdf8..fc59360bd9d 100644
--- a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/dfa/cfg/ControlFlowGraph.kt
+++ b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/dfa/cfg/ControlFlowGraph.kt
@@ -8,13 +8,14 @@ package org.jetbrains.kotlin.fir.resolve.dfa.cfg
 import org.jetbrains.kotlin.fir.declarations.FirDeclaration
 
 class ControlFlowGraph(val declaration: FirDeclaration?, val name: String, val kind: Kind) {
-    private val _nodes: MutableList<CFGNode<*>> = mutableListOf()
+    private var _nodes: MutableList<CFGNode<*>> = mutableListOf()
 
-    val nodes: List<CFGNode<*>> get() = _nodes
+    val nodes: List<CFGNode<*>>
+        get() = _nodes
 
     internal fun addNode(node: CFGNode<*>) {
         assertState(State.Building)
-        _nodes += node
+        _nodes.add(node)
     }
 
     lateinit var enterNode: CFGNode<*>
@@ -34,6 +35,13 @@ class ControlFlowGraph(val declaration: FirDeclaration?, val name: String, val k
     internal fun complete() {
         assertState(State.Building)
         state = State.Completed
+        val sortedNodes = orderNodes()
+        assert(sortedNodes.size == _nodes.size)
+        for (node in _nodes) {
+            assert(node in sortedNodes)
+        }
+        _nodes.clear()
+        _nodes.addAll(sortedNodes)
     }
 
     internal fun addSubGraph(graph: ControlFlowGraph) {
@@ -83,3 +91,55 @@ enum class EdgeKind(val usedInDfa: Boolean, val isBack: Boolean) {
     Back(usedInDfa = false, isBack = true),
     DeadBack(usedInDfa = false, isBack = true)
 }
+
+@OptIn(ExperimentalStdlibApi::class)
+private fun ControlFlowGraph.orderNodes(): LinkedHashSet<CFGNode<*>> {
+    val visitedNodes = LinkedHashSet<CFGNode<*>>()
+    /*
+     * [delayedNodes] is needed to accomplish next order contract:
+     *   for each node all previous node lays before it
+     */
+    val delayedNodes = LinkedHashSet<CFGNode<*>>()
+    val stack = ArrayDeque<CFGNode<*>>()
+    stack.addFirst(enterNode)
+    while (stack.isNotEmpty()) {
+        val node = stack.removeFirst()
+        val previousNodes = node.previousNodes
+        if (previousNodes.any { it !in visitedNodes && it.owner == this && !node.incomingEdges.getValue(it).isBack }) {
+            delayedNodes.add(node)
+            stack.addLast(node)
+            continue
+        }
+        if (!visitedNodes.add(node)) continue
+        val followingNodes = node.followingNodes
+
+        for (followingNode in followingNodes) {
+            if (followingNode.owner == this) {
+                if (followingNode !in visitedNodes) {
+                    stack.addFirst(followingNode)
+                }
+            } else {
+                walkThrowSubGraphs(followingNode.owner, visitedNodes, stack)
+            }
+        }
+    }
+    return visitedNodes
+}
+
+@OptIn(ExperimentalStdlibApi::class)
+private fun ControlFlowGraph.walkThrowSubGraphs(
+    otherGraph: ControlFlowGraph,
+    visitedNodes: Set<CFGNode<*>>,
+    stack: ArrayDeque<CFGNode<*>>
+) {
+    if (otherGraph.owner != this) return
+    for (otherNode in otherGraph.exitNode.followingNodes) {
+        if (otherNode.owner == this) {
+            if (otherNode !in visitedNodes) {
+                stack.addFirst(otherNode)
+            }
+        } else if (otherNode.owner != otherGraph) {
+            walkThrowSubGraphs(otherNode.owner, visitedNodes, stack)
+        }
+    }
+}