[FIR] Only overridable members should report JvmName inapplicable

Instead of checking for only open declarations, check for overridable
declarations, since private declarations cannot be overridden even if
they are marked as open. While normally these modifiers are exclusive,
a declaration can be made open via a compiler plugin like AllOpen.

#KT-60183 Fixed
#KT-57223 Fixed
This commit is contained in:
Brian Norman
2023-07-14 09:07:10 -05:00
committed by Space Team
parent 70662007a5
commit 363b336b7a
5 changed files with 58 additions and 101 deletions
@@ -1,4 +1,5 @@
// !DIAGNOSTICS: -UNUSED_VARIABLE -UNUSED_PARAMETER
// FIR_IDENTICAL
// !DIAGNOSTICS: -UNUSED_VARIABLE -UNUSED_PARAMETER -INVISIBLE_ABSTRACT_MEMBER_FROM_SUPER_ERROR
@JvmName("a")
fun foo() {}
@@ -73,6 +74,34 @@ abstract class AB {
<!INAPPLICABLE_JVM_NAME!>@JvmName("AB_openFun")<!>
open fun openFun() {}
@JvmName("AB_protectedFinalFun")
protected fun protectedFinalFun() {}
<!INAPPLICABLE_JVM_NAME!>@JvmName("AB_protectedOpenFun")<!>
protected open fun protectedOpenFun() {}
<!INAPPLICABLE_JVM_NAME!>@JvmName("AB_protectedAbstractFun")<!>
protected abstract fun protectedAbstractFun()
@JvmName("AB_internalFinalFun")
internal fun internalFinalFun() {}
<!INAPPLICABLE_JVM_NAME!>@JvmName("AB_internalOpenFun")<!>
internal open fun internalOpenFun() {}
<!INAPPLICABLE_JVM_NAME!>@JvmName("AB_internalAbstractFun")<!>
internal abstract fun internalAbstractFun()
@JvmName("AB_privateFinalFun")
private fun privateFinalFun() {}
// Possible via AllOpen compiler plugin
@JvmName("AB_privateOpenFun")
<!INCOMPATIBLE_MODIFIERS!>private<!> <!INCOMPATIBLE_MODIFIERS!>open<!> fun privateOpenFun() {}
@JvmName("AB_privateAbstractFun")
<!INCOMPATIBLE_MODIFIERS!>private<!> <!INCOMPATIBLE_MODIFIERS!>abstract<!> fun privateAbstractFun()
}
class D: AB() {
@@ -84,6 +113,10 @@ class D: AB() {
<!INAPPLICABLE_JVM_NAME!>@JvmName("D_openFun")<!>
final override fun openFun() {}
protected override fun protectedAbstractFun() {}
internal override fun internalAbstractFun() {}
@JvmName("D_finalFun")
fun finalFun() {}
}
@@ -92,4 +125,4 @@ interface Intf {
<!INAPPLICABLE_JVM_NAME!>@get:JvmName("getBar")<!> // no error in IDE
<!INAPPLICABLE_JVM_NAME!>@set:JvmName("setBar")<!> // no error in IDE
var foo: Int
}
}