[FIR] Fix WRONG_ANNOTATION_TARGET for annotation for block, ^KT-52175 Fixed

analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/DiagnosisCompilerTestFE10TestdataTestGenerated.java

@@ -996,6 +996,12 @@ public class DiagnosisCompilerTestFE10TestdataTestGenerated extends AbstractDiag
                 runTest("compiler/testData/diagnostics/tests/annotations/AmbigiousAnnotationConstructor.kt");
             }
 
+            @Test
+            @TestMetadata("AnnotatedBlock.kt")
+            public void testAnnotatedBlock() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/annotations/AnnotatedBlock.kt");
+            }
+
             @Test
             @TestMetadata("AnnotatedConstructor.kt")
             public void testAnnotatedConstructor() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirOldFrontendDiagnosticsTestGenerated.java

@@ -996,6 +996,12 @@ public class FirOldFrontendDiagnosticsTestGenerated extends AbstractFirDiagnosti
                 runTest("compiler/testData/diagnostics/tests/annotations/AmbigiousAnnotationConstructor.kt");
             }
 
+            @Test
+            @TestMetadata("AnnotatedBlock.kt")
+            public void testAnnotatedBlock() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/annotations/AnnotatedBlock.kt");
+            }
+
             @Test
             @TestMetadata("AnnotatedConstructor.kt")
             public void testAnnotatedConstructor() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirOldFrontendDiagnosticsWithLightTreeTestGenerated.java

@@ -996,6 +996,12 @@ public class FirOldFrontendDiagnosticsWithLightTreeTestGenerated extends Abstrac
                 runTest("compiler/testData/diagnostics/tests/annotations/AmbigiousAnnotationConstructor.kt");
             }
 
+            @Test
+            @TestMetadata("AnnotatedBlock.kt")
+            public void testAnnotatedBlock() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/annotations/AnnotatedBlock.kt");
+            }
+
             @Test
             @TestMetadata("AnnotatedConstructor.kt")
             public void testAnnotatedConstructor() throws Exception {

compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/expression/FirExpressionAnnotationChecker.kt

@@ -6,6 +6,7 @@
 package org.jetbrains.kotlin.fir.analysis.checkers.expression
 
 import org.jetbrains.kotlin.KtFakeSourceElementKind
+import org.jetbrains.kotlin.KtRealSourceElementKind
 import org.jetbrains.kotlin.descriptors.annotations.AnnotationUseSiteTarget
 import org.jetbrains.kotlin.descriptors.annotations.KotlinTarget
 import org.jetbrains.kotlin.fir.analysis.checkers.checkRepeatedAnnotation
@@ -29,7 +30,8 @@ object FirExpressionAnnotationChecker : FirBasicExpressionChecker() {
         // See KT-33658 about annotations on non-expression statements
         if (expression is FirDeclaration ||
             expression !is FirExpression ||
-            expression is FirBlock && expression.source?.kind == KtFakeSourceElementKind.DesugaredForLoop
+            expression is FirBlock && (expression.source?.kind == KtRealSourceElementKind ||
+                    expression.source?.kind == KtFakeSourceElementKind.DesugaredForLoop)
         ) return
 
         val annotations = expression.annotations

compiler/testData/diagnostics/tests/annotations/AnnotatedBlock.fir.txt

@@ -0,0 +1,28 @@
+FILE: AnnotatedBlock.kt
+    public final annotation class Ann : R|kotlin/Annotation| {
+        public constructor(): R|Ann| {
+            super<R|kotlin/Any|>()
+        }
+
+    }
+    public final annotation class Ann2 : R|kotlin/Annotation| {
+        public constructor(): R|Ann2| {
+            super<R|kotlin/Any|>()
+        }
+
+    }
+    public final fun test(x: R|kotlin/String?|): R|kotlin/Unit| {
+        when () {
+            !=(R|<local>/x|, Null(null)) -> @R|Ann|() @R|Ann2|()  {
+                Q|kotlin/Unit|
+            }
+        }
+
+        when () {
+            !=(R|<local>/x|, Null(null)) ->  {
+                @R|Ann|() @R|Ann2|() Q|kotlin/Unit|
+            }
+        }
+
+        @R|Ann|() @R|Ann2|() R|<local>/x|
+    }

compiler/testData/diagnostics/tests/annotations/AnnotatedBlock.kt

@@ -0,0 +1,10 @@
+// FIR_IDENTICAL
+// FIR_DUMP
+// ISSUE: KT-52175
+
+annotation class Ann
+
+fun test(x: String?) {
+    if (x != null)
+        @Ann() { Unit }
+}

compiler/testData/diagnostics/tests/annotations/AnnotatedBlock.txt

@@ -0,0 +1,10 @@
+package
+
+public fun test(/*0*/ x: kotlin.String?): kotlin.Unit
+
+public final annotation class Ann : kotlin.Annotation {
+    public constructor Ann()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}

compiler/tests-common-new/tests-gen/org/jetbrains/kotlin/test/runners/DiagnosticTestGenerated.java

@@ -996,6 +996,12 @@ public class DiagnosticTestGenerated extends AbstractDiagnosticTest {
                 runTest("compiler/testData/diagnostics/tests/annotations/AmbigiousAnnotationConstructor.kt");
             }
 
+            @Test
+            @TestMetadata("AnnotatedBlock.kt")
+            public void testAnnotatedBlock() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/annotations/AnnotatedBlock.kt");
+            }
+
             @Test
             @TestMetadata("AnnotatedConstructor.kt")
             public void testAnnotatedConstructor() throws Exception {