azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Lint: Review changes

Browse Source
This commit is contained in:
Yan Zhulanow
2016-04-21 20:00:15 +03:00
parent d7faef63b6
commit 33f9a0c798
13 changed files with 190 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/lint/lint-checks/src/com/android/tools/klint/checks/CleanupDetector.java
+4 -4
View File
@@ -365,9 +365,9 @@ public class CleanupDetector extends Detector implements UastScanner {
// getFragmentManager().beginTransaction().addToBackStack("test")
// .disallowAddToBackStack().hide(mFragment2).setBreadCrumbShortTitle("test")
// .show(mFragment2).setCustomAnimations(0, 0).commit();
List<UExpression> chains = UastUtils.getQualifiedChains(node);
if (chains.size() > 0) {
UExpression lastExpression = chains.get(chains.size() - 1);
List<UExpression> chain = UastUtils.getQualifiedChain(node);
if (chain.size() > 0) {
UExpression lastExpression = chain.get(chain.size() - 1);
if (lastExpression instanceof UCallExpression) {
UCallExpression methodInvocation = (UCallExpression) lastExpression;
if (isTransactionCommitMethodCall(context, methodInvocation)
@@ -418,7 +418,7 @@ public class CleanupDetector extends Detector implements UastScanner {
return null;
}
UQualifiedExpression topMostQualified = UastUtils.findTopMostQualifiedExpression(((UExpression) expression));
UQualifiedExpression topMostQualified = UastUtils.findOutermostQualifiedExpression(((UExpression) expression));
if (topMostQualified == null) {
return null;
}
plugins/lint/lint-checks/src/com/android/tools/klint/checks/ParcelDetector.java
+1 -1
View File
@@ -90,7 +90,7 @@ public class ParcelDetector extends Detector implements UastScanner {
String name = reference.getName();
if (name.equals("Parcelable")) {
UVariable field = UastUtils.findStaticMemberOfType(node, "CREATOR", UVariable.class);
boolean hasField = field != null && field.hasModifier(UastModifier.FIELD);
boolean hasField = field != null && field.hasModifier(UastModifier.JVM_FIELD) && field.hasModifier(UastModifier.STATIC);
boolean hasNamedCompanionObject = false;
if (!hasField) {
for (UClass companion : node.getCompanions()) {