From 32f391aa51b12e379a3e28484270076015d284dd Mon Sep 17 00:00:00 2001 From: Michael Nedzelsky Date: Thu, 18 Sep 2014 18:56:22 +0400 Subject: [PATCH] JS backend: minor improve in NamePredicate: replace list with set --- .../functions/patterns/NamePredicate.java | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/js/js.translator/src/org/jetbrains/k2js/translate/intrinsic/functions/patterns/NamePredicate.java b/js/js.translator/src/org/jetbrains/k2js/translate/intrinsic/functions/patterns/NamePredicate.java index 6d7a6637b23..d234251f85a 100644 --- a/js/js.translator/src/org/jetbrains/k2js/translate/intrinsic/functions/patterns/NamePredicate.java +++ b/js/js.translator/src/org/jetbrains/k2js/translate/intrinsic/functions/patterns/NamePredicate.java @@ -18,6 +18,7 @@ package org.jetbrains.k2js.translate.intrinsic.functions.patterns; import com.google.common.base.Predicate; import com.google.common.collect.Lists; +import com.google.common.collect.Sets; import com.intellij.util.Function; import com.intellij.util.containers.ContainerUtil; import org.jetbrains.annotations.NotNull; @@ -28,6 +29,7 @@ import org.jetbrains.jet.lang.types.lang.PrimitiveType; import java.util.Arrays; import java.util.Collection; import java.util.List; +import java.util.Set; public final class NamePredicate implements Predicate { @@ -44,7 +46,7 @@ public final class NamePredicate implements Predicate { public static final NamePredicate STRING = new NamePredicate("String"); @NotNull - private final List validNames = Lists.newArrayList(); + private final Set validNames = Sets.newHashSet(); public NamePredicate(@NotNull String... validNames) { this(Arrays.asList(validNames)); @@ -66,14 +68,6 @@ public final class NamePredicate implements Predicate { @Override public boolean apply(@Nullable Name name) { - if (name == null) { - return false; - } - for (Name validName : validNames) { - if (name.equals(validName)) { - return true; - } - } - return false; + return name != null && validNames.contains(name); } }