'infix' modifier

This commit is contained in:
Yan Zhulanow
2015-09-29 14:41:34 +03:00
parent 1fbfff97fa
commit 32e2a550b4
54 changed files with 142 additions and 36 deletions
@@ -48,6 +48,7 @@ public class AccessorForConstructorDescriptor(
calleeDescriptor.returnType, calleeDescriptor.returnType,
Modality.FINAL, Modality.FINAL,
Visibilities.INTERNAL, Visibilities.INTERNAL,
false,
false false
) )
} }
@@ -48,7 +48,8 @@ public class AccessorForFunctionDescriptor extends AbstractAccessorForFunctionDe
descriptor.getReturnType(), descriptor.getReturnType(),
Modality.FINAL, Modality.FINAL,
Visibilities.INTERNAL, Visibilities.INTERNAL,
descriptor.isOperator()); descriptor.isOperator(),
descriptor.isInfix());
} }
@NotNull @NotNull
@@ -198,7 +198,7 @@ public class ClosureCodegen extends MemberCodegen<JetElement> {
descriptorForBridges descriptorForBridges
.initialize(null, erasedInterfaceFunction.getDispatchReceiverParameter(), erasedInterfaceFunction.getTypeParameters(), .initialize(null, erasedInterfaceFunction.getDispatchReceiverParameter(), erasedInterfaceFunction.getTypeParameters(),
erasedInterfaceFunction.getValueParameters(), erasedInterfaceFunction.getReturnType(), erasedInterfaceFunction.getValueParameters(), erasedInterfaceFunction.getReturnType(),
Modality.OPEN, erasedInterfaceFunction.getVisibility(), false); Modality.OPEN, erasedInterfaceFunction.getVisibility(), false, false);
descriptorForBridges.addOverriddenDescriptor(erasedInterfaceFunction); descriptorForBridges.addOverriddenDescriptor(erasedInterfaceFunction);
functionCodegen.generateBridges(descriptorForBridges); functionCodegen.generateBridges(descriptorForBridges);
@@ -337,7 +337,7 @@ public abstract class MemberCodegen<T extends JetElement/* TODO: & JetDeclaratio
clInit.initialize(null, null, Collections.<TypeParameterDescriptor>emptyList(), clInit.initialize(null, null, Collections.<TypeParameterDescriptor>emptyList(),
Collections.<ValueParameterDescriptor>emptyList(), Collections.<ValueParameterDescriptor>emptyList(),
DescriptorUtilPackage.getModule(descriptor).getBuiltIns().getUnitType(), DescriptorUtilPackage.getModule(descriptor).getBuiltIns().getUnitType(),
null, Visibilities.PRIVATE, false); null, Visibilities.PRIVATE, false, false);
this.clInit = new ExpressionCodegen(mv, new FrameMap(), Type.VOID_TYPE, context.intoFunction(clInit), state, this); this.clInit = new ExpressionCodegen(mv, new FrameMap(), Type.VOID_TYPE, context.intoFunction(clInit), state, this);
} }
@@ -150,7 +150,7 @@ public class PropertyReferenceCodegen(
SourceElement.NO_SOURCE SourceElement.NO_SOURCE
) )
fakeDescriptor.initialize(null, classDescriptor.getThisAsReceiverParameter(), emptyList(), emptyList(), fakeDescriptor.initialize(null, classDescriptor.getThisAsReceiverParameter(), emptyList(), emptyList(),
classDescriptor.builtIns.getAnyType(), Modality.OPEN, Visibilities.PUBLIC, false) classDescriptor.builtIns.getAnyType(), Modality.OPEN, Visibilities.PUBLIC, false, false)
val fakeCodegen = ExpressionCodegen( val fakeCodegen = ExpressionCodegen(
this, FrameMap(), OBJECT_TYPE, context.intoFunction(fakeDescriptor), state, this@PropertyReferenceCodegen this, FrameMap(), OBJECT_TYPE, context.intoFunction(fakeDescriptor), state, this@PropertyReferenceCodegen
@@ -163,7 +163,7 @@ public class SamWrapperCodegen {
descriptorForBridges descriptorForBridges
.initialize(null, originalInterfaceErased.getDispatchReceiverParameter(), originalInterfaceErased.getTypeParameters(), .initialize(null, originalInterfaceErased.getDispatchReceiverParameter(), originalInterfaceErased.getTypeParameters(),
originalInterfaceErased.getValueParameters(), originalInterfaceErased.getReturnType(), originalInterfaceErased.getValueParameters(), originalInterfaceErased.getReturnType(),
Modality.OPEN, originalInterfaceErased.getVisibility(), false); Modality.OPEN, originalInterfaceErased.getVisibility(), false, false);
descriptorForBridges.addOverriddenDescriptor(originalInterfaceErased); descriptorForBridges.addOverriddenDescriptor(originalInterfaceErased);
codegen.generateBridges(descriptorForBridges); codegen.generateBridges(descriptorForBridges);
@@ -171,6 +171,7 @@ public class SingleAbstractMethodUtils {
returnType, returnType,
Modality.FINAL, Modality.FINAL,
samInterface.getVisibility(), samInterface.getVisibility(),
false,
false false
); );
@@ -208,6 +209,7 @@ public class SingleAbstractMethodUtils {
returnType, returnType,
Modality.FINAL, Modality.FINAL,
original.getVisibility(), original.getVisibility(),
false,
false false
); );
} }
@@ -117,6 +117,7 @@ public class SignaturesPropagationData {
autoReturnType, autoReturnType,
Modality.OPEN, Modality.OPEN,
Visibilities.PUBLIC, Visibilities.PUBLIC,
false,
false false
); );
return autoMethodDescriptor; return autoMethodDescriptor;
@@ -128,7 +128,8 @@ class SamAdapterFunctionsScope(storageManager: StorageManager) : JetScope by Jet
val visibility = syntheticExtensionVisibility(sourceFunction) val visibility = syntheticExtensionVisibility(sourceFunction)
descriptor.initialize(receiverType, null, typeParameters, valueParameters, returnType, Modality.FINAL, visibility, false) descriptor.initialize(receiverType, null, typeParameters, valueParameters, returnType,
Modality.FINAL, visibility, false, false)
return descriptor return descriptor
} }
@@ -149,6 +150,7 @@ class SamAdapterFunctionsScope(storageManager: StorageManager) : JetScope by Jet
newModality: Modality, newModality: Modality,
newVisibility: Visibility, newVisibility: Visibility,
newIsOperator: Boolean, newIsOperator: Boolean,
newIsInfix: Boolean,
original: FunctionDescriptor?, original: FunctionDescriptor?,
copyOverrides: Boolean, copyOverrides: Boolean,
kind: CallableMemberDescriptor.Kind, kind: CallableMemberDescriptor.Kind,
@@ -157,7 +159,7 @@ class SamAdapterFunctionsScope(storageManager: StorageManager) : JetScope by Jet
newReturnType: JetType newReturnType: JetType
): FunctionDescriptor? { ): FunctionDescriptor? {
val descriptor = super<SimpleFunctionDescriptorImpl>.doSubstitute( val descriptor = super<SimpleFunctionDescriptorImpl>.doSubstitute(
originalSubstitutor, newOwner, newModality, newVisibility, newIsOperator, original, originalSubstitutor, newOwner, newModality, newVisibility, newIsOperator, newIsInfix, original,
copyOverrides, kind, newValueParameterDescriptors, newExtensionReceiverParameterType, newReturnType) copyOverrides, kind, newValueParameterDescriptors, newExtensionReceiverParameterType, newReturnType)
as MyFunctionDescriptor? ?: return null as MyFunctionDescriptor? ?: return null
@@ -177,6 +177,7 @@ public interface JetTokens {
JetModifierKeywordToken ANNOTATION_KEYWORD = JetModifierKeywordToken.softKeywordModifier("annotation"); JetModifierKeywordToken ANNOTATION_KEYWORD = JetModifierKeywordToken.softKeywordModifier("annotation");
JetModifierKeywordToken CROSSINLINE_KEYWORD = JetModifierKeywordToken.softKeywordModifier("crossinline"); JetModifierKeywordToken CROSSINLINE_KEYWORD = JetModifierKeywordToken.softKeywordModifier("crossinline");
JetModifierKeywordToken OPERATOR_KEYWORD = JetModifierKeywordToken.softKeywordModifier("operator"); JetModifierKeywordToken OPERATOR_KEYWORD = JetModifierKeywordToken.softKeywordModifier("operator");
JetModifierKeywordToken INFIX_KEYWORD = JetModifierKeywordToken.softKeywordModifier("infix");
JetModifierKeywordToken CONST_KEYWORD = JetModifierKeywordToken.softKeywordModifier("const"); JetModifierKeywordToken CONST_KEYWORD = JetModifierKeywordToken.softKeywordModifier("const");
@@ -197,7 +198,7 @@ public interface JetTokens {
FIELD_KEYWORD, PROPERTY_KEYWORD, RECEIVER_KEYWORD, PARAM_KEYWORD, SPARAM_KEYWORD, FIELD_KEYWORD, PROPERTY_KEYWORD, RECEIVER_KEYWORD, PARAM_KEYWORD, SPARAM_KEYWORD,
LATE_INIT_KEYWORD, LATE_INIT_KEYWORD,
DATA_KEYWORD, INLINE_KEYWORD, NOINLINE_KEYWORD, TAILREC_KEYWORD, EXTERNAL_KEYWORD, DATA_KEYWORD, INLINE_KEYWORD, NOINLINE_KEYWORD, TAILREC_KEYWORD, EXTERNAL_KEYWORD,
ANNOTATION_KEYWORD, CROSSINLINE_KEYWORD, CONST_KEYWORD, OPERATOR_KEYWORD ANNOTATION_KEYWORD, CROSSINLINE_KEYWORD, CONST_KEYWORD, OPERATOR_KEYWORD, INFIX_KEYWORD
); );
/* /*
@@ -211,7 +212,7 @@ public interface JetTokens {
PUBLIC_KEYWORD, INTERNAL_KEYWORD, PROTECTED_KEYWORD, OUT_KEYWORD, IN_KEYWORD, FINAL_KEYWORD, VARARG_KEYWORD, PUBLIC_KEYWORD, INTERNAL_KEYWORD, PROTECTED_KEYWORD, OUT_KEYWORD, IN_KEYWORD, FINAL_KEYWORD, VARARG_KEYWORD,
REIFIED_KEYWORD, COMPANION_KEYWORD, SEALED_KEYWORD, LATE_INIT_KEYWORD, REIFIED_KEYWORD, COMPANION_KEYWORD, SEALED_KEYWORD, LATE_INIT_KEYWORD,
DATA_KEYWORD, INLINE_KEYWORD, NOINLINE_KEYWORD, TAILREC_KEYWORD, EXTERNAL_KEYWORD, ANNOTATION_KEYWORD, CROSSINLINE_KEYWORD, DATA_KEYWORD, INLINE_KEYWORD, NOINLINE_KEYWORD, TAILREC_KEYWORD, EXTERNAL_KEYWORD, ANNOTATION_KEYWORD, CROSSINLINE_KEYWORD,
CONST_KEYWORD, OPERATOR_KEYWORD CONST_KEYWORD, OPERATOR_KEYWORD, INFIX_KEYWORD
}; };
// Please synchronize this array with org.jetbrains.kotlin.descriptors.annotations.ANNOTATION_MODIFIERS_FQ_NAMES // Please synchronize this array with org.jetbrains.kotlin.descriptors.annotations.ANNOTATION_MODIFIERS_FQ_NAMES
@@ -34,7 +34,7 @@ import org.jetbrains.kotlin.psi.stubs.KotlinFileStub;
import java.io.IOException; import java.io.IOException;
public class JetFileElementType extends IStubFileElementType<KotlinFileStub> { public class JetFileElementType extends IStubFileElementType<KotlinFileStub> {
public static final int STUB_VERSION = 59; public static final int STUB_VERSION = 60;
private static final String NAME = "kotlin.FILE"; private static final String NAME = "kotlin.FILE";
@@ -242,7 +242,8 @@ public class DescriptorResolver {
returnType, returnType,
Modality.FINAL, Modality.FINAL,
property.getVisibility(), property.getVisibility(),
true true,
false
); );
trace.record(BindingContext.DATA_CLASS_COMPONENT_FUNCTION, parameter, functionDescriptor); trace.record(BindingContext.DATA_CLASS_COMPONENT_FUNCTION, parameter, functionDescriptor);
@@ -291,6 +292,7 @@ public class DescriptorResolver {
returnType, returnType,
Modality.FINAL, Modality.FINAL,
Visibilities.PUBLIC, Visibilities.PUBLIC,
false,
false false
); );
@@ -173,7 +173,8 @@ class FunctionDescriptorResolver(
returnType, returnType,
modality, modality,
visibility, visibility,
function.hasModifier(JetTokens.OPERATOR_KEYWORD) function.hasModifier(JetTokens.OPERATOR_KEYWORD),
function.hasModifier(JetTokens.INFIX_KEYWORD)
) )
receiverType?.let { ForceResolveUtil.forceResolveAllContents(it.getAnnotations()) } receiverType?.let { ForceResolveUtil.forceResolveAllContents(it.getAnnotations()) }
for (valueParameterDescriptor in valueParameterDescriptors) { for (valueParameterDescriptor in valueParameterDescriptors) {
@@ -104,6 +104,7 @@ public class FunctionDescriptorUtil {
KotlinBuiltIns.getReturnTypeFromFunctionType(functionType), KotlinBuiltIns.getReturnTypeFromFunctionType(functionType),
modality, modality,
visibility, visibility,
false,
false); false);
} }
@@ -157,7 +158,8 @@ public class FunctionDescriptorUtil {
function.getReturnType(), function.getReturnType(),
function.getModality(), function.getModality(),
function.getVisibility(), function.getVisibility(),
function.isOperator()); function.isOperator(),
function.isInfix());
return descriptor; return descriptor;
} }
} }
@@ -76,7 +76,8 @@ public object ModifierCheckerCore {
ANNOTATION_KEYWORD to EnumSet.of(ANNOTATION_CLASS), ANNOTATION_KEYWORD to EnumSet.of(ANNOTATION_CLASS),
CROSSINLINE_KEYWORD to EnumSet.of(VALUE_PARAMETER), CROSSINLINE_KEYWORD to EnumSet.of(VALUE_PARAMETER),
CONST_KEYWORD to EnumSet.of(MEMBER_PROPERTY, TOP_LEVEL_PROPERTY), CONST_KEYWORD to EnumSet.of(MEMBER_PROPERTY, TOP_LEVEL_PROPERTY),
OPERATOR_KEYWORD to EnumSet.of(FUNCTION) OPERATOR_KEYWORD to EnumSet.of(FUNCTION),
INFIX_KEYWORD to EnumSet.of(FUNCTION)
) )
// NOTE: redundant targets must be possible! // NOTE: redundant targets must be possible!
@@ -130,6 +130,7 @@ object DynamicCallableDescriptors {
DynamicType, DynamicType,
Modality.FINAL, Modality.FINAL,
Visibilities.PUBLIC, Visibilities.PUBLIC,
false,
false false
) )
return functionDescriptor return functionDescriptor
@@ -81,7 +81,8 @@ private fun createSynthesizedFunctionWithFirstParameterAsReceiver(descriptor: Fu
original.getReturnType(), original.getReturnType(),
original.getModality(), original.getModality(),
original.getVisibility(), original.getVisibility(),
original.isOperator original.isOperator,
original.isInfix
) )
return result return result
@@ -125,6 +125,7 @@ public class ControlStructureTypingUtils {
type, type,
Modality.FINAL, Modality.FINAL,
Visibilities.PUBLIC, Visibilities.PUBLIC,
false,
false false
); );
return function; return function;
@@ -173,9 +173,12 @@ public class DescriptorSerializer {
boolean lateInit = false; boolean lateInit = false;
boolean isConst = false; boolean isConst = false;
boolean isOperator = false; boolean isOperator = false;
boolean isInfix = false;
if (descriptor instanceof FunctionDescriptor) { if (descriptor instanceof FunctionDescriptor) {
isOperator = ((FunctionDescriptor) descriptor).isOperator(); FunctionDescriptor functionDescriptor = (FunctionDescriptor) descriptor;
isOperator = functionDescriptor.isOperator();
isInfix = functionDescriptor.isInfix();
} }
if (descriptor instanceof PropertyDescriptor) { if (descriptor instanceof PropertyDescriptor) {
@@ -233,7 +236,8 @@ public class DescriptorSerializer {
hasConstant, hasConstant,
lateInit, lateInit,
isConst, isConst,
isOperator isOperator,
isInfix
)); ));
for (TypeParameterDescriptor typeParameterDescriptor : descriptor.getTypeParameters()) { for (TypeParameterDescriptor typeParameterDescriptor : descriptor.getTypeParameters()) {
@@ -0,0 +1,5 @@
package test
class Example {
infix fun test(other: Example) {}
}
@@ -0,0 +1,6 @@
package test
public final class Example {
/*primary*/ public constructor Example()
public final infix fun test(/*0*/ other: test.Example): kotlin.Unit
}
@@ -4048,6 +4048,12 @@ public class LoadJavaTestGenerated extends AbstractLoadJavaTest {
doTestCompiledKotlin(fileName); doTestCompiledKotlin(fileName);
} }
@TestMetadata("InfixKeyword.kt")
public void testInfixKeyword() throws Exception {
String fileName = JetTestUtils.navigationMetadata("compiler/testData/loadJava/compiledKotlin/fun/InfixKeyword.kt");
doTestCompiledKotlin(fileName);
}
@TestMetadata("InheritMethodsDifferentReturnTypesAndVisibilities.kt") @TestMetadata("InheritMethodsDifferentReturnTypesAndVisibilities.kt")
public void testInheritMethodsDifferentReturnTypesAndVisibilities() throws Exception { public void testInheritMethodsDifferentReturnTypesAndVisibilities() throws Exception {
String fileName = JetTestUtils.navigationMetadata("compiler/testData/loadJava/compiledKotlin/fun/InheritMethodsDifferentReturnTypesAndVisibilities.kt"); String fileName = JetTestUtils.navigationMetadata("compiler/testData/loadJava/compiledKotlin/fun/InheritMethodsDifferentReturnTypesAndVisibilities.kt");
@@ -2157,6 +2157,12 @@ public class JvmRuntimeDescriptorLoaderTestGenerated extends AbstractJvmRuntimeD
doTest(fileName); doTest(fileName);
} }
@TestMetadata("InfixKeyword.kt")
public void testInfixKeyword() throws Exception {
String fileName = JetTestUtils.navigationMetadata("compiler/testData/loadJava/compiledKotlin/fun/InfixKeyword.kt");
doTest(fileName);
}
@TestMetadata("InheritMethodsDifferentReturnTypesAndVisibilities.kt") @TestMetadata("InheritMethodsDifferentReturnTypesAndVisibilities.kt")
public void testInheritMethodsDifferentReturnTypesAndVisibilities() throws Exception { public void testInheritMethodsDifferentReturnTypesAndVisibilities() throws Exception {
String fileName = JetTestUtils.navigationMetadata("compiler/testData/loadJava/compiledKotlin/fun/InheritMethodsDifferentReturnTypesAndVisibilities.kt"); String fileName = JetTestUtils.navigationMetadata("compiler/testData/loadJava/compiledKotlin/fun/InheritMethodsDifferentReturnTypesAndVisibilities.kt");
@@ -110,6 +110,7 @@ public class JavaConstructorDescriptor extends ConstructorDescriptorImpl impleme
enhancedReturnType, enhancedReturnType,
getModality(), getModality(),
getVisibility(), getVisibility(),
false,
false false
); );
@@ -122,7 +122,7 @@ public class JavaMethodDescriptor extends SimpleFunctionDescriptorImpl implement
// 1. creates full copy of descriptor // 1. creates full copy of descriptor
// 2. copies method's type parameters (with new containing declaration) and properly substitute to them in value parameters, return type and etc. // 2. copies method's type parameters (with new containing declaration) and properly substitute to them in value parameters, return type and etc.
JavaMethodDescriptor enhancedMethod = (JavaMethodDescriptor) doSubstitute( JavaMethodDescriptor enhancedMethod = (JavaMethodDescriptor) doSubstitute(
TypeSubstitutor.EMPTY, getContainingDeclaration(), getModality(), getVisibility(), false, getOriginal(), TypeSubstitutor.EMPTY, getContainingDeclaration(), getModality(), getVisibility(), false, false, getOriginal(),
/* copyOverrides = */ true, getKind(), /* copyOverrides = */ true, getKind(),
enhancedValueParameters, enhancedReceiverType, enhancedReturnType enhancedValueParameters, enhancedReceiverType, enhancedReturnType
); );
@@ -127,6 +127,7 @@ public abstract class LazyJavaScope(
effectiveSignature.getReturnType(), effectiveSignature.getReturnType(),
Modality.convertFromFlags(method.isAbstract(), !method.isFinal()), Modality.convertFromFlags(method.isAbstract(), !method.isFinal()),
method.getVisibility(), method.getVisibility(),
false,
false false
) )
@@ -61,7 +61,8 @@ public class FunctionInvokeDescriptor private constructor(
typeParameters.last().getDefaultType(), typeParameters.last().getDefaultType(),
Modality.ABSTRACT, Modality.ABSTRACT,
Visibilities.PUBLIC, Visibilities.PUBLIC,
true true,
false
) )
return result return result
} }
@@ -42,4 +42,6 @@ public interface FunctionDescriptor extends CallableMemberDescriptor {
FunctionDescriptor copy(DeclarationDescriptor newOwner, Modality modality, Visibility visibility, Kind kind, boolean copyOverrides); FunctionDescriptor copy(DeclarationDescriptor newOwner, Modality modality, Visibility visibility, Kind kind, boolean copyOverrides);
boolean isOperator(); boolean isOperator();
boolean isInfix();
} }
@@ -60,7 +60,7 @@ public class ConstructorDescriptorImpl extends FunctionDescriptorImpl implements
@NotNull Visibility visibility @NotNull Visibility visibility
) { ) {
super.initialize(null, calculateDispatchReceiverParameter(), typeParameters, unsubstitutedValueParameters, null, super.initialize(null, calculateDispatchReceiverParameter(), typeParameters, unsubstitutedValueParameters, null,
Modality.FINAL, visibility, false); Modality.FINAL, visibility, false, false);
return this; return this;
} }
@@ -43,6 +43,7 @@ public abstract class FunctionDescriptorImpl extends DeclarationDescriptorNonRoo
private Modality modality; private Modality modality;
private Visibility visibility = Visibilities.UNKNOWN; private Visibility visibility = Visibilities.UNKNOWN;
private boolean isOperator; private boolean isOperator;
private boolean isInfix;
private final Set<FunctionDescriptor> overriddenFunctions = SmartSet.create(); private final Set<FunctionDescriptor> overriddenFunctions = SmartSet.create();
private final FunctionDescriptor original; private final FunctionDescriptor original;
private final Kind kind; private final Kind kind;
@@ -69,7 +70,8 @@ public abstract class FunctionDescriptorImpl extends DeclarationDescriptorNonRoo
@Nullable JetType unsubstitutedReturnType, @Nullable JetType unsubstitutedReturnType,
@Nullable Modality modality, @Nullable Modality modality,
@NotNull Visibility visibility, @NotNull Visibility visibility,
boolean isOperator boolean isOperator,
boolean isInfix
) { ) {
this.typeParameters = UtilsPackage.toReadOnlyList(typeParameters); this.typeParameters = UtilsPackage.toReadOnlyList(typeParameters);
this.unsubstitutedValueParameters = unsubstitutedValueParameters; this.unsubstitutedValueParameters = unsubstitutedValueParameters;
@@ -77,6 +79,7 @@ public abstract class FunctionDescriptorImpl extends DeclarationDescriptorNonRoo
this.modality = modality; this.modality = modality;
this.visibility = visibility; this.visibility = visibility;
this.isOperator = isOperator; this.isOperator = isOperator;
this.isInfix = isInfix;
this.extensionReceiverParameter = DescriptorFactory.createExtensionReceiverParameterForCallable(this, receiverParameterType); this.extensionReceiverParameter = DescriptorFactory.createExtensionReceiverParameterForCallable(this, receiverParameterType);
this.dispatchReceiverParameter = dispatchReceiverParameter; this.dispatchReceiverParameter = dispatchReceiverParameter;
@@ -152,6 +155,17 @@ public abstract class FunctionDescriptorImpl extends DeclarationDescriptorNonRoo
return false; return false;
} }
@Override
public boolean isInfix() {
if (isInfix) return true;
for (FunctionDescriptor descriptor : overriddenFunctions) {
if (descriptor.isInfix()) return true;
}
return false;
}
@Override @Override
public void addOverriddenDescriptor(@NotNull CallableMemberDescriptor overriddenFunction) { public void addOverriddenDescriptor(@NotNull CallableMemberDescriptor overriddenFunction) {
overriddenFunctions.add((FunctionDescriptor) overriddenFunction); overriddenFunctions.add((FunctionDescriptor) overriddenFunction);
@@ -201,7 +215,7 @@ public abstract class FunctionDescriptorImpl extends DeclarationDescriptorNonRoo
if (originalSubstitutor.isEmpty()) { if (originalSubstitutor.isEmpty()) {
return this; return this;
} }
return doSubstitute(originalSubstitutor, getContainingDeclaration(), modality, visibility, isOperator, getOriginal(), true, getKind()); return doSubstitute(originalSubstitutor, getContainingDeclaration(), modality, visibility, isOperator, isInfix, getOriginal(), true, getKind());
} }
@Nullable @Nullable
@@ -210,12 +224,13 @@ public abstract class FunctionDescriptorImpl extends DeclarationDescriptorNonRoo
@NotNull Modality newModality, @NotNull Modality newModality,
@NotNull Visibility newVisibility, @NotNull Visibility newVisibility,
boolean isOperator, boolean isOperator,
boolean isInfix,
@Nullable FunctionDescriptor original, @Nullable FunctionDescriptor original,
boolean copyOverrides, boolean copyOverrides,
@NotNull Kind kind @NotNull Kind kind
) { ) {
return doSubstitute(originalSubstitutor, return doSubstitute(originalSubstitutor,
newOwner, newModality, newVisibility, isOperator, original, copyOverrides, kind, newOwner, newModality, newVisibility, isOperator, isInfix, original, copyOverrides, kind,
getValueParameters(), getExtensionReceiverParameterType(), getReturnType() getValueParameters(), getExtensionReceiverParameterType(), getReturnType()
); );
} }
@@ -233,6 +248,7 @@ public abstract class FunctionDescriptorImpl extends DeclarationDescriptorNonRoo
@NotNull Modality newModality, @NotNull Modality newModality,
@NotNull Visibility newVisibility, @NotNull Visibility newVisibility,
boolean isOperator, boolean isOperator,
boolean isInfix,
@Nullable FunctionDescriptor original, @Nullable FunctionDescriptor original,
boolean copyOverrides, boolean copyOverrides,
@NotNull Kind kind, @NotNull Kind kind,
@@ -294,7 +310,8 @@ public abstract class FunctionDescriptorImpl extends DeclarationDescriptorNonRoo
substitutedReturnType, substitutedReturnType,
newModality, newModality,
newVisibility, newVisibility,
isOperator isOperator,
isInfix
); );
if (copyOverrides) { if (copyOverrides) {
@@ -78,6 +78,11 @@ public abstract class PropertyAccessorDescriptorImpl extends DeclarationDescript
return false; return false;
} }
@Override
public boolean isInfix() {
return false;
}
@NotNull @NotNull
@Override @Override
public FunctionDescriptor substitute(@NotNull TypeSubstitutor substitutor) { public FunctionDescriptor substitute(@NotNull TypeSubstitutor substitutor) {
@@ -37,7 +37,7 @@ public class ScriptCodeDescriptor extends FunctionDescriptorImpl {
@NotNull List<ValueParameterDescriptor> valueParameters, @NotNull List<ValueParameterDescriptor> valueParameters,
@NotNull JetType returnType) { @NotNull JetType returnType) {
super.initialize(null, dispatchReceiverParameter, Collections.<TypeParameterDescriptor>emptyList(), valueParameters, returnType, super.initialize(null, dispatchReceiverParameter, Collections.<TypeParameterDescriptor>emptyList(), valueParameters, returnType,
Modality.FINAL, Visibilities.INTERNAL, /*isOperator =*/ false); Modality.FINAL, Visibilities.INTERNAL, false, false);
} }
@NotNull @NotNull
@@ -59,10 +59,11 @@ public class SimpleFunctionDescriptorImpl extends FunctionDescriptorImpl impleme
@Nullable JetType unsubstitutedReturnType, @Nullable JetType unsubstitutedReturnType,
@Nullable Modality modality, @Nullable Modality modality,
@NotNull Visibility visibility, @NotNull Visibility visibility,
boolean isOperator boolean isOperator,
boolean isInfix
) { ) {
super.initialize(receiverParameterType, dispatchReceiverParameter, typeParameters, unsubstitutedValueParameters, super.initialize(receiverParameterType, dispatchReceiverParameter, typeParameters, unsubstitutedValueParameters,
unsubstitutedReturnType, modality, visibility, isOperator); unsubstitutedReturnType, modality, visibility, isOperator, isInfix);
return this; return this;
} }
@@ -100,7 +101,7 @@ public class SimpleFunctionDescriptorImpl extends FunctionDescriptorImpl impleme
boolean copyOverrides boolean copyOverrides
) { ) {
return (SimpleFunctionDescriptorImpl) doSubstitute( return (SimpleFunctionDescriptorImpl) doSubstitute(
TypeSubstitutor.EMPTY, newOwner, modality, visibility, isOperator(), null, copyOverrides, kind TypeSubstitutor.EMPTY, newOwner, modality, visibility, isOperator(), isInfix(), null, copyOverrides, kind
); );
} }
} }
@@ -461,10 +461,13 @@ internal class DescriptorRendererImpl(
} }
} }
private fun renderOperator(functionDescriptor: FunctionDescriptor, builder: StringBuilder) { private fun renderAdditionalModifiers(functionDescriptor: FunctionDescriptor, builder: StringBuilder) {
if (functionDescriptor.isOperator && functionDescriptor.overriddenDescriptors.none { it.isOperator }) { if (functionDescriptor.isOperator && functionDescriptor.overriddenDescriptors.none { it.isOperator }) {
builder.append("operator ") builder.append("operator ")
} }
if (functionDescriptor.isInfix && functionDescriptor.overriddenDescriptors.none { it.isInfix }) {
builder.append("infix ")
}
} }
override fun render(declarationDescriptor: DeclarationDescriptor): String { override fun render(declarationDescriptor: DeclarationDescriptor): String {
@@ -554,7 +557,7 @@ internal class DescriptorRendererImpl(
renderAnnotations(function, builder) renderAnnotations(function, builder)
renderVisibility(function.getVisibility(), builder) renderVisibility(function.getVisibility(), builder)
renderModalityForCallable(function, builder) renderModalityForCallable(function, builder)
renderOperator(function, builder) renderAdditionalModifiers(function, builder)
renderOverride(function, builder) renderOverride(function, builder)
renderMemberKind(function, builder) renderMemberKind(function, builder)
@@ -103,7 +103,7 @@ public class DescriptorFactory {
return values.initialize(null, null, Collections.<TypeParameterDescriptor>emptyList(), return values.initialize(null, null, Collections.<TypeParameterDescriptor>emptyList(),
Collections.<ValueParameterDescriptor>emptyList(), Collections.<ValueParameterDescriptor>emptyList(),
getBuiltIns(enumClass).getArrayType(Variance.INVARIANT, enumClass.getDefaultType()), getBuiltIns(enumClass).getArrayType(Variance.INVARIANT, enumClass.getDefaultType()),
Modality.FINAL, Visibilities.PUBLIC, false); Modality.FINAL, Visibilities.PUBLIC, false, false);
} }
@NotNull @NotNull
@@ -117,7 +117,7 @@ public class DescriptorFactory {
); );
return valueOf.initialize(null, null, Collections.<TypeParameterDescriptor>emptyList(), return valueOf.initialize(null, null, Collections.<TypeParameterDescriptor>emptyList(),
Collections.singletonList(parameterDescriptor), enumClass.getDefaultType(), Collections.singletonList(parameterDescriptor), enumClass.getDefaultType(),
Modality.FINAL, Visibilities.PUBLIC, false); Modality.FINAL, Visibilities.PUBLIC, false, false);
} }
@Nullable @Nullable
@@ -424,6 +424,7 @@ public class ErrorUtils {
createErrorType("<ERROR FUNCTION RETURN TYPE>"), createErrorType("<ERROR FUNCTION RETURN TYPE>"),
Modality.OPEN, Modality.OPEN,
Visibilities.INTERNAL, Visibilities.INTERNAL,
false,
false false
); );
return function; return function;
@@ -238,6 +238,7 @@ message Callable {
isConst isConst
lateinit lateinit
isOperator isOperator
isInfix
*/ */
optional int32 flags = 1; optional int32 flags = 1;
@@ -54,6 +54,8 @@ public class Flags {
public static final FlagField<Boolean> IS_OPERATOR = FlagField.booleanAfter(LATE_INIT); public static final FlagField<Boolean> IS_OPERATOR = FlagField.booleanAfter(LATE_INIT);
public static final FlagField<Boolean> IS_INFIX = FlagField.booleanAfter(IS_OPERATOR);
// Parameters // Parameters
public static final FlagField<Boolean> DECLARES_DEFAULT_VALUE = FlagField.booleanAfter(HAS_ANNOTATIONS); public static final FlagField<Boolean> DECLARES_DEFAULT_VALUE = FlagField.booleanAfter(HAS_ANNOTATIONS);
@@ -121,7 +123,8 @@ public class Flags {
boolean hasConstant, boolean hasConstant,
boolean lateInit, boolean lateInit,
boolean isConst, boolean isConst,
boolean isOperator boolean isOperator,
boolean isInfix
) { ) {
return HAS_ANNOTATIONS.toFlags(hasAnnotations) return HAS_ANNOTATIONS.toFlags(hasAnnotations)
| MODALITY.toFlags(modality(modality)) | MODALITY.toFlags(modality(modality))
@@ -134,6 +137,7 @@ public class Flags {
| LATE_INIT.toFlags(lateInit) | LATE_INIT.toFlags(lateInit)
| IS_CONST.toFlags(isConst) | IS_CONST.toFlags(isConst)
| IS_OPERATOR.toFlags(isOperator) | IS_OPERATOR.toFlags(isOperator)
| IS_INFIX.toFlags(isInfix)
; ;
} }
@@ -151,7 +151,8 @@ public class MemberDeserializer(private val c: DeserializationContext) {
local.typeDeserializer.type(proto.returnType), local.typeDeserializer.type(proto.returnType),
Deserialization.modality(Flags.MODALITY.get(proto.flags)), Deserialization.modality(Flags.MODALITY.get(proto.flags)),
Deserialization.visibility(Flags.VISIBILITY.get(proto.flags)), Deserialization.visibility(Flags.VISIBILITY.get(proto.flags)),
Flags.IS_OPERATOR.get(proto.flags) Flags.IS_OPERATOR.get(proto.flags),
Flags.IS_INFIX.get(proto.flags)
) )
return function return function
} }
@@ -99,7 +99,7 @@ private class CallableClsStubBuilder(
val constModifiers = if (callableKind == CallableKind.VAL) listOf(CONST) else listOf() val constModifiers = if (callableKind == CallableKind.VAL) listOf(CONST) else listOf()
val additionalModifiers = when (callableKind) { val additionalModifiers = when (callableKind) {
CallableKind.FUN -> arrayOf(OPERATOR) CallableKind.FUN -> arrayOf(OPERATOR, INFIX)
CallableKind.VAL, CallableKind.VAR -> arrayOf(LATEINIT) CallableKind.VAL, CallableKind.VAR -> arrayOf(LATEINIT)
else -> emptyArray<FlagsToModifiers>() else -> emptyArray<FlagsToModifiers>()
} }
@@ -202,6 +202,12 @@ enum class FlagsToModifiers {
override fun getModifiers(flags: Int): JetModifierKeywordToken? { override fun getModifiers(flags: Int): JetModifierKeywordToken? {
return if (Flags.IS_OPERATOR.get(flags)) JetTokens.OPERATOR_KEYWORD else null return if (Flags.IS_OPERATOR.get(flags)) JetTokens.OPERATOR_KEYWORD else null
} }
},
INFIX {
override fun getModifiers(flags: Int): JetModifierKeywordToken? {
return if (Flags.IS_INFIX.get(flags)) JetTokens.INFIX_KEYWORD else null
}
}; };
abstract fun getModifiers(flags: Int): JetModifierKeywordToken? abstract fun getModifiers(flags: Int): JetModifierKeywordToken?
@@ -35,6 +35,7 @@ class MouseMovedEventArgs
/*why?*/ /*why?*/
// EXIST: companion object // EXIST: companion object
// EXIST: operator // EXIST: operator
// EXIST: infix
// EXIST: sealed // EXIST: sealed
// EXIST: lateinit // EXIST: lateinit
// EXIST: data // EXIST: data
@@ -38,6 +38,7 @@ class B {
/*why?*/ /*why?*/
// EXIST: companion object // EXIST: companion object
// EXIST: operator // EXIST: operator
// EXIST: infix
// EXIST: sealed // EXIST: sealed
// EXIST: lateinit // EXIST: lateinit
// EXIST: data // EXIST: data
+1
View File
@@ -38,6 +38,7 @@ class A {
/*why?*/ /*why?*/
// EXIST: companion object // EXIST: companion object
// EXIST: operator // EXIST: operator
// EXIST: infix
// EXIST: sealed // EXIST: sealed
// EXIST: lateinit // EXIST: lateinit
// EXIST: data // EXIST: data
@@ -38,6 +38,7 @@ var a : Int
/*why?*/ /*why?*/
// EXIST: companion object // EXIST: companion object
// EXIST: operator // EXIST: operator
// EXIST: infix
// EXIST: sealed // EXIST: sealed
// EXIST: lateinit // EXIST: lateinit
// EXIST: data // EXIST: data
@@ -36,6 +36,7 @@ public class Test {
/*why?*/ /*why?*/
// EXIST: companion object // EXIST: companion object
// EXIST: operator // EXIST: operator
// EXIST: infix
// EXIST: sealed // EXIST: sealed
// EXIST: lateinit // EXIST: lateinit
// EXIST: data // EXIST: data
@@ -30,6 +30,7 @@ class TestClass {
// EXIST: init // EXIST: init
// EXIST: companion object // EXIST: companion object
// EXIST: operator // EXIST: operator
// EXIST: infix
// EXIST: sealed // EXIST: sealed
// EXIST: lateinit // EXIST: lateinit
// EXIST: data // EXIST: data
@@ -29,6 +29,7 @@ package Test
/*why?*/ /*why?*/
// EXIST: companion object // EXIST: companion object
// EXIST: operator // EXIST: operator
// EXIST: infix
// EXIST: sealed // EXIST: sealed
// EXIST: lateinit // EXIST: lateinit
// EXIST: data // EXIST: data
@@ -34,6 +34,7 @@ class Some {
// EXIST: init // EXIST: init
// EXIST: companion object // EXIST: companion object
// EXIST: operator // EXIST: operator
// EXIST: infix
// EXIST: sealed // EXIST: sealed
// EXIST: lateinit // EXIST: lateinit
// EXIST: data // EXIST: data
@@ -34,6 +34,7 @@ class Some {
// EXIST: init // EXIST: init
// EXIST: companion object // EXIST: companion object
// EXIST: operator // EXIST: operator
// EXIST: infix
// EXIST: sealed // EXIST: sealed
// EXIST: lateinit // EXIST: lateinit
// EXIST: data // EXIST: data
@@ -36,6 +36,7 @@ class Some {
// EXIST: init // EXIST: init
// EXIST: companion object // EXIST: companion object
// EXIST: operator // EXIST: operator
// EXIST: infix
// EXIST: sealed // EXIST: sealed
// EXIST: lateinit // EXIST: lateinit
// EXIST: data // EXIST: data
+1
View File
@@ -28,6 +28,7 @@
/*why?*/ /*why?*/
// EXIST: companion object // EXIST: companion object
// EXIST: operator // EXIST: operator
// EXIST: infix
// EXIST: sealed // EXIST: sealed
// EXIST: lateinit // EXIST: lateinit
// EXIST: data // EXIST: data
@@ -415,7 +415,8 @@ class CallableBuilder(val config: CallableBuilderConfiguration) {
) )
} }
return fakeFunction.initialize(null, null, typeParameters, Collections.emptyList(), null, null, Visibilities.INTERNAL, false) return fakeFunction.initialize(null, null, typeParameters, Collections.emptyList(), null,
null, Visibilities.INTERNAL, false, false)
} }
private fun renderTypeCandidates( private fun renderTypeCandidates(
@@ -2155,6 +2155,12 @@ public class ResolveByStubTestGenerated extends AbstractResolveByStubTest {
doTest(fileName); doTest(fileName);
} }
@TestMetadata("InfixKeyword.kt")
public void testInfixKeyword() throws Exception {
String fileName = JetTestUtils.navigationMetadata("compiler/testData/loadJava/compiledKotlin/fun/InfixKeyword.kt");
doTest(fileName);
}
@TestMetadata("InheritMethodsDifferentReturnTypesAndVisibilities.kt") @TestMetadata("InheritMethodsDifferentReturnTypesAndVisibilities.kt")
public void testInheritMethodsDifferentReturnTypesAndVisibilities() throws Exception { public void testInheritMethodsDifferentReturnTypesAndVisibilities() throws Exception {
String fileName = JetTestUtils.navigationMetadata("compiler/testData/loadJava/compiledKotlin/fun/InheritMethodsDifferentReturnTypesAndVisibilities.kt"); String fileName = JetTestUtils.navigationMetadata("compiler/testData/loadJava/compiledKotlin/fun/InheritMethodsDifferentReturnTypesAndVisibilities.kt");