azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reformat: redundant setter

Browse Source
This commit is contained in:
Mikhail Glukhikh
2018-01-30 09:50:23 +03:00
parent 69f3f04fe4
commit 30acc224ec
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/kotlin/idea/inspections/RedundantSetterInspection.kt
+8 -6
View File
@@ -16,10 +16,12 @@ class RedundantSetterInspection : AbstractKotlinInspection(), CleanupLocalInspec
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor { override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
return propertyAccessorVisitor { accessor -> return propertyAccessorVisitor { accessor ->
if (accessor.isRedundantSetter()) { if (accessor.isRedundantSetter()) {
holder.registerProblem(accessor, holder.registerProblem(
"Redundant setter", accessor,
ProblemHighlightType.GENERIC_ERROR_OR_WARNING, "Redundant setter",
RemoveRedundantSetterFix()) ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
RemoveRedundantSetterFix()
)
} }
} }
} }
@@ -35,8 +37,8 @@ private fun KtPropertyAccessor.isRedundantSetter(): Boolean {
val parameter = valueParameters.takeIf { it.size == 1 }?.firstOrNull() ?: return false val parameter = valueParameters.takeIf { it.size == 1 }?.firstOrNull() ?: return false
val binaryExpression = statement as? KtBinaryExpression ?: return false val binaryExpression = statement as? KtBinaryExpression ?: return false
return binaryExpression.operationToken == KtTokens.EQ return binaryExpression.operationToken == KtTokens.EQ
&& binaryExpression.left?.isFieldText() == true && binaryExpression.left?.isFieldText() == true
&& binaryExpression.right?.mainReference?.resolve() == parameter && binaryExpression.right?.mainReference?.resolve() == parameter
} }
return false return false
} }