From 3049961b9a4a7359156c2cf3247fa40b641a13db Mon Sep 17 00:00:00 2001
From: Mikhail Glukhikh <Mikhail.Glukhikh@jetbrains.com>
Date: Fri, 12 Feb 2016 17:51:21 +0300
Subject: [PATCH] Revert "Implicit exhaustive when annotation / highlighting"

This reverts commit 0cc09872b6432c36f25d33084b57f4035bc6d15f.
---
 .../org/jetbrains/kotlin/idea/KotlinBundle.properties    | 1 -
 .../idea/highlighter/KotlinHighlightingColors.java       | 1 -
 .../idea/highlighter/VariablesHighlightingVisitor.java   | 9 ---------
 idea/resources/colorScheme/Darcula_Kotlin.xml            | 5 -----
 idea/resources/colorScheme/Default_Kotlin.xml            | 5 -----
 .../kotlin/idea/highlighter/KotlinColorSettingsPage.kt   | 7 +------
 idea/testData/checker/infos/WhenImplicitExhaustive.kt    | 6 ------
 .../kotlin/checkers/PsiCheckerTestGenerated.java         | 6 ------
 8 files changed, 1 insertion(+), 39 deletions(-)
 delete mode 100644 idea/testData/checker/infos/WhenImplicitExhaustive.kt

diff --git a/idea/idea-analysis/src/org/jetbrains/kotlin/idea/KotlinBundle.properties b/idea/idea-analysis/src/org/jetbrains/kotlin/idea/KotlinBundle.properties
index 74e6f8935ea..3173bc1d11f 100644
--- a/idea/idea-analysis/src/org/jetbrains/kotlin/idea/KotlinBundle.properties
+++ b/idea/idea-analysis/src/org/jetbrains/kotlin/idea/KotlinBundle.properties
@@ -108,7 +108,6 @@ options.kotlin.attribute.descriptor.variable.as.function.like.call=Variable as f
 options.kotlin.attribute.descriptor.smart.cast=Smart-cast value
 options.kotlin.attribute.descriptor.smart.constant=Smart constant
 options.kotlin.attribute.descriptor.smart.cast.receiver=Smart-cast implicit receiver
-options.kotlin.attribute.descriptor.implicit.exhaustive.when=Implicitly exhaustive when
 options.kotlin.attribute.descriptor.label=Label
 migrate.sure=Replace sure() calls by !! in project
 migrate.class.object.to.companion=Replace 'class' keyword with 'companion' modifier
diff --git a/idea/idea-analysis/src/org/jetbrains/kotlin/idea/highlighter/KotlinHighlightingColors.java b/idea/idea-analysis/src/org/jetbrains/kotlin/idea/highlighter/KotlinHighlightingColors.java
index 11eb4e4e656..0720295be39 100644
--- a/idea/idea-analysis/src/org/jetbrains/kotlin/idea/highlighter/KotlinHighlightingColors.java
+++ b/idea/idea-analysis/src/org/jetbrains/kotlin/idea/highlighter/KotlinHighlightingColors.java
@@ -85,7 +85,6 @@ public class KotlinHighlightingColors {
     public static final TextAttributesKey SMART_CAST_VALUE = createTextAttributesKey("KOTLIN_SMART_CAST_VALUE");
     public static final TextAttributesKey SMART_CONSTANT = createTextAttributesKey("KOTLIN_SMART_CONSTANT");
     public static final TextAttributesKey SMART_CAST_RECEIVER = createTextAttributesKey("KOTLIN_SMART_CAST_RECEIVER");
-    public static final TextAttributesKey IMPLICIT_EXHAUSTIVE_WHEN = createTextAttributesKey("KOTLIN_IMPLICIT_EXHAUSTIVE_WHEN");
     public static final TextAttributesKey LABEL = createTextAttributesKey("KOTLIN_LABEL");
     public static final TextAttributesKey DEBUG_INFO = createTextAttributesKey("KOTLIN_DEBUG_INFO");
     public static final TextAttributesKey RESOLVED_TO_ERROR = createTextAttributesKey("KOTLIN_RESOLVED_TO_ERROR");
diff --git a/idea/idea-analysis/src/org/jetbrains/kotlin/idea/highlighter/VariablesHighlightingVisitor.java b/idea/idea-analysis/src/org/jetbrains/kotlin/idea/highlighter/VariablesHighlightingVisitor.java
index b61742a2c70..d59ce1a88bb 100644
--- a/idea/idea-analysis/src/org/jetbrains/kotlin/idea/highlighter/VariablesHighlightingVisitor.java
+++ b/idea/idea-analysis/src/org/jetbrains/kotlin/idea/highlighter/VariablesHighlightingVisitor.java
@@ -110,15 +110,6 @@ class VariablesHighlightingVisitor extends AfterAnalysisHighlightingVisitor {
                   .setTextAttributes(KotlinHighlightingColors.SMART_CAST_VALUE);
         }
 
-        if (expression instanceof KtWhenExpression) {
-            KtWhenExpression whenExpression = (KtWhenExpression) expression;
-            boolean implicitExhaustiveWhen = bindingContext.get(IMPLICIT_EXHAUSTIVE_WHEN, whenExpression) == Boolean.TRUE;
-            if (implicitExhaustiveWhen) {
-                holder.createInfoAnnotation(whenExpression.getWhenKeyword(), "When is implicitly exhaustive")
-                      .setTextAttributes(KotlinHighlightingColors.IMPLICIT_EXHAUSTIVE_WHEN);
-            }
-        }
-
         super.visitExpression(expression);
     }
 
diff --git a/idea/resources/colorScheme/Darcula_Kotlin.xml b/idea/resources/colorScheme/Darcula_Kotlin.xml
index 2c5f7fd6cce..79e46f2670d 100644
--- a/idea/resources/colorScheme/Darcula_Kotlin.xml
+++ b/idea/resources/colorScheme/Darcula_Kotlin.xml
@@ -40,11 +40,6 @@
       <option name="BACKGROUND" value="223c23" />
     </value>
   </option>
-  <option name="KOTLIN_IMPLICIT_EXHAUSTIVE_WHEN">
-    <value>
-      <option name="BACKGROUND" value="0321ab" />
-    </value>
-  </option>
   <option name="KOTLIN_LABEL">
     <value>
       <option name="FOREGROUND" value="467cda" />
diff --git a/idea/resources/colorScheme/Default_Kotlin.xml b/idea/resources/colorScheme/Default_Kotlin.xml
index 1c0f804c24d..e9b6ec4051d 100644
--- a/idea/resources/colorScheme/Default_Kotlin.xml
+++ b/idea/resources/colorScheme/Default_Kotlin.xml
@@ -40,11 +40,6 @@
       <option name="BACKGROUND" value="dbffdb" />
     </value>
   </option>
-  <option name="KOTLIN_IMPLICIT_EXHAUSTIVE_WHEN">
-    <value>
-      <option name="BACKGROUND" value="d3faf8" />
-    </value>
-  </option>
   <option name="KOTLIN_LABEL">
     <value>
       <option name="FOREGROUND" value="4a86e8" />
diff --git a/idea/src/org/jetbrains/kotlin/idea/highlighter/KotlinColorSettingsPage.kt b/idea/src/org/jetbrains/kotlin/idea/highlighter/KotlinColorSettingsPage.kt
index b1be1a45ad1..1e7f0bb44dc 100644
--- a/idea/src/org/jetbrains/kotlin/idea/highlighter/KotlinColorSettingsPage.kt
+++ b/idea/src/org/jetbrains/kotlin/idea/highlighter/KotlinColorSettingsPage.kt
@@ -63,17 +63,13 @@ class KotlinColorSettingsPage : ColorSettingsPage {
     }
 }
 
-fun Int?.bar(): Int {
+fun Int?.bar() {
     if (this != null) {
         println(<SMART_CAST_RECEIVER>toString</SMART_CAST_RECEIVER>())
     }
     else {
         println(<SMART_CONSTANT>this</SMART_CONSTANT>.toString())
     }
-    <IMPLICIT_EXHAUSTIVE_WHEN>when</IMPLICIT_EXHAUSTIVE_WHEN> (this != null) {
-        true -> return 1
-        false -> return 0
-    }
 }
 
 var <PROPERTY_WITH_BACKING_FIELD><PACKAGE_PROPERTY><MUTABLE_VARIABLE>globalCounter</MUTABLE_VARIABLE></PACKAGE_PROPERTY></PROPERTY_WITH_BACKING_FIELD> : Int = 5
@@ -161,7 +157,6 @@ var <PROPERTY_WITH_BACKING_FIELD><PACKAGE_PROPERTY><MUTABLE_VARIABLE>globalCount
                        KotlinBundle.message("options.kotlin.attribute.descriptor.smart.cast") to KotlinHighlightingColors.SMART_CAST_VALUE,
                        KotlinBundle.message("options.kotlin.attribute.descriptor.smart.constant") to KotlinHighlightingColors.SMART_CONSTANT,
                        KotlinBundle.message("options.kotlin.attribute.descriptor.smart.cast.receiver") to KotlinHighlightingColors.SMART_CAST_RECEIVER,
-                       KotlinBundle.message("options.kotlin.attribute.descriptor.implicit.exhaustive.when") to KotlinHighlightingColors.IMPLICIT_EXHAUSTIVE_WHEN,
                        KotlinBundle.message("options.kotlin.attribute.descriptor.label") to KotlinHighlightingColors.LABEL)
     }
 
diff --git a/idea/testData/checker/infos/WhenImplicitExhaustive.kt b/idea/testData/checker/infos/WhenImplicitExhaustive.kt
deleted file mode 100644
index a6ffe810924..00000000000
--- a/idea/testData/checker/infos/WhenImplicitExhaustive.kt
+++ /dev/null
@@ -1,6 +0,0 @@
-fun foo(b: Boolean): Int {
-    <info descr="When is implicitly exhaustive">when</info> (b) {
-        true -> return 1
-        false -> return 0
-    }
-}
diff --git a/idea/tests/org/jetbrains/kotlin/checkers/PsiCheckerTestGenerated.java b/idea/tests/org/jetbrains/kotlin/checkers/PsiCheckerTestGenerated.java
index 8e0d091258d..48aa4bb8c48 100644
--- a/idea/tests/org/jetbrains/kotlin/checkers/PsiCheckerTestGenerated.java
+++ b/idea/tests/org/jetbrains/kotlin/checkers/PsiCheckerTestGenerated.java
@@ -850,12 +850,6 @@ public class PsiCheckerTestGenerated extends AbstractPsiCheckerTest {
             doTestWithInfos(fileName);
         }
 
-        @TestMetadata("WhenImplicitExhaustive.kt")
-        public void testWhenImplicitExhaustive() throws Exception {
-            String fileName = KotlinTestUtils.navigationMetadata("idea/testData/checker/infos/WhenImplicitExhaustive.kt");
-            doTestWithInfos(fileName);
-        }
-
         @TestMetadata("WrapIntoRef.kt")
         public void testWrapIntoRef() throws Exception {
             String fileName = KotlinTestUtils.navigationMetadata("idea/testData/checker/infos/WrapIntoRef.kt");