[tests] Refactor AbstractReferenceResolveTest. Part 1

Instead of relying on UNRESOLVED_REFERENCE directive for the whole file,
just render the unresolved reference right in the .txt testdata

This will allow to introduce multi-caret resolve testdata more naturally

Required for KT-65152 and KT-62695

analysis/analysis-api-impl-base/tests/org/jetbrains/kotlin/analysis/api/impl/base/test/cases/references/AbstractReferenceResolveTest.kt

@@ -58,15 +58,10 @@ abstract class AbstractReferenceResolveTest : AbstractAnalysisApiBasedTest() {
 
         val resolvedTo = analyzeReferenceElement(ktReferences.first().element, mainModule) {
             val symbols = ktReferences.flatMap { it.resolveToSymbols() }
-            checkReferenceResultForValidity(ktReferences, mainModule, testServices, symbols)
             val renderPsiClassName = Directives.RENDER_PSI_CLASS_NAME in mainModule.directives
             renderResolvedTo(symbols, renderPsiClassName, renderingOptions) { getAdditionalSymbolInfo(it) }
         }
 
-        if (Directives.UNRESOLVED_REFERENCE in mainModule.directives) {
-            return
-        }
-
         val actual = "Resolved to:\n$resolvedTo"
         testServices.assertions.assertEqualsToTestDataFileSibling(actual)
     }
@@ -80,28 +75,7 @@ abstract class AbstractReferenceResolveTest : AbstractAnalysisApiBasedTest() {
     private fun findReferencesAtCaret(mainKtFile: KtFile, caretPosition: Int): List<KtReference> =
         mainKtFile.findReferenceAt(caretPosition)?.unwrapMultiReferences().orEmpty().filterIsInstance<KtReference>()
 
-    private fun KtAnalysisSession.checkReferenceResultForValidity(
-        references: List<KtReference>,
-        module: TestModule,
-        testServices: TestServices,
-        resolvedTo: List<KtSymbol>,
-    ) {
-        if (Directives.UNRESOLVED_REFERENCE in module.directives) {
-            testServices.assertions.assertTrue(resolvedTo.isEmpty()) {
-                "Reference should be unresolved, but was resolved to ${renderResolvedTo(resolvedTo)}"
-            }
-        } else {
-            if (resolvedTo.isEmpty()) {
-                testServices.assertions.fail { "Unresolved reference ${references.first().element.text}" }
-            }
-        }
-    }
-
     private object Directives : SimpleDirectivesContainer() {
-        val UNRESOLVED_REFERENCE by directive(
-            "Reference should be unresolved",
-        )
-
         val RENDER_PSI_CLASS_NAME by directive(
             "Render also PSI class name for resolved reference"
         )

analysis/analysis-api-impl-base/tests/org/jetbrains/kotlin/analysis/api/impl/base/test/cases/references/TestReferenceResolveResultRenderer.kt

@@ -15,16 +15,24 @@ import org.jetbrains.kotlin.name.FqName
 import org.jetbrains.kotlin.types.Variance
 
 object TestReferenceResolveResultRenderer {
+    private const val UNRESOLVED_REFERENCE_RESULT = "Nothing (Unresolved reference)"
+
+    /**
+     * Empty [symbols] list equals to unresolved reference.
+     */
     fun KtAnalysisSession.renderResolvedTo(
         symbols: List<KtSymbol>,
         renderPsiClassName: Boolean = false,
         renderer: KtDeclarationRenderer = KtDeclarationRendererForDebug.WITH_QUALIFIED_NAMES,
         additionalInfo: KtAnalysisSession.(KtSymbol) -> String? = { null }
-    ) =
+    ): String {
-        symbols.map { renderResolveResult(it, renderPsiClassName, renderer, additionalInfo) }
+        if (symbols.isEmpty()) return UNRESOLVED_REFERENCE_RESULT
+
+        return symbols.map { renderResolveResult(it, renderPsiClassName, renderer, additionalInfo) }
             .sorted()
             .withIndex()
             .joinToString(separator = "\n") { "${it.index}: ${it.value}" }
+    }
 
     private fun KtAnalysisSession.renderResolveResult(
         symbol: KtSymbol,

analysis/analysis-api/testData/referenceResolve/PlusAssignByHand.kt

@@ -1,4 +1,3 @@
-// UNRESOLVED_REFERENCE
 package test
 
 interface Foo

analysis/analysis-api/testData/referenceResolve/PlusAssignByHand.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/arrayAccess/withErrors/SetOperatorInc.kt

@@ -1,4 +1,3 @@
-// UNRESOLVED_REFERENCE
 package test
 
 class B(val n: Int) {

analysis/analysis-api/testData/referenceResolve/arrayAccess/withErrors/SetOperatorInc.txt

@@ -1,2 +1,2 @@
 Resolved to:
-0: (in test.B) operator fun set(i: kotlin.Int, a: test.B)
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/delegatedPropertyAccessors/withErrors/unresolved.kt

@@ -1,5 +1,3 @@
-// UNRESOLVED_REFERENCE
-
 val foo: Int <caret>by Bar()
 
 class Bar

analysis/analysis-api/testData/referenceResolve/delegatedPropertyAccessors/withErrors/unresolved.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/forLoopIn/withErrors/unresolvedIterator.kt

@@ -1,4 +1,3 @@
-// UNRESOLVED_REFERENCE
 fun test() {
   for (x <caret>in Y()) {}
 }

analysis/analysis-api/testData/referenceResolve/forLoopIn/withErrors/unresolvedIterator.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/kDoc/companionObject/childQualifiedFunctionFromSuperClassCompanion.kt

@@ -1,5 +1,3 @@
-// UNRESOLVED_REFERENCE
-
 open class Base {
     companion object {
         fun foo() {}

analysis/analysis-api/testData/referenceResolve/kDoc/companionObject/childQualifiedFunctionFromSuperClassCompanion.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/kDoc/companionObject/unqualifiedFunctionFromSuperClassCompanion.kt

@@ -1,5 +1,3 @@
-// UNRESOLVED_REFERENCE
-
 open class Base {
     companion object {
         fun foo() {}

analysis/analysis-api/testData/referenceResolve/kDoc/companionObject/unqualifiedFunctionFromSuperClassCompanion.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/kDoc/javaDeclarations/StaticFunctionFromBaseClass.kt

@@ -1,4 +1,3 @@
-// UNRESOLVED_REFERENCE
 // FILE: main.kt
 import dependency.JavaBase
 

analysis/analysis-api/testData/referenceResolve/kDoc/javaDeclarations/StaticFunctionFromBaseClass.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/kDoc/javaDeclarations/StaticFunctionQualifiedWithKotlinSubclass.kt

@@ -1,4 +1,3 @@
-// UNRESOLVED_REFERENCE
 // FILE: main.kt
 import dependency.JavaBase
 

analysis/analysis-api/testData/referenceResolve/kDoc/javaDeclarations/StaticFunctionQualifiedWithKotlinSubclass.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/kDoc/thisQualifier/thisQualifierOnClass.kt

@@ -1,5 +1,3 @@
-// UNRESOLVED_REFERENCE
-
 /**
  * [th<caret>is]
  */

analysis/analysis-api/testData/referenceResolve/kDoc/thisQualifier/thisQualifierOnClass.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/kDoc/thisQualifier/thisQualifierOnFunctionNoExtensionReceiver.kt

@@ -1,5 +1,3 @@
-// UNRESOLVED_REFERENCE
-
 /**
  * [th<caret>is]
  */

analysis/analysis-api/testData/referenceResolve/kDoc/thisQualifier/thisQualifierOnFunctionNoExtensionReceiver.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/kDoc/thisQualifier/thisQualifierOnPropertyNoExtensionReceiver.kt

@@ -1,5 +1,3 @@
-// UNRESOLVED_REFERENCE
-
 /**
  * [th<caret>is]
  */

analysis/analysis-api/testData/referenceResolve/kDoc/thisQualifier/thisQualifierOnPropertyNoExtensionReceiver.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/kotlinPackage/kotlinPackageNotAllowed.kt

@@ -1,6 +1,5 @@
 // FE1.0 can resolve to `kotlin` package when it's not allowed
 // IGNORE_FE10
-// UNRESOLVED_REFERENCE
 // COMPILATION_ERRORS
 // FILE: a.kt
 package kotlin.pckg

analysis/analysis-api/testData/referenceResolve/kotlinPackage/kotlinPackageNotAllowed.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/withErrors/BuiltInImportsNoRuntime.kt

@@ -1,4 +1,3 @@
 // NO_RUNTIME
-// UNRESOLVED_REFERENCE
 // IGNORE_FE10
 val (<caret>x)

analysis/analysis-api/testData/referenceResolve/withErrors/BuiltInImportsNoRuntime.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/withErrors/ByReturnExpression.kt

@@ -1,4 +1,3 @@
-// UNRESOLVED_REFERENCE
 fun bar(block: () -> Unit) {}
 
 fun foo() {

analysis/analysis-api/testData/referenceResolve/withErrors/ByReturnExpression.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/withErrors/DanglingAnnotations.kt

@@ -1,4 +1,3 @@
-// UNRESOLVED_REFERENCE
 class Foo {
     fun foo() {
         class Local {

analysis/analysis-api/testData/referenceResolve/withErrors/DanglingAnnotations.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/withErrors/DeprecatedHidden.kt

@@ -1,5 +1,3 @@
-// UNRESOLVED_REFERENCE
-
 @Deprecated("don't use i", level = DeprecationLevel.HIDDEN)
 val i: Int = 1
 

analysis/analysis-api/testData/referenceResolve/withErrors/DeprecatedHidden.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/withErrors/FakeJavaLang1.kt

@@ -1,5 +1,3 @@
-// UNRESOLVED_REFERENCE
-
 // FILE: main.kt
 import java.lang.* // will not import Fake
 

analysis/analysis-api/testData/referenceResolve/withErrors/FakeJavaLang1.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/withErrors/FakeJavaLang2.kt

@@ -1,4 +1,3 @@
-// UNRESOLVED_REFERENCE
 // FILE: main.kt
 fun foo() {
     <caret>Fake() // not imported within "java.lang.*" default import

analysis/analysis-api/testData/referenceResolve/withErrors/FakeJavaLang2.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/withErrors/FakeJavaLang3.kt

@@ -1,4 +1,3 @@
-// UNRESOLVED_REFERENCE
 // FILE: main.kt
 package nonRoot
 import java.lang.*

analysis/analysis-api/testData/referenceResolve/withErrors/FakeJavaLang3.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/withErrors/FakeJavaLang4.kt

@@ -1,4 +1,3 @@
-// UNRESOLVED_REFERENCE
 // FILE: main.kt
 package nonRoot
 

analysis/analysis-api/testData/referenceResolve/withErrors/FakeJavaLang4.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/withErrors/PropertyPlaceInClassObjectInObject.kt

@@ -1,5 +1,4 @@
 // Should not fall on temp references in invalid code
-// UNRESOLVED_REFERENCE
 
 object Testing {
     companion object {

analysis/analysis-api/testData/referenceResolve/withErrors/PropertyPlaceInClassObjectInObject.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/referenceResolve/withErrors/TopLevelDestructingDeclaration.kt

@@ -1,4 +1,3 @@
-// UNRESOLVED_REFERENCE
 // IGNORE_FE10
 
 fun <T : Any, Z> createTuple(a: T, b: Z&Any): Pair<T, Z&Any> {

analysis/analysis-api/testData/referenceResolve/withErrors/TopLevelDestructingDeclaration.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/resolveExtensions/referenceResolve/multiModule/extendedModuleDependency/shadowedDeclaration.kt

@@ -1,5 +1,3 @@
-// UNRESOLVED_REFERENCE
-
 // MODULE: extendedModule
 // WITH_RESOLVE_EXTENSION
 // RESOLVE_EXTENSION_PACKAGE: generated

analysis/analysis-api/testData/resolveExtensions/referenceResolve/multiModule/extendedModuleDependency/shadowedDeclaration.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/resolveExtensions/referenceResolve/multiModule/extendedModuleDependency/shadowedJava.kt

@@ -1,5 +1,3 @@
-// UNRESOLVED_REFERENCE
-
 // MODULE: extendedModule
 // WITH_RESOLVE_EXTENSION
 // RESOLVE_EXTENSION_PACKAGE: generated

analysis/analysis-api/testData/resolveExtensions/referenceResolve/multiModule/extendedModuleDependency/shadowedJava.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/resolveExtensions/referenceResolve/singleModule/shadowedDeclaration.kt

@@ -1,7 +1,6 @@
 // WITH_RESOLVE_EXTENSION
 // RESOLVE_EXTENSION_PACKAGE: generated
 // RESOLVE_EXTENSION_SHADOWED: \.hidden\.kt$
-// UNRESOLVED_REFERENCE
 
 // FILE: declarations.hidden.kt
 package foo

analysis/analysis-api/testData/resolveExtensions/referenceResolve/singleModule/shadowedDeclaration.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)

analysis/analysis-api/testData/resolveExtensions/referenceResolve/singleModule/shadowedJava.kt

@@ -1,7 +1,6 @@
 // WITH_RESOLVE_EXTENSION
 // RESOLVE_EXTENSION_PACKAGE: generated
 // RESOLVE_EXTENSION_SHADOWED: \.hidden\.[a-z]+$
-// UNRESOLVED_REFERENCE
 
 // FILE: TestClass.hidden.java
 package foo;

analysis/analysis-api/testData/resolveExtensions/referenceResolve/singleModule/shadowedJava.txt

@@ -0,0 +1,2 @@
+Resolved to:
+Nothing (Unresolved reference)