Condition of 'if' expression is constant: report enum entries comparison

#KT-28803 Fixed

idea/testData/inspectionsLocal/constantConditionIf/enumEntryEq.kt

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(if (<caret>Enum.A == Enum.A) 1 else 2)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryEq.kt.after

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(1)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryEq2.1.kt

@@ -0,0 +1,5 @@
+package test
+
+enum class Enum {
+    A, B, C
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryEq2.1.kt.after

@@ -0,0 +1,5 @@
+package test
+
+enum class Enum {
+    A, B, C
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryEq2.kt

@@ -0,0 +1,6 @@
+// PROBLEM: Condition is always 'true'
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(if (<caret>test.Enum.A == test.Enum.A) 1 else 2)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryEq2.kt.after

@@ -0,0 +1,6 @@
+// PROBLEM: Condition is always 'true'
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(1)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryEq3.1.kt

@@ -0,0 +1,5 @@
+package test
+
+enum class Enum {
+    A, B, C
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryEq3.1.kt.after

@@ -0,0 +1,5 @@
+package test
+
+enum class Enum {
+    A, B, C
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryEq3.kt

@@ -0,0 +1,8 @@
+// PROBLEM: Condition is always 'true'
+import test.Enum.*
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(if (<caret>A == A) 1 else 2)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryEq3.kt.after

@@ -0,0 +1,8 @@
+// PROBLEM: Condition is always 'true'
+import test.Enum.*
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(1)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryGt.kt

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(if (<caret>Enum.B > Enum.A) 1 else 2)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryGt.kt.after

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(1)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryGtEq.kt

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(if (<caret>Enum.B >= Enum.A) 1 else 2)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryGtEq.kt.after

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(1)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryGtEq2.kt

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(if (<caret>Enum.B >= Enum.B) 1 else 2)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryGtEq2.kt.after

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(1)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryLt.kt

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(if (<caret>Enum.B < Enum.C) 1 else 2)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryLt.kt.after

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(1)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryLtEq.kt

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(if (<caret>Enum.B <= Enum.C) 1 else 2)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryLtEq.kt.after

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(1)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryLtEq2.kt

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(if (<caret>Enum.B <= Enum.B) 1 else 2)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryLtEq2.kt.after

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'true'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(1)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryNotEq.kt

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'false'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(if (<caret>Enum.A != Enum.A) 1 else 2)
+}

idea/testData/inspectionsLocal/constantConditionIf/enumEntryNotEq.kt.after

@@ -0,0 +1,10 @@
+// PROBLEM: Condition is always 'false'
+enum class Enum {
+    A, B, C
+}
+
+fun foo(x: Int) {}
+
+fun bar() {
+    foo(2)
+}