azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

KT-46049 Java-Kotlin sealed inheritors inspection: false positive for type parameter

Browse Source 
^KT-46049 Fixed
This commit is contained in:
Andrei Klunnyi
2021-04-13 12:27:51 +02:00
parent 85b4668b7c
commit 2fce968de0
3 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/kotlin/idea/inspections/KotlinSealedInheritorsInJavaInspection.kt
+1
View File
@@ -43,6 +43,7 @@ class KotlinSealedInheritorsInJavaInspection : LocalInspectionTool() {
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor { override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
return object : JavaElementVisitor() { return object : JavaElementVisitor() {
override fun visitClass(aClass: PsiClass?) { override fun visitClass(aClass: PsiClass?) {
if (aClass is PsiTypeParameter) return
aClass?.listSealedParentReferences()?.forEach { aClass?.listSealedParentReferences()?.forEach {
holder.registerProblem( holder.registerProblem(
it, KotlinBundle.message("inheritance.of.kotlin.sealed", 0.takeIf { aClass.isInterface } ?: 1), it, KotlinBundle.message("inheritance.of.kotlin.sealed", 0.takeIf { aClass.isInterface } ?: 1),
idea/testData/multiFileInspections/kotlinSealedInJavaTest/before/JavaTriesToExtendKotlinSealed.java
Vendored
+2
View File
@@ -8,6 +8,8 @@ public class JavaTriesToExtendKotlinSealed {
interface OkToExtend extends KotlinInterface {} interface OkToExtend extends KotlinInterface {}
class OkToExtendClass extends KotlinClass{} class OkToExtendClass extends KotlinClass{}
public <OkTypeParam extends KotlinSealedClass> void getSealed() {}
public static void main(String[] args) { public static void main(String[] args) {
KotlinSealedInterface sealedInterface = new KotlinSealedInterface() {}; // anonymouns class implements interface KotlinSealedInterface sealedInterface = new KotlinSealedInterface() {}; // anonymouns class implements interface
KotlinSealedClass sealedClass = new KotlinSealedClass() {}; KotlinSealedClass sealedClass = new KotlinSealedClass() {};
idea/testData/multiFileInspections/kotlinSealedInJavaTest/expected.xml
Vendored
+2 -2
View File
@@ -46,7 +46,7 @@
<problem> <problem>
<file>JavaTriesToExtendKotlinSealed.java</file> <file>JavaTriesToExtendKotlinSealed.java</file>
<line>12</line> <line>14</line>
<module>testKotlinSealedInJavaTest_KotlinSealedInJavaTest</module> <module>testKotlinSealedInJavaTest_KotlinSealedInJavaTest</module>
<package>&lt;default&gt;</package> <package>&lt;default&gt;</package>
<entry_point TYPE="class" FQNAME="JavaTriesToExtendKotlinSealed$1" /> <entry_point TYPE="class" FQNAME="JavaTriesToExtendKotlinSealed$1" />
@@ -59,7 +59,7 @@
<problem> <problem>
<file>JavaTriesToExtendKotlinSealed.java</file> <file>JavaTriesToExtendKotlinSealed.java</file>
<line>13</line> <line>15</line>
<module>testKotlinSealedInJavaTest_KotlinSealedInJavaTest</module> <module>testKotlinSealedInJavaTest_KotlinSealedInJavaTest</module>
<package>&lt;default&gt;</package> <package>&lt;default&gt;</package>
<entry_point TYPE="class" FQNAME="JavaTriesToExtendKotlinSealed$2" /> <entry_point TYPE="class" FQNAME="JavaTriesToExtendKotlinSealed$2" />