From 2f32c6e16429673c61d1fca0935a3fd34a00898c Mon Sep 17 00:00:00 2001
From: Natalia Selezneva <natalia.selezneva@jetbrains.com>
Date: Wed, 19 Dec 2018 11:41:33 +0300
Subject: [PATCH] Refactoring: move test output handler to separate class

---
 .../output/InlayScratchOutputHandler.kt       |  8 +--
 .../output/ToolWindowScratchOutputHandler.kt  | 67 +++++++++++--------
 2 files changed, 42 insertions(+), 33 deletions(-)

diff --git a/idea/idea-jvm/src/org/jetbrains/kotlin/idea/scratch/output/InlayScratchOutputHandler.kt b/idea/idea-jvm/src/org/jetbrains/kotlin/idea/scratch/output/InlayScratchOutputHandler.kt
index 6f44d0a89ed..19ee2676f73 100644
--- a/idea/idea-jvm/src/org/jetbrains/kotlin/idea/scratch/output/InlayScratchOutputHandler.kt
+++ b/idea/idea-jvm/src/org/jetbrains/kotlin/idea/scratch/output/InlayScratchOutputHandler.kt
@@ -38,12 +38,12 @@ object InlayScratchOutputHandler : ScratchOutputHandler {
         createInlay(file, expression, output)
 
         if (output.type == ScratchOutputType.ERROR) {
-            ToolWindowScratchOutputHandler.handle(file, expression, output)
+            getToolwindowHandler().handle(file, expression, output)
         }
     }
 
     override fun error(file: ScratchFile, message: String) {
-        ToolWindowScratchOutputHandler.error(file, message)
+        getToolwindowHandler().error(file, message)
     }
 
     override fun onFinish(file: ScratchFile) {
@@ -52,7 +52,7 @@ object InlayScratchOutputHandler : ScratchOutputHandler {
 
     override fun clear(file: ScratchFile) {
         clearInlays(file.editor)
-        ToolWindowScratchOutputHandler.clear(file)
+        getToolwindowHandler().clear(file)
     }
 
     private fun createInlay(file: ScratchFile, expression: ScratchExpression, output: ScratchOutput) {
@@ -91,7 +91,7 @@ object InlayScratchOutputHandler : ScratchOutputHandler {
 
     private fun printToToolWindow(file: ScratchFile, expression: ScratchExpression, output: ScratchOutput) {
         if (output.type != ScratchOutputType.ERROR) {
-            ToolWindowScratchOutputHandler.handle(file, expression, output)
+            getToolwindowHandler().handle(file, expression, output)
         }
     }
 
diff --git a/idea/idea-jvm/src/org/jetbrains/kotlin/idea/scratch/output/ToolWindowScratchOutputHandler.kt b/idea/idea-jvm/src/org/jetbrains/kotlin/idea/scratch/output/ToolWindowScratchOutputHandler.kt
index ec16c672621..645982c7d50 100644
--- a/idea/idea-jvm/src/org/jetbrains/kotlin/idea/scratch/output/ToolWindowScratchOutputHandler.kt
+++ b/idea/idea-jvm/src/org/jetbrains/kotlin/idea/scratch/output/ToolWindowScratchOutputHandler.kt
@@ -35,13 +35,18 @@ import org.jetbrains.kotlin.idea.scratch.ScratchExpression
 import org.jetbrains.kotlin.idea.scratch.ScratchFile
 import org.jetbrains.kotlin.psi.KtPsiFactory
 
-object ToolWindowScratchOutputHandler : ScratchOutputHandlerAdapter() {
+
+fun getToolwindowHandler(): ScratchOutputHandler {
+    return if (ApplicationManager.getApplication().isUnitTestMode) {
+        TestOutputHandler
+    } else {
+        ToolWindowScratchOutputHandler
+    }
+}
+
+private object ToolWindowScratchOutputHandler : ScratchOutputHandlerAdapter() {
 
     override fun handle(file: ScratchFile, expression: ScratchExpression, output: ScratchOutput) {
-        if (ApplicationManager.getApplication().isUnitTestMode) {
-            return testPrint(file, output.text, expression)
-        }
-
         printToConsole(file.project) {
             val psiFile = file.getPsiFile()
             if (psiFile != null) {
@@ -60,10 +65,6 @@ object ToolWindowScratchOutputHandler : ScratchOutputHandlerAdapter() {
     }
 
     override fun error(file: ScratchFile, message: String) {
-        if (ApplicationManager.getApplication().isUnitTestMode) {
-            return testPrint(file, message)
-        }
-
         printToConsole(file.project) {
             print(message, ConsoleViewContentType.ERROR_OUTPUT)
         }
@@ -86,8 +87,6 @@ object ToolWindowScratchOutputHandler : ScratchOutputHandlerAdapter() {
     }
 
     override fun clear(file: ScratchFile) {
-        if (ApplicationManager.getApplication().isUnitTestMode) return
-
         ApplicationManager.getApplication().invokeLater {
             val toolWindow = getToolWindow(file.project) ?: return@invokeLater
             val contents = toolWindow.contentManager.contents
@@ -102,9 +101,6 @@ object ToolWindowScratchOutputHandler : ScratchOutputHandlerAdapter() {
         }
     }
 
-    private fun getLineInfo(psiFile: PsiFile, expression: ScratchExpression) =
-        "${psiFile.name}:${expression.lineStart + 1}"
-
     private fun ScratchOutputType.convert() = when (this) {
         ScratchOutputType.OUTPUT -> ConsoleViewContentType.SYSTEM_OUTPUT
         ScratchOutputType.RESULT -> ConsoleViewContentType.NORMAL_OUTPUT
@@ -123,23 +119,11 @@ object ToolWindowScratchOutputHandler : ScratchOutputHandlerAdapter() {
         ScratchToolWindowFactory().createToolWindowContent(project, window)
         return window
     }
-
-    @TestOnly
-    private fun testPrint(file: ScratchFile, output: String, expression: ScratchExpression? = null) {
-        ApplicationManager.getApplication().invokeLater {
-            WriteCommandAction.runWriteCommandAction(file.project) {
-                val psiFile = file.getPsiFile()!!
-                psiFile.addAfter(
-                    KtPsiFactory(file.project).createComment(
-                        "/** ${expression?.let { getLineInfo(psiFile, expression) + " " } ?: ""}$output */"
-                    ),
-                    psiFile.lastChild
-                )
-            }
-        }
-    }
 }
 
+private fun getLineInfo(psiFile: PsiFile, expression: ScratchExpression) =
+    "${psiFile.name}:${expression.lineStart + 1}"
+
 private class ScratchToolWindowFactory : ToolWindowFactory {
     companion object {
         const val ID = "Scratch Output"
@@ -161,3 +145,28 @@ private class ScratchToolWindowFactory : ToolWindowFactory {
         Disposer.register(project, consoleView)
     }
 }
+
+@TestOnly
+private object TestOutputHandler : ScratchOutputHandlerAdapter() {
+    override fun handle(file: ScratchFile, expression: ScratchExpression, output: ScratchOutput) {
+        testPrint(file, output.text, expression)
+    }
+
+    override fun error(file: ScratchFile, message: String) {
+        testPrint(file, message)
+    }
+
+    private fun testPrint(file: ScratchFile, output: String, expression: ScratchExpression? = null) {
+        ApplicationManager.getApplication().invokeLater {
+            WriteCommandAction.runWriteCommandAction(file.project) {
+                val psiFile = file.getPsiFile()!!
+                psiFile.addAfter(
+                    KtPsiFactory(file.project).createComment(
+                        "/** ${expression?.let { getLineInfo(psiFile, expression) + " " } ?: ""}$output */"
+                    ),
+                    psiFile.lastChild
+                )
+            }
+        }
+    }
+}