azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Performance optimization: do not create a new list object on each new option

Browse Source
This commit is contained in:
Yan Zhulanow
2018-10-29 10:08:08 +09:00
parent b6aecf3933
commit 2e56feed73
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/plugin-api/src/org/jetbrains/kotlin/compiler/plugin/CommandLineProcessor.kt
+10 -2
View File
@@ -35,13 +35,13 @@ interface CommandLineProcessor {
fun processOption(option: CliOption, value: String, configuration: CompilerConfiguration) {} fun processOption(option: CliOption, value: String, configuration: CompilerConfiguration) {}
fun <T> CompilerConfiguration.appendList(option: CompilerConfigurationKey<List<T>>, value: T) { fun <T> CompilerConfiguration.appendList(option: CompilerConfigurationKey<List<T>>, value: T) {
val paths = getList(option).toMutableList() val paths = getList(option).asMutableList()
paths.add(value) paths.add(value)
put(option, paths) put(option, paths)
} }
fun <T> CompilerConfiguration.appendList(option: CompilerConfigurationKey<List<T>>, values: List<T>) { fun <T> CompilerConfiguration.appendList(option: CompilerConfigurationKey<List<T>>, values: List<T>) {
val paths = getList(option).toMutableList() val paths = getList(option).asMutableList()
paths.addAll(values) paths.addAll(values)
put(option, paths) put(option, paths)
} }
@@ -55,4 +55,12 @@ interface CommandLineProcessor {
} }
} }
} }
private fun <T> List<T>.asMutableList(): MutableList<T> {
if (this is ArrayList<T>) {
return this
}
return this.toMutableList()
}
} }