Minor. Rename addToScope -> addFakeOverride

This commit is contained in:
Andrey Breslav
2015-04-07 16:35:04 +03:00
committed by Denis Zharkov
parent a6a099b0f5
commit 2de3a3b59e
7 changed files with 8 additions and 8 deletions
@@ -164,7 +164,7 @@ class CollectionStubMethodGenerator(
val result = ArrayList<FunctionDescriptor>() val result = ArrayList<FunctionDescriptor>()
OverrideResolver.generateOverridesInAClass(klass, listOf(), object : OverridingUtil.DescriptorSink { OverrideResolver.generateOverridesInAClass(klass, listOf(), object : OverridingUtil.DescriptorSink {
override fun addToScope(fakeOverride: CallableMemberDescriptor) { override fun addFakeOverride(fakeOverride: CallableMemberDescriptor) {
if (fakeOverride !is FunctionDescriptor) return if (fakeOverride !is FunctionDescriptor) return
if (fakeOverride.findOverriddenFromDirectSuperClass(mutableCollectionClass) != null) { if (fakeOverride.findOverriddenFromDirectSuperClass(mutableCollectionClass) != null) {
result.add(fakeOverride) result.add(fakeOverride)
@@ -99,7 +99,7 @@ public open class LazyClassMemberScope(
private fun <D : CallableMemberDescriptor> generateFakeOverrides(name: Name, fromSupertypes: Collection<D>, result: MutableCollection<D>, exactDescriptorClass: Class<out D>) { private fun <D : CallableMemberDescriptor> generateFakeOverrides(name: Name, fromSupertypes: Collection<D>, result: MutableCollection<D>, exactDescriptorClass: Class<out D>) {
OverridingUtil.generateOverridesInFunctionGroup(name, fromSupertypes, ArrayList(result), thisDescriptor, object : OverridingUtil.DescriptorSink { OverridingUtil.generateOverridesInFunctionGroup(name, fromSupertypes, ArrayList(result), thisDescriptor, object : OverridingUtil.DescriptorSink {
override fun addToScope(fakeOverride: CallableMemberDescriptor) { override fun addFakeOverride(fakeOverride: CallableMemberDescriptor) {
assert(exactDescriptorClass.isInstance(fakeOverride)) { "Wrong descriptor type in an override: " + fakeOverride + " while expecting " + exactDescriptorClass.getSimpleName() } assert(exactDescriptorClass.isInstance(fakeOverride)) { "Wrong descriptor type in an override: " + fakeOverride + " while expecting " + exactDescriptorClass.getSimpleName() }
@suppress("UNCHECKED_CAST") @suppress("UNCHECKED_CAST")
result.add(fakeOverride as D) result.add(fakeOverride as D)
@@ -54,7 +54,7 @@ public final class DescriptorResolverUtils {
new OverridingUtil.DescriptorSink() { new OverridingUtil.DescriptorSink() {
@Override @Override
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
public void addToScope(@NotNull CallableMemberDescriptor fakeOverride) { public void addFakeOverride(@NotNull CallableMemberDescriptor fakeOverride) {
OverridingUtil.resolveUnknownVisibilityForMember(fakeOverride, new Function1<CallableMemberDescriptor, Unit>() { OverridingUtil.resolveUnknownVisibilityForMember(fakeOverride, new Function1<CallableMemberDescriptor, Unit>() {
@Override @Override
public Unit invoke(@NotNull CallableMemberDescriptor descriptor) { public Unit invoke(@NotNull CallableMemberDescriptor descriptor) {
@@ -64,7 +64,7 @@ class FunctionClassScope(
/* membersFromCurrent = */ if (name == invoke?.getName()) listOf(invoke) else listOf(), /* membersFromCurrent = */ if (name == invoke?.getName()) listOf(invoke) else listOf(),
functionClass, functionClass,
object : OverridingUtil.DescriptorSink { object : OverridingUtil.DescriptorSink {
override fun addToScope(fakeOverride: CallableMemberDescriptor) { override fun addFakeOverride(fakeOverride: CallableMemberDescriptor) {
OverridingUtil.resolveUnknownVisibilityForMember(fakeOverride, null) OverridingUtil.resolveUnknownVisibilityForMember(fakeOverride, null)
result.add(fakeOverride as FunctionDescriptor) result.add(fakeOverride as FunctionDescriptor)
} }
@@ -235,7 +235,7 @@ public class EnumEntrySyntheticClassDescriptor extends ClassDescriptorBase {
new OverridingUtil.DescriptorSink() { new OverridingUtil.DescriptorSink() {
@Override @Override
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
public void addToScope(@NotNull CallableMemberDescriptor fakeOverride) { public void addFakeOverride(@NotNull CallableMemberDescriptor fakeOverride) {
OverridingUtil.resolveUnknownVisibilityForMember(fakeOverride, null); OverridingUtil.resolveUnknownVisibilityForMember(fakeOverride, null);
result.add((D) fakeOverride); result.add((D) fakeOverride);
} }
@@ -356,7 +356,7 @@ public class OverridingUtil {
for (CallableMemberDescriptor descriptor : effectiveOverridden) { for (CallableMemberDescriptor descriptor : effectiveOverridden) {
bindOverride(fakeOverride, descriptor); bindOverride(fakeOverride, descriptor);
} }
sink.addToScope(fakeOverride); sink.addFakeOverride(fakeOverride);
} }
@NotNull @NotNull
@@ -569,7 +569,7 @@ public class OverridingUtil {
} }
public interface DescriptorSink { public interface DescriptorSink {
void addToScope(@NotNull CallableMemberDescriptor fakeOverride); void addFakeOverride(@NotNull CallableMemberDescriptor fakeOverride);
void conflict(@NotNull CallableMemberDescriptor fromSuper, @NotNull CallableMemberDescriptor fromCurrent); void conflict(@NotNull CallableMemberDescriptor fromSuper, @NotNull CallableMemberDescriptor fromCurrent);
} }
@@ -203,7 +203,7 @@ public class DeserializedClassDescriptor(
private fun <D : CallableMemberDescriptor> generateFakeOverrides(name: Name, fromSupertypes: Collection<D>, result: MutableCollection<D>) { private fun <D : CallableMemberDescriptor> generateFakeOverrides(name: Name, fromSupertypes: Collection<D>, result: MutableCollection<D>) {
val fromCurrent = ArrayList<CallableMemberDescriptor>(result) val fromCurrent = ArrayList<CallableMemberDescriptor>(result)
OverridingUtil.generateOverridesInFunctionGroup(name, fromSupertypes, fromCurrent, classDescriptor, object : OverridingUtil.DescriptorSink { OverridingUtil.generateOverridesInFunctionGroup(name, fromSupertypes, fromCurrent, classDescriptor, object : OverridingUtil.DescriptorSink {
override fun addToScope(fakeOverride: CallableMemberDescriptor) { override fun addFakeOverride(fakeOverride: CallableMemberDescriptor) {
// TODO: report "cannot infer visibility" // TODO: report "cannot infer visibility"
OverridingUtil.resolveUnknownVisibilityForMember(fakeOverride, null) OverridingUtil.resolveUnknownVisibilityForMember(fakeOverride, null)
@suppress("UNCHECKED_CAST") @suppress("UNCHECKED_CAST")